vsk marked an inline comment as done.
vsk added inline comments.
================
Comment at:
lldb/packages/Python/lldbsuite/test/functionalities/dw_op_piece/main.cpp:34
+ //% self.filecheck("image lookup -va $pc", "main.cpp",
"-check-prefix=INFO-V1")
+ // INFO-V1: name = "v1", type = "S1", location = DW_OP_reg0 RAX, DW_OP_piece
0x4, DW_OP_piece 0x4, DW_OP_lit0, DW_OP_stack_value, DW_OP_piece 0x8, decl
+ sink++;
----------------
aprantl wrote:
> It seems unlikely that this lowering survives very long. Could you move this
> to unit tests instead?
I'm not sure how to write this as a unit test. I expect that the added
regression test + assembly test covers what we want to cover, though.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73148/new/
https://reviews.llvm.org/D73148
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
