[Lldb-commits] [lldb] 1c90ce0 - [lldb/Test] Disable hardware check on arm/aarch64

Author: Jonas Devlieghere Date: 2020-01-24T20:54:18-08:00 New Revision: 1c90ce0c761719ab58361402fb85c0b58680832b URL: https://github.com/llvm/llvm-project/commit/1c90ce0c761719ab58361402fb85c0b58680832b DIFF: https://github.com/llvm/llvm-project/commit/1c90ce0c761719ab58361402fb85c0b58680832b.d

[Lldb-commits] [lldb] 1ed561a - [lldb/Test] Update minidebuginfo-set-and-hit-breakpoint.test

Author: Jonas Devlieghere Date: 2020-01-24T20:47:31-08:00 New Revision: 1ed561aa4bdc2e9f5e743ffcbdbe10a3443947dd URL: https://github.com/llvm/llvm-project/commit/1ed561aa4bdc2e9f5e743ffcbdbe10a3443947dd DIFF: https://github.com/llvm/llvm-project/commit/1ed561aa4bdc2e9f5e743ffcbdbe10a3443947dd.d

[Lldb-commits] [PATCH] D73389: [lldb/Breakpoint] Include whether or not a breakpoint is a HW BP

This revision was automatically updated to reflect the committed changes. Closed by commit rGd8e0f4fae7a2: [lldb/Breakpoint] Include whether or not a breakpoint is a HW BP (authored by JDevlieghere). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7338

[Lldb-commits] [PATCH] D73401: [ldb/Breakpoint] Recognize HW breakpoints as breakpoints instead of just mach exceptions.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2bc38ab3d038: [lldb/Breakpoint] Recogize hardware breakpoints as such (authored by JDevlieghere). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73401/new/ h

[Lldb-commits] [lldb] d8e0f4f - [lldb/Breakpoint] Include whether or not a breakpoint is a HW BP

Author: Jonas Devlieghere Date: 2020-01-24T19:24:25-08:00 New Revision: d8e0f4fae7a2d6a2510d9eea21a12ed9b8948d65 URL: https://github.com/llvm/llvm-project/commit/d8e0f4fae7a2d6a2510d9eea21a12ed9b8948d65 DIFF: https://github.com/llvm/llvm-project/commit/d8e0f4fae7a2d6a2510d9eea21a12ed9b8948d65.d

[Lldb-commits] [lldb] 2bc38ab - [lldb/Breakpoint] Recogize hardware breakpoints as such

Author: Jonas Devlieghere Date: 2020-01-24T19:24:25-08:00 New Revision: 2bc38ab3d038344317b7299e4a562f5724180f5a URL: https://github.com/llvm/llvm-project/commit/2bc38ab3d038344317b7299e4a562f5724180f5a DIFF: https://github.com/llvm/llvm-project/commit/2bc38ab3d038344317b7299e4a562f5724180f5a.d

[Lldb-commits] [PATCH] D73401: [ldb/Breakpoint] Recognize HW breakpoints as breakpoints instead of just mach exceptions.

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Looks like a good change. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73401/new/ https://reviews.llvm.org/D73401 ___

[Lldb-commits] [PATCH] D73389: [lldb/Breakpoint] Include whether or not a breakpoint is a HW BP

JDevlieghere updated this revision to Diff 240350. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73389/new/ https://reviews.llvm.org/D73389 Files: lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/hardware_breakpoints/hardware_breakpoint_on_multiple_threads/TestHWBreakMul

[Lldb-commits] [PATCH] D73401: [ldb/Breakpoint] Recognize HW breakpoints as breakpoints instead of just mach exceptions.

JDevlieghere created this revision. JDevlieghere added a reviewer: jasonmolenda. Herald added a project: LLDB. Repository: rLLDB LLDB https://reviews.llvm.org/D73401 Files: lldb/include/lldb/Breakpoint/BreakpointSite.h lldb/include/lldb/Breakpoint/StoppointLocation.h lldb/packages/Pytho

[Lldb-commits] [PATCH] D73303: [lldb/Target] Add Abort StackFrame Recognizer

jingham added inline comments. Comment at: lldb/source/Target/AbortRecognizer.cpp:81 +ThreadSP thread_sp, FileSpec module_spec, ConstString function_name) { + const uint32_t frames_to_fetch = 10; + StackFrameSP prev_frame_sp = nullptr; jingham wrote: > mib

[Lldb-commits] [PATCH] D69273: ValueObject: Fix a crash related to children address type computation

jingham added a comment. In D69273#1765235 , @davide wrote: > We've been off all the past week. I'll circle back with Jim about this once I > get to the office. Sorry, I've been busy with other things. In answer to Pavel's direct question "What did we

[Lldb-commits] [PATCH] D73389: [lldb/Breakpoint] Include whether or not a breakpoint is a HW BP

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73389/new/ https://reviews.llvm.org/D73389 ___ lldb-commit

[Lldb-commits] [PATCH] D73384: [lldb/Lit] Change the lldbtest format to behave more like shell test.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe3a7c7713cd8: [lldb/Lit] Change the lldbtest format to behave more like shell test. (authored by JDevlieghere). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[Lldb-commits] [lldb] e3a7c77 - [lldb/Lit] Change the lldbtest format to behave more like shell test.

Author: Jonas Devlieghere Date: 2020-01-24T16:17:55-08:00 New Revision: e3a7c7713cd87e37a95a544373cd21f6f06ab94e URL: https://github.com/llvm/llvm-project/commit/e3a7c7713cd87e37a95a544373cd21f6f06ab94e DIFF: https://github.com/llvm/llvm-project/commit/e3a7c7713cd87e37a95a544373cd21f6f06ab94e.d

[Lldb-commits] [PATCH] D73389: [lldb/Breakpoint] Include whether or not a breakpoint is a HW BP

JDevlieghere created this revision. JDevlieghere added reviewers: LLDB, jingham. Herald added a project: LLDB. Include whether or not a breakpoint is a hardware breakpoint in the breakpoint list. (lldb) breakpoint list Current breakpoints: 1: name = 'main', locations = 1, resolved = 1, hit

[Lldb-commits] [PATCH] D71313: [AST] Split parent map traversal logic into ParentMapContext.h

steveire added a comment. Should this new class have some tests? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71313/new/ https://reviews.llvm.org/D71313 ___ lldb-commits mailing list lldb-commits@list

[Lldb-commits] [PATCH] D73384: [lldb/Lit] Change the lldbtest format to behave more like shell test.

vsk accepted this revision as: vsk. vsk added a comment. This revision is now accepted and ready to land. Nice! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73384/new/ https://reviews.llvm.org/D73384 ___ lldb-comm

[Lldb-commits] [PATCH] D72981: [debugserver] Unify the breakpoint/watchpoint interface (NFCI)

This revision was automatically updated to reflect the committed changes. Closed by commit rG9902c8e3c661: [lldb/debugserver] Unify the breakpoint/watchpoint interface (NFCI) (authored by JDevlieghere). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7

[Lldb-commits] [PATCH] D72985: [lldb/debugserver] Implement hardware breakpoints for x86_64 and i386

This revision was automatically updated to reflect the committed changes. Closed by commit rG96f3ea0d21b4: [lldb/debugserver] Implement hardware breakpoints for x86_64 and i386 (authored by JDevlieghere). Changed prior to commit: https://reviews.llvm.org/D72985?vs=238964&id=240307#toc Reposito

[Lldb-commits] [lldb] 96f3ea0 - [lldb/debugserver] Implement hardware breakpoints for x86_64 and i386

Author: Jonas Devlieghere Date: 2020-01-24T15:07:31-08:00 New Revision: 96f3ea0d21b48ca088355db10d4d1a2e9bc9f884 URL: https://github.com/llvm/llvm-project/commit/96f3ea0d21b48ca088355db10d4d1a2e9bc9f884 DIFF: https://github.com/llvm/llvm-project/commit/96f3ea0d21b48ca088355db10d4d1a2e9bc9f884.d

[Lldb-commits] [lldb] 9902c8e - [lldb/debugserver] Unify the breakpoint/watchpoint interface (NFCI)

Author: Jonas Devlieghere Date: 2020-01-24T15:07:31-08:00 New Revision: 9902c8e3c6615185a8a00325fa4671c63b61d535 URL: https://github.com/llvm/llvm-project/commit/9902c8e3c6615185a8a00325fa4671c63b61d535 DIFF: https://github.com/llvm/llvm-project/commit/9902c8e3c6615185a8a00325fa4671c63b61d535.d

[Lldb-commits] [PATCH] D73384: [lldb/Lit] Change the lldbtest format to behave more like shell test.

JDevlieghere created this revision. JDevlieghere added reviewers: LLDB, labath. Herald added a subscriber: abidh. Herald added a project: LLDB. The current lldbtest format has a number of shortcomings, all related to how we omit information based on why the test fails. For example, a successful t

[Lldb-commits] [PATCH] D72981: [debugserver] Unify the breakpoint/watchpoint interface (NFCI)

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Looks good. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72981/new/ https://reviews.llvm.org/D72981 _

[Lldb-commits] [PATCH] D72985: [lldb/debugserver] Implement hardware breakpoints for x86_64 and i386

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Sorry for the delay, looks good to me. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72985/new/ https://reviews.llvm.org/D72985 __

[Lldb-commits] [PATCH] D70840: [LLDB] [DWARF] Strip out the thumb bit from addresses on ARM

mstorsjo updated this revision to Diff 240292. mstorsjo added a comment. I tried doing the other alternative; now we primarily touch up the values in DWARFDebugInfoEntry::GetAttributeAddressRange(s) and DWARFDebugInfoEntry::GetDIENamesAndRanges. This variant feels fairly concise and consistent.

[Lldb-commits] [PATCH] D73148: [lldb/Value] Report size of Value as size of underlying data buffer

aprantl added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/functionalities/dw_op_piece/main.cpp:34 + //% self.filecheck("image lookup -va $pc", "main.cpp", "-check-prefix=INFO-V1") + // INFO-V1: name = "v1", type = "S1", location = DW_OP_reg0 RAX, DW_OP_pi

[Lldb-commits] [PATCH] D73148: [lldb/Value] Report size of Value as size of underlying data buffer

aprantl added a comment. Yes you have. Sorry for the noise. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73148/new/ https://reviews.llvm.org/D73148 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[Lldb-commits] [PATCH] D73148: [lldb/Value] Report size of Value as size of underlying data buffer

aprantl added a comment. In D73148#1835488 , @labath wrote: > In D73148#1834955 , @vsk wrote: > > > In D73148#1832897 , @clayborg > > wrote: > > > > > Actually it would be n

[Lldb-commits] [lldb] 118efa5 - [LLDB][NFC] Adding clarifying comment in SymbolFileDWARFDebugMap::DumpClangAST(...)

Author: shafik Date: 2020-01-24T14:01:15-08:00 New Revision: 118efa5cda868604f3507760ca061f69b0050b19 URL: https://github.com/llvm/llvm-project/commit/118efa5cda868604f3507760ca061f69b0050b19 DIFF: https://github.com/llvm/llvm-project/commit/118efa5cda868604f3507760ca061f69b0050b19.diff LOG: [

[Lldb-commits] [PATCH] D71313: [AST] Split parent map traversal logic into ParentMapContext.h

This revision was automatically updated to reflect the committed changes. Closed by commit rG8a81daaa8b58: [AST] Split parent map traversal logic into ParentMapContext.h (authored by rnk). Changed prior to commit: https://reviews.llvm.org/D71313?vs=240050&id=240283#toc Repository: rG LLVM Gi

[Lldb-commits] [lldb] 8a81daa - [AST] Split parent map traversal logic into ParentMapContext.h

Author: Reid Kleckner Date: 2020-01-24T13:42:28-08:00 New Revision: 8a81daaa8b58aeaa192a47c4ce7f94b4d59ce082 URL: https://github.com/llvm/llvm-project/commit/8a81daaa8b58aeaa192a47c4ce7f94b4d59ce082 DIFF: https://github.com/llvm/llvm-project/commit/8a81daaa8b58aeaa192a47c4ce7f94b4d59ce082.diff

[Lldb-commits] [PATCH] D72751: [LLDB] Add DynamicLoaderWasmDYLD plugin for WebAssembly debugging

paolosev updated this revision to Diff 240262. paolosev added a comment. Modified to set `m_file_offset` to be the correct offset of the Code section. This also simplifies the code in ObjectFileWasm to avoid a special case for the code section in `ObjectFileWasm::SetLoadAddress`. The DWARF code

[Lldb-commits] [PATCH] D72953: Fix the handling of unnamed bit-fields when parsing DWARF

shafik marked 2 inline comments as done. shafik added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/lang/cpp/bitfields/main.cpp:76 + lbd.arr[1] = 'b'; + lbd.arr[2] = 'c'; + lbd.a = 5; labath wrote: > BTW, I've changed this to '\0' because th

[Lldb-commits] [PATCH] D73303: [lldb/Target] Add Abort StackFrame Recognizer

friss added inline comments. Comment at: lldb/source/Target/AbortRecognizer.cpp:81 +ThreadSP thread_sp, FileSpec module_spec, ConstString function_name) { + const uint32_t frames_to_fetch = 10; + StackFrameSP prev_frame_sp = nullptr; jingham wrote: > mib wr

[Lldb-commits] [PATCH] D73303: [lldb/Target] Add Abort StackFrame Recognizer

mib updated this revision to Diff 240238. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73303/new/ https://reviews.llvm.org/D73303 Files: lldb/include/lldb/Target/AbortRecognizer.h lldb/include/lldb/Target/StackFrameRecognizer.h lldb/include/l

[Lldb-commits] [PATCH] D73303: [lldb/Target] Add Abort StackFrame Recognizer

jingham added inline comments. Comment at: lldb/source/Target/AbortRecognizer.cpp:81 +ThreadSP thread_sp, FileSpec module_spec, ConstString function_name) { + const uint32_t frames_to_fetch = 10; + StackFrameSP prev_frame_sp = nullptr; mib wrote: > friss wr

[Lldb-commits] [PATCH] D73303: [lldb/Target] Add Abort StackFrame Recognizer

mib marked an inline comment as done. mib added inline comments. Comment at: lldb/source/Target/AbortRecognizer.cpp:81 +ThreadSP thread_sp, FileSpec module_spec, ConstString function_name) { + const uint32_t frames_to_fetch = 10; + StackFrameSP prev_frame_sp = nullptr;

[Lldb-commits] [PATCH] D73303: [lldb/Target] Add Abort StackFrame Recognizer

friss added inline comments. Comment at: lldb/source/Target/AbortRecognizer.cpp:81 +ThreadSP thread_sp, FileSpec module_spec, ConstString function_name) { + const uint32_t frames_to_fetch = 10; + StackFrameSP prev_frame_sp = nullptr; mib wrote: > JDevlieghe

[Lldb-commits] [PATCH] D73303: [lldb/Target] Add Abort StackFrame Recognizer

mib updated this revision to Diff 240213. mib marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73303/new/ https://reviews.llvm.org/D73303 Files: lldb/include/lldb/Target/AbortRecognizer.h lldb/include/lldb/Target/S

[Lldb-commits] [PATCH] D73303: [lldb/Target] Add Abort StackFrame Recognizer

mib marked 14 inline comments as done. mib added inline comments. Comment at: lldb/source/Target/AbortRecognizer.cpp:1 +//===-- AbortRecognizer.cpp -*- C++ -*-===// +// teemperor wrote: > Please remove the `-*- C++ -*-` as tha

[Lldb-commits] [PATCH] D73191: Ignore methods in full-name function lookup (with accelerators)

jarin marked an inline comment as done. jarin added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFIndex.cpp:45 if (name_type_mask & eFunctionNameTypeFull) { -dies.push_back(die); -return; +if (!die.IsMethod() || die.GetMangledName(false) ==

[Lldb-commits] [PATCH] D73345: [lldb] Don't create duplicate declarations when completing a forward declaration with a definition from another source

labath resigned from this revision. labath added a comment. The description makes sense to me but I don't know much about this stuff. I'll leave it to @shafik to ack this... Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73345/new/ https://reviews.llvm.org/D733

[Lldb-commits] [PATCH] D73345: [lldb] Don't create duplicate declarations when completing a forward declaration with a definition from another source

teemperor created this revision. teemperor added reviewers: shafik, labath. Herald added subscribers: lldb-commits, JDevlieghere, abidh, aprantl. Herald added a project: LLDB. I noticed this strange line in `ASTImporterDelegate::ImportDefinitionTo` which doesn't make a lot of sense: to_tag->se

[Lldb-commits] [lldb] 06ae374 - [lldb][NFC] Cleanup some if conditions in ASTImporterDelegate::Imported

Author: Raphael Isemann Date: 2020-01-24T13:49:25+01:00 New Revision: 06ae3748db8a23568f2f238a9534ea9052725ea3 URL: https://github.com/llvm/llvm-project/commit/06ae3748db8a23568f2f238a9534ea9052725ea3 DIFF: https://github.com/llvm/llvm-project/commit/06ae3748db8a23568f2f238a9534ea9052725ea3.dif

[Lldb-commits] [PATCH] D73191: Ignore methods in full-name function lookup (with accelerators)

labath added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFIndex.cpp:45 if (name_type_mask & eFunctionNameTypeFull) { -dies.push_back(die); -return; +if (!die.IsMethod() || die.GetMangledName(false) == name) { + dies.push_back(die); --

[Lldb-commits] [PATCH] D73024: [lldb] Complete return types of CXXMethodDecls to prevent crashing due to covariant return types

teemperor updated this revision to Diff 240156. teemperor added a comment. - Made test stricter. - Moved code to ASTImporterDelegate. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73024/new/ https://reviews.llvm.org/D73024 Files: lldb/packages/Python/lldbsuite/test/lang/cpp/covariant

[Lldb-commits] [PATCH] D73191: Ignore methods in full-name function lookup (with accelerators)

jarin added a comment. Pavel, does the latest patch address (and test) what you were worried about? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73191/new/ https://reviews.llvm.org/D73191 ___ lldb-commits mailing list lldb-commits@lists.ll

[Lldb-commits] [PATCH] D73191: Ignore methods in full-name function lookup (with accelerators)

jarin updated this revision to Diff 240144. jarin edited the summary of this revision. jarin added a comment. Updated to include all methods/non-methods with matching mangled name. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73191/new/ https://reviews.llvm.org/D73191 Files: lldb/so

[Lldb-commits] [PATCH] D72953: Fix the handling of unnamed bit-fields when parsing DWARF

labath added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/lang/cpp/bitfields/main.cpp:76 + lbd.arr[1] = 'b'; + lbd.arr[2] = 'c'; + lbd.a = 5; BTW, I've changed this to '\0' because the memory following this array is uninitialized, and that

[Lldb-commits] [lldb] d4b092b - [lldb/DWARF] Remove a workaround from DebugNamesDWARFIndex

Author: Pavel Labath Date: 2020-01-24T12:09:20+01:00 New Revision: d4b092b34125d6c571d43a185a1c774244b76957 URL: https://github.com/llvm/llvm-project/commit/d4b092b34125d6c571d43a185a1c774244b76957 DIFF: https://github.com/llvm/llvm-project/commit/d4b092b34125d6c571d43a185a1c774244b76957.diff

[Lldb-commits] [lldb] 77cedb0 - [lldb] Fix nondeterminism in TestCppBitfields

Author: Pavel Labath Date: 2020-01-24T12:09:20+01:00 New Revision: 77cedb0cdb8623ff9eb22dbf3b9302ee4d9f8a20 URL: https://github.com/llvm/llvm-project/commit/77cedb0cdb8623ff9eb22dbf3b9302ee4d9f8a20 DIFF: https://github.com/llvm/llvm-project/commit/77cedb0cdb8623ff9eb22dbf3b9302ee4d9f8a20.diff

[Lldb-commits] [lldb] c0738d2 - [lldb][NFC] Fix formatting in ASTImporterDelegate::ImportImpl

Author: Raphael Isemann Date: 2020-01-24T11:57:06+01:00 New Revision: c0738d2480b93b1c3b354a2be16ea5f6e545c5ef URL: https://github.com/llvm/llvm-project/commit/c0738d2480b93b1c3b354a2be16ea5f6e545c5ef DIFF: https://github.com/llvm/llvm-project/commit/c0738d2480b93b1c3b354a2be16ea5f6e545c5ef.dif

[Lldb-commits] [lldb] 36f12d2 - [lldb][NFC] Delete unused ClangASTImporter::CompleteDecl

Author: Raphael Isemann Date: 2020-01-24T11:54:12+01:00 New Revision: 36f12d2638f887c417bd1167a54e0e6f1bf3daca URL: https://github.com/llvm/llvm-project/commit/36f12d2638f887c417bd1167a54e0e6f1bf3daca DIFF: https://github.com/llvm/llvm-project/commit/36f12d2638f887c417bd1167a54e0e6f1bf3daca.dif

[Lldb-commits] [PATCH] D70840: [LLDB] [DWARF] Strip out the thumb bit from addresses on ARM

mstorsjo added a comment. In D70840#1838186 , @labath wrote: > Yes, I was keeping this problem in mind when I was working on that patch. :) > I believe more work could be done to reduce the number of places that parse > DW_AT_low/high_pc, but I haven't g

[Lldb-commits] [PATCH] D70840: [LLDB] [DWARF] Strip out the thumb bit from addresses on ARM

labath added a comment. Yes, I was keeping this problem in mind when I was working on that patch. :) I believe more work could be done to reduce the number of places that parse DW_AT_low/high_pc, but I haven't gotten around to that yet.. The thing that I am not sure we have fully explored is wh

[Lldb-commits] [PATCH] D73206: `DWARFASTParserClang::m_decl_ctx_to_die` `DWARFDIE`->`DIERef` for DWZ

labath added a comment. BTW, I am currently trying to clean up the dwo/dwp code, and here (I think) I ran into a very similar problem to what you are encountering. Dwo units currently contain a backlink to the skeleton unit that uses them, and we have a fairly convoluted system (that's the part

[Lldb-commits] [PATCH] D70840: [LLDB] [DWARF] Strip out the thumb bit from addresses on ARM

mstorsjo updated this revision to Diff 240118. mstorsjo added a comment. Herald added a reviewer: shafik. Hopefully this is a bit less schizophrenic now. It's still quite RFC'y and many of the fixup loops could probably still be refactored, if someone suggests where to place the shared code. C

[Lldb-commits] [PATCH] D70840: [LLDB] [DWARF] Strip out the thumb bit from addresses on ARM

mstorsjo added a comment. In D70840#1792498 , @labath wrote: > In D70840#1791292 , @mstorsjo wrote: > > > And irrespectively if the ArchSpec vs Architecture design, can you (either > > of you) comment on the update

[Lldb-commits] [PATCH] D72946: [lldb] Remove ClangASTImporter reference from Target

teemperor added inline comments. Comment at: lldb/include/lldb/Symbol/TypeSystemClang.h:38 +#include "Plugins/ExpressionParser/Clang/ClangPersistentVariables.h" + I would also just let this be part of the normal include list without the empty line (or wherever

[Lldb-commits] [PATCH] D72751: [LLDB] Add DynamicLoaderWasmDYLD plugin for WebAssembly debugging

labath added a comment. In D72751#1837883 , @aadsm wrote: > Yeah, I'm not sure why the LoadModules function is calling > target.SetExecutableModule. It is true that the libraries-svr4 will not > include the main executable in its list. > This code was a

[Lldb-commits] [PATCH] D72946: [lldb] Remove ClangASTImporter reference from Target

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. In D72946#1827372 , @clayborg wrote: > Is an AST importer specific to a target? Can we just put it into the Clang > AST type system subclass and

[Lldb-commits] [PATCH] D72751: [LLDB] Add DynamicLoaderWasmDYLD plugin for WebAssembly debugging

labath added a comment. In D72751#1837764 , @paolosev wrote: > Thanks for the explanation! I wasn't quite clear on "executable module" here, > but after your comments I realized that `Target::SetExecutableModule()` > should not probably be called also fo

[Lldb-commits] [lldb] 041fa5a - [lldb] Fix file header of Host/posix/FileSystemPosix.cpp

Author: Fangrui Song Date: 2020-01-24T00:29:53-08:00 New Revision: 041fa5ad7c3c61b2253efaa049326ea7e98752ab URL: https://github.com/llvm/llvm-project/commit/041fa5ad7c3c61b2253efaa049326ea7e98752ab DIFF: https://github.com/llvm/llvm-project/commit/041fa5ad7c3c61b2253efaa049326ea7e98752ab.diff