shafik marked 2 inline comments as done.
shafik added inline comments.

================
Comment at: lldb/packages/Python/lldbsuite/test/lang/cpp/bitfields/main.cpp:76
+  lbd.arr[1] = 'b';
+  lbd.arr[2] = 'c';
+  lbd.a = 5;
----------------
labath wrote:
> BTW, I've changed this to '\0' because the memory following this array is 
> uninitialized, and that would confuse the the "const char *" pretty printer, 
> which would continue to print the garbage after the array. The actual value 
> of `arr` does not seem to be relevant for this test (I hope), but the pretty 
> printer behavior is suboptimal, so I've filed pr44649 to track that.
Thank you for catching that and patching!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72953/new/

https://reviews.llvm.org/D72953



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to