Author: Pavel Labath Date: 2020-01-24T12:09:20+01:00 New Revision: d4b092b34125d6c571d43a185a1c774244b76957
URL: https://github.com/llvm/llvm-project/commit/d4b092b34125d6c571d43a185a1c774244b76957 DIFF: https://github.com/llvm/llvm-project/commit/d4b092b34125d6c571d43a185a1c774244b76957.diff LOG: [lldb/DWARF] Remove a workaround from DebugNamesDWARFIndex This was needed when asking a compile unit for its dwo component triggered a infinite recursion if the dwo unit has not been already parsed. This has since been fixed. Added: Modified: lldb/source/Plugins/SymbolFile/DWARF/DebugNamesDWARFIndex.cpp Removed: ################################################################################ diff --git a/lldb/source/Plugins/SymbolFile/DWARF/DebugNamesDWARFIndex.cpp b/lldb/source/Plugins/SymbolFile/DWARF/DebugNamesDWARFIndex.cpp index 3cd082bc213b..705578c2e4eb 100644 --- a/lldb/source/Plugins/SymbolFile/DWARF/DebugNamesDWARFIndex.cpp +++ b/lldb/source/Plugins/SymbolFile/DWARF/DebugNamesDWARFIndex.cpp @@ -53,12 +53,7 @@ DebugNamesDWARFIndex::ToDIERef(const DebugNames::Entry &entry) { if (!cu) return llvm::None; - // This initializes the DWO symbol file. It's not possible for - // GetDwoSymbolFile to call this automatically because of mutual recursion - // between this and DWARFDebugInfoEntry::GetAttributeValue. - cu->ExtractUnitDIEIfNeeded(); cu = &cu->GetNonSkeletonUnit(); - if (llvm::Optional<uint64_t> die_offset = entry.getDIEUnitOffset()) return DIERef(cu->GetSymbolFileDWARF().GetDwoNum(), DIERef::Section::DebugInfo, cu->GetOffset() + *die_offset); _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
