[Lldb-commits] [PATCH] D64647: [lldb] [Process/NetBSD] Multithread support

mgorny added a comment. Nevermind that long report, it actually turned out to be a bug in NetBSD kernel that resulted in the thread not being resumed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64647/new/ https://reviews.llvm.org/D64647 ___

[Lldb-commits] [PATCH] D67791: dotest.py: bugfix: test filters with -f do not work on Python3

This revision was automatically updated to reflect the committed changes. Closed by commit rL372441: dotest.py: bugfix: test filters with -f do not work on Python3 (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to co

[Lldb-commits] [PATCH] D67790: prepare_binding_Python: print readable errors if SWIG fails

This revision was automatically updated to reflect the committed changes. Closed by commit rL372442: prepare_binding_Python: print readable errors if SWIG fails (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commi

[Lldb-commits] [PATCH] D67869: [ABISysV] Fix regression for Simulator and MacABI

JDevlieghere created this revision. JDevlieghere added reviewers: aprantl, xiaobai. Herald added a subscriber: abidh. Herald added a project: LLDB. The ABISysV ABI was refactored in r364216 to support the Windows ABI for x86_64. In particular it changed `ABISysV_x86_64::CreateInstance` to switch

[Lldb-commits] [lldb] r372442 - prepare_binding_Python: print readable errors if SWIG fails

Author: jdevlieghere Date: Fri Sep 20 16:41:32 2019 New Revision: 372442 URL: http://llvm.org/viewvc/llvm-project?rev=372442&view=rev Log: prepare_binding_Python: print readable errors if SWIG fails When swig fails, all the errors are squished onto one line with \n quoting. It's very hard to read

[Lldb-commits] [lldb] r372441 - dotest.py: bugfix: test filters with -f do not work on Python3

Author: jdevlieghere Date: Fri Sep 20 16:41:29 2019 New Revision: 372441 URL: http://llvm.org/viewvc/llvm-project?rev=372441&view=rev Log: dotest.py: bugfix: test filters with -f do not work on Python3 dotest -f does not work on Python3. The name types.UnboundMethodType was an alias for types.Me

[Lldb-commits] [PATCH] D67774: [Mangle] Add flag to asm labels to disable global prefixing

rjmccall added inline comments. Comment at: clang/include/clang/Basic/Attr.td:725 let Spellings = [Keyword<"asm">, Keyword<"__asm__">]; - let Args = [StringArgument<"Label">]; + let Args = [StringArgument<"Label">, BoolArgument<"LiteralLabel">]; let SemaHandler = 0; -

[Lldb-commits] [PATCH] D67866: [lldb] Unify python site-packages path

hhb updated this revision to Diff 221123. hhb added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67866/new/ https://reviews.llvm.org/D67866 Files: lldb/CMakeLists.txt lldb/scripts/CMakeLists.txt lldb/scripts/Python/finishS

[Lldb-commits] [PATCH] D67866: [lldb] Unify python site-packages path

hhb created this revision. hhb added a reviewer: labath. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. Before this change, the procedure of installing and loading python modules are as follow: 1. finishSwigPythonLLDB.py writes necessary files to ${CMAKE_BINARY_DIR

[Lldb-commits] [PATCH] D67863: [LLDB] Cast -1 (as invalid socket) to the socket type before comparing

mstorsjo updated this revision to Diff 221122. mstorsjo added a comment. Use static_cast. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67863/new/ https://reviews.llvm.org/D67863 Files: lldb/source/Host/common/Socket.cpp lldb/tools/lldb-vscode/lldb-vscode.cpp Index: lldb/tools/ll

[Lldb-commits] [PATCH] D67863: [LLDB] Cast -1 (as invalid socket) to the socket type before comparing

compnerd added inline comments. Comment at: lldb/source/Host/common/Socket.cpp:479 } - NativeSocket fd = llvm::sys::RetryAfterSignal(-1, ::accept4, + NativeSocket fd = llvm::sys::RetryAfterSignal((NativeSocket) -1, ::accept4, sockfd, addr, addrlen, flags); ---

[Lldb-commits] [PATCH] D67793: new api class: SBFile

lawrence_danna updated this revision to Diff 221113. lawrence_danna added a comment. added some tests, rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67793/new/ https://reviews.llvm.org/D67793 Files: lldb/include/lldb/API/LLDB.h lldb/in

[Lldb-commits] [PATCH] D67863: [LLDB] Cast -1 (as invalid socket) to the socket type before comparing

mstorsjo created this revision. mstorsjo added reviewers: hhb, labath, compnerd. Herald added subscribers: JDevlieghere, abidh. Herald added a project: LLDB. This silences warnings about comparison of integers between unsigned long long (which is what the Windows SOCKET type is) and signed int wh

[Lldb-commits] [PATCH] D67862: [LLDB] Use SetErrorStringWithFormatv for cases that use LLVM style format strings

mstorsjo created this revision. mstorsjo added reviewers: asmith, hhb, labath, compnerd. Herald added a subscriber: JDevlieghere. Herald added a project: LLDB. SetErrorStringWithFormat only supports normal printf style format strings. Repository: rLLDB LLDB https://reviews.llvm.org/D67862 Fi

[Lldb-commits] [PATCH] D67583: Fix swig python package path

ZeGentzy added a comment. In D67583#1676531 , @labath wrote: > I could be off mark here, but I do recall some people trying to get this code > to work in environments where python and lldb(llvm) are configured with > different libdirs (so LLVM_LIBDIR_SUF

[Lldb-commits] [PATCH] D67861: [LLDB] Check for the __MINGW32__ define instead of __MINGW64

mstorsjo created this revision. mstorsjo added reviewers: hhb, xen2, labath. Herald added subscribers: JDevlieghere, abidh. Herald added a project: LLDB. `__MINGW64__` is only defined for 64 bit targets, and the define without trailing underscores is never defined automatically (neither by clang

[Lldb-commits] [PATCH] D67860: [LLDB] Use LLVM_FALLTHROUGH instead of a custom comment

mstorsjo created this revision. mstorsjo added reviewers: asmith, hhb, labath. Herald added a subscriber: JDevlieghere. Herald added a project: LLDB. This fixes a warning when built with Clang instead of MSVC. Repository: rLLDB LLDB https://reviews.llvm.org/D67860 Files: lldb/source/Plugin

[Lldb-commits] [PATCH] D66398: 2/2: Fix `TestDataFormatterStdList` regression

jankratochvil added a comment. "jankratochvil added a reverting change" - that is not true, Differential got somehow confused by the commit text there talking about this patch. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66398/new/ https://reviews.llvm.org/D663

[Lldb-commits] [PATCH] D67859: [LLDB] Use the Windows SOCKET type on all windows targets, not only MSVC

mstorsjo created this revision. mstorsjo added reviewers: hhb, labath, amccarth. Herald added a subscriber: JDevlieghere. Herald added a project: LLDB. Repository: rLLDB LLDB https://reviews.llvm.org/D67859 Files: lldb/include/lldb/Host/Socket.h Index: lldb/include/lldb/Host/Socket.h =

[Lldb-commits] [PATCH] D67856: [LLDB] Fix compilation for MinGW, remove redundant class name on inline member

davide added a comment. Just keep an eye on the bots as they might start whining http://green.lab.llvm.org/green/ otherwise, just go ahead. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67856/new/ https://reviews.llvm.org/D67856

[Lldb-commits] [PATCH] D67858: [LLDB] Check for the GCC/MinGW compatible arch defines for windows, in addition to MSVC defines

mstorsjo created this revision. mstorsjo added reviewers: compnerd, hhb, labath. Herald added subscribers: JDevlieghere, abidh. Herald added a project: LLDB. This matches how it is done in all other similar ifdefs throughout lldb (modulo inconsistencies between `_M_AMD64` and `_M_X64`); both MSVC

[Lldb-commits] [PATCH] D67856: [LLDB] Fix compilation for MinGW, remove redundant class name on inline member

mstorsjo added a comment. In D67856#1677356 , @davide wrote: > If this doesn't break clang and gcc, fine. FWIW, it was with clang that I ran into it, haven't tested building lldb with gcc. But the issue can be tested with a snippet like this: class

[Lldb-commits] [PATCH] D67857: [LLDB] Include lldb/Host/windows/windows.h on any windows target

mstorsjo created this revision. mstorsjo added reviewers: lanza, hhb, labath. Herald added subscribers: JDevlieghere, abidh. Herald added a project: LLDB. This fixes MinGW builds, that otherwise fail due to use of undeclared `GetLastError()` and `ERROR_OPERATION_ABORTED`. The use of `GetLastErro

[Lldb-commits] [PATCH] D66654: 2/2: Process formatters in reverse-chronological order

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL372424: [lldb] Process formatters in reverse-chronological order (authored by jankratochvil, committed by ). Herald added

[Lldb-commits] [PATCH] D67856: [LLDB] Fix compilation for MinGW, remove redundant class name on inline member

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. If this doesn't break clang and gcc, fine. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67856/new/ https://reviews.llvm.org/D67856 __

[Lldb-commits] [lldb] r372424 - [lldb] Process formatters in reverse-chronological order

Author: jankratochvil Date: Fri Sep 20 13:19:18 2019 New Revision: 372424 URL: http://llvm.org/viewvc/llvm-project?rev=372424&view=rev Log: [lldb] Process formatters in reverse-chronological order If one reverts D66398 then the TestDataFormatterStdList does fail - as the C++ formatters are initia

[Lldb-commits] [PATCH] D67856: [LLDB] Fix compilation for MinGW, remove redundant class name on inline member

mstorsjo created this revision. mstorsjo added reviewers: asmith, labath, hhb. Herald added a subscriber: JDevlieghere. Herald added a project: LLDB. This fixes build errors like these: NativeRegisterContextWindows.h:22:33: error: extra qualification on member 'NativeRegisterContextWindows'

[Lldb-commits] [PATCH] D65942: Disallow implicit conversion from pointers to bool in llvm::toStringRef

dblaikie added inline comments. Comment at: lldb/source/Symbol/TypeSystem.cpp:331 "TypeSystem for language " + - llvm::toStringRef(Language::GetNameForLanguageType(language)) + + llvm::StringRef(Language::GetNameForLanguageType(language)) +

[Lldb-commits] [PATCH] D67760: [lldb] Decouple importing the std C++ module from the way the program is compiled

aprantl added inline comments. Comment at: lldb/include/lldb/Symbol/CompileUnit.h:228 + /// Apply a lambda to each external module referenced by this compilation + /// unit. Recursively also descends into the referenced external modules What does "external mo

[Lldb-commits] [PATCH] D67792: File::SetDescriptor() should require options

lawrence_danna updated this revision to Diff 221093. lawrence_danna edited the summary of this revision. lawrence_danna added a comment. removed SetOptions() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67792/new/ https://reviews.llvm.org/D67792

[Lldb-commits] [PATCH] D67789: bugfix: File::GetWaitableHandle() should call fileno()

lawrence_danna updated this revision to Diff 221082. lawrence_danna added a comment. Herald added a subscriber: mgorny. added a unit test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67789/new/ https://reviews.llvm.org/D67789 Files: lldb/source

[Lldb-commits] [PATCH] D67776: Use UnixSignals::ShouldSuppress to filter out signals a process expects

jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. This is all about the decision in "batch" mode for what constitutes a stop by the program that should cause batch mode to return the control to the user. I don't think anybody woul

[Lldb-commits] [PATCH] D67776: Use UnixSignals::ShouldSuppress to filter out signals a process expects

JDevlieghere added inline comments. Comment at: packages/Python/lldbsuite/test/driver/batch_mode/TestBatchMode.py:83 +def test_batch_mode_launch_stop_at_entry(self): +"""Test that the lldb driver's batch mode works correctly.""" +self.build()

[Lldb-commits] [PATCH] D67583: Fix swig python package path

hhb added a comment. In D67583#1676531 , @labath wrote: > I could be off mark here, but I do recall some people trying to get this code > to work in environments where python and lldb(llvm) are configured with > different libdirs (so LLVM_LIBDIR_SUFFIX i

[Lldb-commits] [PATCH] D67583: Fix swig python package path

hhb added a comment. In D67583#1675889 , @ZeGentzy wrote: > In D67583#1675714 , @hhb wrote: > > > My theory now is that your python has a different implementation of > > get_python_lib(). After all we should not gu

[Lldb-commits] [PATCH] D67774: [Mangle] Add flag to asm labels to disable global prefixing

vsk updated this revision to Diff 221066. vsk retitled this revision from "[Mangle] Check ExternalASTSource before adding prefix to asm label names" to "[Mangle] Add flag to asm labels to disable global prefixing". vsk edited the summary of this revision. vsk added a comment. Thanks for your fee

[Lldb-commits] [PATCH] D67792: File::SetDescriptor() should require options

JDevlieghere accepted this revision. JDevlieghere added a comment. Do we still need `SetOptions` after this? Are there cases where the value needs to change after construction? If not I would consider removing that function. Otherwise this LGTM if Pavel doesn't have any other concerns. Reposit

[Lldb-commits] [PATCH] D67760: [lldb] Decouple importing the std C++ module from the way the program is compiled

teemperor added a comment. This patch is *only* for getting the `std` module working on as many projects as possible. The initial plan about using -gmodules and then looking at the imported modules as expressed in DWARF is still what we will do for modules in general (and it will then have prec

[Lldb-commits] [PATCH] D67776: Use UnixSignals::ShouldSuppress to filter out signals a process expects

tatyana-krasnukha added inline comments. Comment at: source/Interpreter/CommandInterpreter.cpp:2164 +StopReason reason = stop_info->GetStopReason(); +if (eStopReasonException == reason || eStopReasonInstrumentation == reason) + return true; JDevliegh

[Lldb-commits] [PATCH] D67776: Use UnixSignals::ShouldSuppress to filter out signals a process expects

tatyana-krasnukha updated this revision to Diff 221058. tatyana-krasnukha added a comment. Added a test Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67776/new/ https://reviews.llvm.org/D67776 Files: include/lldb/Interpreter/CommandInterpreter.h include/ll

[Lldb-commits] [lldb] r372411 - Doxygenify comments.

Author: adrian Date: Fri Sep 20 10:15:57 2019 New Revision: 372411 URL: http://llvm.org/viewvc/llvm-project?rev=372411&view=rev Log: Doxygenify comments. Modified: lldb/trunk/include/lldb/Symbol/Variable.h lldb/trunk/source/Symbol/Variable.cpp Modified: lldb/trunk/include/lldb/Symbol/Var

[Lldb-commits] [PATCH] D67791: dotest.py: bugfix: test filters with -f do not work on Python3

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. I would prefer to update the unittest2 dependency instead, but I tried doing so and it appears to be less straightforward than I'd hoped. I have added it to my todo-list, but this

[Lldb-commits] [PATCH] D67792: bugfix: llvm_private::File::GetStream() can fail if m_options == 0

lawrence_danna updated this revision to Diff 221047. lawrence_danna added a comment. Added options to SetDescriptor instead of using ::fcntl Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67792/new/ https://reviews.llvm.org/D67792 Files: lldb/inc

[Lldb-commits] [PATCH] D67776: Use UnixSignals::ShouldSuppress to filter out signals a process expects

JDevlieghere added a comment. +1 on a test case. Other than that this seems like a good improvement to the way we filter stop reasons. Comment at: source/Interpreter/CommandInterpreter.cpp:2164 +StopReason reason = stop_info->GetStopReason(); +if (eStopReasonException

[Lldb-commits] [PATCH] D67760: [lldb] Decouple importing the std C++ module from the way the program is compiled

aprantl added a comment. I understand the motivation, just a few questions about the approach: - Can we make it such that *if* the program was compiled with -gmodules LLDB is using the DWARF module info as authoritative source instead of using this heuristic? - Is there a path towards supportin

[Lldb-commits] [PATCH] D67793: new api class: SBFile

lawrence_danna added a comment. In D67793#1676592 , @labath wrote: > The api seems reasonably straight-forward. The one thing that struck me is > that you're using unique_ptrs for the pimpled objects. That would mean the > SBFile objects are non-copyable

[Lldb-commits] [PATCH] D67792: bugfix: llvm_private::File::GetStream() can fail if m_options == 0

lawrence_danna added a comment. In D67792#1676556 , @labath wrote: > It doesn't look like this will work on windows (I find no trace of fcntl in > the windows docs). Even if we find a way to guess the open mode on windows > somehow, I am not convinced th

[Lldb-commits] [PATCH] D67776: Use UnixSignals::ShouldSuppress to filter out signals a process expects

tatyana-krasnukha added a comment. The flag m_abnormal_stop_was_expected was added in the commit to avoid stop on crash because attach always stops with a SIGSTOP on OSX. I faced the same issue with SIGTRAP and SIGSTOP sent by a gdb-remote stub on some com

[Lldb-commits] [PATCH] D67831: [lldb] Get the TargetAPI lock in SBProcess::IsInstrumentationRuntimePresen

teemperor created this revision. teemperor added a reviewer: jingham. Herald added subscribers: lldb-commits, JDevlieghere. Herald added a project: LLDB. We should get the TargetAPI lock here to prevent the process of being destroyed while we are in the function. Thanks Jim for explaining what's

[Lldb-commits] [PATCH] D67803: [lldb] Fix that importing decls in a TagDecl end up in wrong declaration context (partly reverts D61333)

martong added a comment. BTW, I tried to access the bug reports rdar://55502701 and rdar://55129537, but could not. I tried at openradar, but there the search for the ID was not successful. I wonder if there is a publicly accessible (for non Apple employees) URL for these bugs? Repository: r

[Lldb-commits] [PATCH] D67793: new api class: SBFile

labath added a comment. This is an interesting undertaking. There's a lot of confusion about FILE* in lldb, and it would be great to clean some of that stuff up. The api seems reasonably straight-forward. The one thing that struck me is that you're using unique_ptrs for the pimpled objects. Tha

[Lldb-commits] [PATCH] D67803: [lldb] Fix that importing decls in a TagDecl end up in wrong declaration context (partly reverts D61333)

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Thanks for the thorough explanation about the different ASTContexts in LLDB. The hack is indeed hideous, but seems good to me... for now until the real solution is born. > So we go to D-AST

[Lldb-commits] [PATCH] D61478: Move decl completion out of the ASTImporterDelegate and document it [NFC]

This revision was automatically updated to reflect the committed changes. Closed by commit rL372385: Move decl completion out of the ASTImporterDelegate and document it [NFC] (authored by teemperor, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed pri

[Lldb-commits] [lldb] r372385 - Move decl completion out of the ASTImporterDelegate and document it [NFC]

Author: teemperor Date: Fri Sep 20 05:52:55 2019 New Revision: 372385 URL: http://llvm.org/viewvc/llvm-project?rev=372385&view=rev Log: Move decl completion out of the ASTImporterDelegate and document it [NFC] Summary: The ASTImporterDelegate is currently responsible for both recording and also

[Lldb-commits] [PATCH] D67792: bugfix: llvm_private::File::GetStream() can fail if m_options == 0

labath requested changes to this revision. labath added a comment. This revision now requires changes to proceed. It doesn't look like this will work on windows (I find no trace of fcntl in the windows docs). Even if we find a way to guess the open mode on windows somehow, I am not convinced tha

[Lldb-commits] [PATCH] D61478: Move decl completion out of the ASTImporterDelegate and document it [NFC]

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Looks good to me, thanks! Comment at: lldb/source/Symbol/ClangASTImporter.cpp:324 + +NamedDecl *to_named_decl = dyn_cast(to); +// Check if we already deported this

[Lldb-commits] [PATCH] D67789: bugfix: File::GetWaitableHandle() should call fileno()

labath added a comment. Thanks for the fix. This sounds like it should be unit testable. Could add a test for that? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67789/new/ https://reviews.llvm.org/D67789 ___

[Lldb-commits] [PATCH] D67583: Fix swig python package path

labath added a comment. I could be off mark here, but I do recall some people trying to get this code to work in environments where python and lldb(llvm) are configured with different libdirs (so LLVM_LIBDIR_SUFFIX in llvm, and `configure --prefix=X` in python). Is that the case you're running

[Lldb-commits] [PATCH] D67776: Use UnixSignals::ShouldSuppress to filter out signals a process expects

labath added a comment. What behavior does this change exactly? This is not immediately obvious to me, and probably anyone else not intimately familiar with the stop reason machinery (= everyone except Jim, probably). Could you add a test case for this (which I am hoping will also shed some lig

[Lldb-commits] [PATCH] D67589: Fix crash on SBCommandReturnObject & assignment

labath added a comment. In D67589#1674640 , @jankratochvil wrote: > Maybe http://lldb.llvm.org/resources/sbapi.html could say that and it would > be much more clear. That's probably a good idea, though I would still keep the list of restrictions spell

[Lldb-commits] [lldb] r372381 - [lldb][NFC] Remove unused include in TestLineEntry.cpp

Author: teemperor Date: Fri Sep 20 03:30:38 2019 New Revision: 372381 URL: http://llvm.org/viewvc/llvm-project?rev=372381&view=rev Log: [lldb][NFC] Remove unused include in TestLineEntry.cpp Modified: lldb/trunk/unittests/Symbol/TestLineEntry.cpp Modified: lldb/trunk/unittests/Symbol/TestLin

[Lldb-commits] [PATCH] D61565: Ignore generated @import statements in the expression evaluator

teemperor added a comment. - Rebased and some minor refactoring to prevent having multiple places with the duplicated wrapper file name. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61565/new/ https://reviews.llvm.org/D61565 ___ lldb-comm

[Lldb-commits] [PATCH] D61565: Ignore generated @import statements in the expression evaluator

teemperor updated this revision to Diff 220987. teemperor marked an inline comment as done. teemperor edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61565/new/ https://reviews.llvm.org/D61565 Files: lldb/source/Plugins/ExpressionParser/Clang/ClangExp

[Lldb-commits] [PATCH] D65942: Disallow implicit conversion from pointers to bool in llvm::toStringRef

teemperor marked 3 inline comments as done. teemperor added inline comments. Comment at: lldb/source/Symbol/TypeSystem.cpp:331 "TypeSystem for language " + - llvm::toStringRef(Language::GetNameForLanguageType(language)) + + llvm::StringRef(Lan

[Lldb-commits] [PATCH] D65942: Disallow implicit conversion from pointers to bool in llvm::toStringRef

teemperor updated this revision to Diff 220983. teemperor marked an inline comment as done. teemperor added a comment. - Add GetNameForLanguageTypeAsRef to save some typing. - Add comment for why we use enable_if. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65942/new/ https://reviews.

[Lldb-commits] [PATCH] D61478: Move decl completion out of the ASTImporterDelegate and document it [NFC]

teemperor added inline comments. Comment at: lldb/source/Symbol/ClangASTImporter.cpp:250 +/// imported while completing the original Decls). +class DeportQueueScope : public ClangASTImporter::NewDeclListener { + ClangASTImporter::ImporterDelegateSP m_delegate; m

[Lldb-commits] [PATCH] D61478: Move decl completion out of the ASTImporterDelegate and document it [NFC]

teemperor updated this revision to Diff 220965. teemperor marked 4 inline comments as done. teemperor added a comment. - Renamed class and related variables to reflect that it is completing TagDecls. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61478/new/ https://reviews.llvm.org/D6147

[Lldb-commits] [PATCH] D67803: [lldb] Fix that importing decls in a TagDecl end up in wrong declaration context (partly reverts D61333)

teemperor added a comment. I plan to match this soon-ish as this is essentially just a revert. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67803/new/ https://reviews.llvm.org/D67803 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D67803: [lldb] Fix that importing decls in a TagDecl end up in wrong declaration context (partly reverts D61333)

teemperor created this revision. teemperor added reviewers: friss, martong. Herald added subscribers: lldb-commits, JDevlieghere, abidh, christof, rnkovacs, aprantl. Herald added a project: LLDB. In D61333 we dropped some code from ClangASTSource that checks if