tatyana-krasnukha added inline comments.

================
Comment at: source/Interpreter/CommandInterpreter.cpp:2164
+    StopReason reason = stop_info->GetStopReason();
+    if (eStopReasonException == reason || eStopReasonInstrumentation == reason)
+      return true;
----------------
JDevlieghere wrote:
> I'm curious why you swapped the two operands. Is there a benefit in 
> `eStopReasonException == reason` compared to `reason == 
> eStopReasonException`? 
This technique prevents unintended assignment instead of comparison since 
left-hand value is constant. 


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67776/new/

https://reviews.llvm.org/D67776



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to