JDevlieghere added inline comments.
================ Comment at: packages/Python/lldbsuite/test/driver/batch_mode/TestBatchMode.py:83 + def test_batch_mode_launch_stop_at_entry(self): + """Test that the lldb driver's batch mode works correctly.""" + self.build() ---------------- Update the comment? ================ Comment at: source/Interpreter/CommandInterpreter.cpp:2164 + StopReason reason = stop_info->GetStopReason(); + if (eStopReasonException == reason || eStopReasonInstrumentation == reason) + return true; ---------------- tatyana-krasnukha wrote: > JDevlieghere wrote: > > I'm curious why you swapped the two operands. Is there a benefit in > > `eStopReasonException == reason` compared to `reason == > > eStopReasonException`? > This technique prevents unintended assignment instead of comparison since > left-hand value is constant. Ah, because the `StopReason` is not const. Fair enough, thanks for the explanation. I don't think I've seen that in other parts of LLDB but I'm not opposed to it. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67776/new/ https://reviews.llvm.org/D67776 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
