[Lldb-commits] [PATCH] D66966: [test] Fix various module cache bugs and inconsistencies

labath added inline comments. Herald added a subscriber: ormris. Comment at: lldb/trunk/lit/Settings/TestModuleCacheSanity.test:1-4 +# This is a sanity check that verifies that the module cache path is set +# correctly and points inside the default test build directory. +RUN: %ll

[Lldb-commits] [PATCH] D66934: [ARM64] Simplify RegisterInfos_arm64.h with macro based RegisterInfo array

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks fine to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66934/new/ https://reviews.llvm.org/D66934 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D66934: [ARM64] Simplify RegisterInfos_arm64.h with macro based RegisterInfo array

jasonmolenda added a comment. LGTM. In debugserver we have the definition for the V registers invaliding the D and S registers it contains. If the user modifies v10, we want any cached s10 and d10 values to be marked as invalid / refresh them. The same thing with the X and W registers. But

[Lldb-commits] [PATCH] D66975: [lit] Print exit code in for unresolved (lldb)tests.

This revision was automatically updated to reflect the committed changes. Closed by commit rL370413: [lit] Print exit code in for unresolved (lldb)tests. (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: ht

[Lldb-commits] [PATCH] D66975: [lit] Print exit code in for unresolved (lldb)tests.

JDevlieghere added a comment. In D66975#1651757 , @aprantl wrote: > If it helps... > Is there anything else we can print for a crashed dotest? Is there anything else other than stdout, stderr and the exit code? Repository: rLLDB LLDB CHANGES SINCE

[Lldb-commits] [lldb] r370413 - [lit] Print exit code in for unresolved (lldb)tests.

Author: jdevlieghere Date: Thu Aug 29 15:02:28 2019 New Revision: 370413 URL: http://llvm.org/viewvc/llvm-project?rev=370413&view=rev Log: [lit] Print exit code in for unresolved (lldb)tests. A test is marked unresolved when we're unable to find PASSED or FAILED in the dotest output. Usually this

[Lldb-commits] [PATCH] D66975: [lit] Print exit code in for unresolved (lldb)tests.

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. If it helps... Is there anything else we can print for a crashed dotest? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66975/new/ https://reviews.llvm.org/

[Lldb-commits] [PATCH] D66975: [lit] Print exit code in for unresolved (lldb)tests.

JDevlieghere created this revision. JDevlieghere added reviewers: friss, aprantl. Herald added a project: LLDB. A test is marked unresolved when we're unable to find PASSED or FAILED in the dotest output. Usually this is because we crashed and when that happens the exit code can give a clue as to

[Lldb-commits] [lldb] r370395 - [lldb][NFC] Document options parameter in ClangUserExpression constructor

Author: teemperor Date: Thu Aug 29 11:53:20 2019 New Revision: 370395 URL: http://llvm.org/viewvc/llvm-project?rev=370395&view=rev Log: [lldb][NFC] Document options parameter in ClangUserExpression constructor Somehow this option was only documented in the swift branch. Modified: lldb/trunk/

[Lldb-commits] [PATCH] D66966: [test] Fix various module cache bugs and inconsistencies

This revision was automatically updated to reflect the committed changes. Closed by commit rL370394: [test] Fix various module cache bugs and inconsistencies (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D66966: [test] Fix various module cache bugs and inconsistencies

JDevlieghere updated this revision to Diff 217948. JDevlieghere added a comment. - Fix a few inconsistencies. - Address Adrian's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66966/new/ https://reviews.llvm.org/D66966 Files: lldb/CMakeLists.txt lldb/lit/CMakeLists.txt l

[Lldb-commits] [lldb] r370394 - [test] Fix various module cache bugs and inconsistencies

Author: jdevlieghere Date: Thu Aug 29 11:37:05 2019 New Revision: 370394 URL: http://llvm.org/viewvc/llvm-project?rev=370394&view=rev Log: [test] Fix various module cache bugs and inconsistencies Currently, lit tests don't set neither the module cache for building inferiors nor the module cache u

[Lldb-commits] [PATCH] D66966: [test] Fix various module cache bugs and inconsistencies

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Thanks, this looks great (few comments inside). Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66966/new/ https://reviews.llvm.org/D66966 ___

[Lldb-commits] [PATCH] D66966: [test] Fix various module cache bugs and inconsistencies

aprantl added inline comments. Comment at: lldb/lit/CMakeLists.txt:18 +set(LLDB_TEST_MODULE_CACHE_LLDB "${LLDB_TEST_BUILD_DIRECTORY}/module-cache-lldb" CACHE PATH "The module cache used by lldb for running tests.") +set(LLDB_TEST_MODULE_CACHE_CLANG "${LLDB_TEST_BUILD_DIRECTO

[Lldb-commits] [PATCH] D66966: [test] Fix various module cache bugs and inconsistencies

JDevlieghere created this revision. JDevlieghere added reviewers: aprantl, davide, friss. Herald added subscribers: teemperor, abidh, mgorny. Herald added a project: LLDB. Currently, lit tests don't set neither the module cache for building inferiors nor the module cache used by lldb when running

[Lldb-commits] [PATCH] D66962: [lldb][NFC] Remove TestFormats.py as is tests nothing

jingham added a comment. That was the only test that tested the "command regex" functionality. It was probably called TestFormats.py because somebody copied over a test without changing the file name since that name makes no sense. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https:/

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 217933. kwk added a comment. - Cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66791/new/ https://reviews.llvm.org/D66791 Files: lldb/include/lldb/Host/LZMA.h lldb/packages/Python/lldbsuite/test/linux/mi

[Lldb-commits] [PATCH] D66954: dotest: improvements to the pexpect tests

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM. And it seems like you found TestFormats.py at the same time as me and ninja'd D66962 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66954/

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk added a comment. Currently the test `lldb/packages/Python/lldbsuite/test/linux/minidebuginfo/TestMiniDebugInfo.py` fails if `LLVM_ENABLE_LZMA` is not defined because the test stupidly assumes that support for minidebuginfo is available. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D66962: [lldb][NFC] Remove TestFormats.py as is tests nothing

teemperor added a comment. @jingham In D66954 , Pavel digs into the history of the test a bit. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66962/new/ https://reviews.llvm.org/D66962 ___

[Lldb-commits] [PATCH] D66962: [lldb][NFC] Remove TestFormats.py as is tests nothing

jingham added a comment. Does anybody know what this was supposed to test? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66962/new/ https://reviews.llvm.org/D66962 ___ lldb-commits mailing list lldb-commits@lists.l

[Lldb-commits] [PATCH] D66920: [dotest] Remove deprecated loggin through env variables.

This revision was automatically updated to reflect the committed changes. Closed by commit rL370387: [dotest] Remove deprecated loggin through env variables. (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D66962: [lldb][NFC] Remove TestFormats.py as is tests nothing

teemperor abandoned this revision. teemperor added a comment. D66954 ninja'd this patch :( Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66962/new/ https://reviews.llvm.org/D66962

[Lldb-commits] [PATCH] D66917: [dotest] Remove the curses result formatter.

This revision was automatically updated to reflect the committed changes. Closed by commit rL370386: [dotest] Remove the curses result formatter. (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://re

[Lldb-commits] [lldb] r370386 - [dotest] Remove the curses result formatter.

Author: jdevlieghere Date: Thu Aug 29 10:18:57 2019 New Revision: 370386 URL: http://llvm.org/viewvc/llvm-project?rev=370386&view=rev Log: [dotest] Remove the curses result formatter. This removes the curses result formatter which appears to be broken. Passing --curses to dotest.py screws up my t

[Lldb-commits] [lldb] r370387 - [dotest] Remove deprecated loggin through env variables.

Author: jdevlieghere Date: Thu Aug 29 10:19:00 2019 New Revision: 370387 URL: http://llvm.org/viewvc/llvm-project?rev=370387&view=rev Log: [dotest] Remove deprecated loggin through env variables. It used to be possible to enable logging through environment variables read by dotest. This approach

[Lldb-commits] [PATCH] D66962: [lldb][NFC] Remove TestFormats.py as is tests nothing

teemperor created this revision. teemperor added a reviewer: LLDB. Herald added subscribers: lldb-commits, JDevlieghere. Herald added a project: LLDB. This test tests nothing as it just creates a target and runs to main. It's also using pexpect and its documentation and name don't fit its content

[Lldb-commits] [lldb] r370385 - Revert "[TSanRuntime] Upstream thread swift race detector."

Author: davide Date: Thu Aug 29 10:14:25 2019 New Revision: 370385 URL: http://llvm.org/viewvc/llvm-project?rev=370385&view=rev Log: Revert "[TSanRuntime] Upstream thread swift race detector." Sometimes it's easier to resolve merge conflict than arguing. Modified: lldb/trunk/source/Plugins/I

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 217924. kwk marked an inline comment as done. kwk added a comment. - Fix header comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66791/new/ https://reviews.llvm.org/D66791 Files: lldb/include/lldb/Host/LZMA

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk added inline comments. Comment at: lldb/source/Plugins/SymbolVendor/ELF/SymbolVendorELF.cpp:79 + // If there's none in the orignal object file, we add it to it. + if (auto gdd_obj_file = + obj_file->GetGnuDebugDataObjectFile()) { labath wrote: > Wo

[Lldb-commits] [PATCH] D66954: dotest: improvements to the pexpect tests

labath created this revision. labath added reviewers: teemperor, JDevlieghere, davide. Herald added a subscriber: aprantl. While working on r370054, i've found it frustrating that the test output was compeletely unhelpful in case of failures. Therefore I've decided to improve that. In this I reuse

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 217895. kwk added a comment. - fixed lzma functions when LLVM_ENABLE_LZMA is not enabled Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66791/new/ https://reviews.llvm.org/D66791 Files: lldb/include/lldb/Host/LZM

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 217894. kwk marked 4 inline comments as done. kwk added a comment. - Apply review comments - Move LZMA logic to lldb/Host/LZMA.h as suggested by labath - Simplify LZMA function signatures - Remove LZMA_OK from switch - Add llvm-nm to the list of lldb test dependen

[Lldb-commits] [PATCH] D66357: Fix GetDIEForDeclContext so it only returns entries matching the provided context

This revision was automatically updated to reflect the committed changes. Closed by commit rL370374: Fix GetDIEForDeclContext so it only returns entries matching the provided… (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[Lldb-commits] [lldb] r370374 - Fix GetDIEForDeclContext so it only returns entries matching the provided context

Author: labath Date: Thu Aug 29 08:30:52 2019 New Revision: 370374 URL: http://llvm.org/viewvc/llvm-project?rev=370374&view=rev Log: Fix GetDIEForDeclContext so it only returns entries matching the provided context Currently, we return all the entries such that their decl_ctx pointer >= decl_ct

[Lldb-commits] [PATCH] D66789: Remove DWARFExpression::LocationListSize

This revision was automatically updated to reflect the committed changes. Closed by commit rL370373: Remove DWARFExpression::LocationListSize (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTIO

[Lldb-commits] [lldb] r370373 - Remove DWARFExpression::LocationListSize

Author: labath Date: Thu Aug 29 08:21:26 2019 New Revision: 370373 URL: http://llvm.org/viewvc/llvm-project?rev=370373&view=rev Log: Remove DWARFExpression::LocationListSize Summary: The only reason for this function's existance is so that we could pass the correct size into the DWARFExpression c

[Lldb-commits] [PATCH] D63591: DWARFDebugLoc: Make parsing and error reporting more robust

This revision was automatically updated to reflect the committed changes. Closed by commit rL370363: DWARFDebugLoc: Make parsing and error reporting more robust (authored by labath, committed by ). Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63591/new/ https://re

[Lldb-commits] [PATCH] D66634: Postfix: move more code out of the PDB plugin

labath added a comment. In D66634#1648119 , @amccarth wrote: > When I added my comments, Phabricator showed this patch as still open. Now > it looks like it landed four hours before that. :-( Yeah, :(, but that doesn't mean I can't address any comments

[Lldb-commits] [PATCH] D66920: [dotest] Remove deprecated loggin through env variables.

labath accepted this revision. labath added a comment. Looks good. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66920/new/ https://reviews.llvm.org/D66920 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D66915: [TSanRuntime] Upstream thread swift race detector.

labath added a comment. Patch by Kuba Mracek! Somehow, I don't think this patch would be so "self-contained" if we were following llvm developer policy . I also doubt you would be so en

[Lldb-commits] [PATCH] D66934: [ARM64] Simplify RegisterInfos_arm64.h with macro based RegisterInfo array

omjavaid created this revision. omjavaid added reviewers: labath, jasonmolenda. Herald added subscribers: kristof.beyls, javed.absar. Herald added a reviewer: rengolin. This patches paves way for upcoming SVE RegisterInfo definitions. This is cosmetic change which allows us to define ARM64 Regist

[Lldb-commits] [lldb] r370316 - [lldb][NFC] Try fixing TestCompletion.py on Windows

Author: teemperor Date: Thu Aug 29 02:57:02 2019 New Revision: 370316 URL: http://llvm.org/viewvc/llvm-project?rev=370316&view=rev Log: [lldb][NFC] Try fixing TestCompletion.py on Windows Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/completion/TestCompletion.py Modifi

[Lldb-commits] [lldb] r370315 - [lldb][NFC] Also test operator new/new[]/delete/delete[]/comma/addr-of

Author: teemperor Date: Thu Aug 29 02:39:33 2019 New Revision: 370315 URL: http://llvm.org/viewvc/llvm-project?rev=370315&view=rev Log: [lldb][NFC] Also test operator new/new[]/delete/delete[]/comma/addr-of Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/operators/main.cpp Modif

[Lldb-commits] [lldb] r370302 - fix the bugzilla url

Author: sylvestre Date: Thu Aug 29 00:19:14 2019 New Revision: 370302 URL: http://llvm.org/viewvc/llvm-project?rev=370302&view=rev Log: fix the bugzilla url Modified: lldb/trunk/docs/lldb.1 Modified: lldb/trunk/docs/lldb.1 URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/docs/lldb.1?rev=

[Lldb-commits] [lldb] r370303 - use https for llvm.org in the doc

Author: sylvestre Date: Thu Aug 29 00:20:08 2019 New Revision: 370303 URL: http://llvm.org/viewvc/llvm-project?rev=370303&view=rev Log: use https for llvm.org in the doc Modified: lldb/trunk/docs/index.rst lldb/trunk/docs/resources/build.rst lldb/trunk/docs/resources/source.rst Modif

[Lldb-commits] [lldb] r370301 - Provide a real link to the doc and remove old information

Author: sylvestre Date: Thu Aug 29 00:14:09 2019 New Revision: 370301 URL: http://llvm.org/viewvc/llvm-project?rev=370301&view=rev Log: Provide a real link to the doc and remove old information Modified: lldb/trunk/docs/resources/download.rst Modified: lldb/trunk/docs/resources/download.rst