JDevlieghere created this revision.
JDevlieghere added reviewers: friss, aprantl.
Herald added a project: LLDB.

A test is marked unresolved when we're unable to find PASSED or FAILED
in the dotest output. Usually this is because we crashed and when that
happens the exit code can give a clue as to why. This patch adds the
exit code to the lit output to make it easier to investigate those
issues.


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D66975

Files:
  lldb/lit/Suite/lldbtest.py


Index: lldb/lit/Suite/lldbtest.py
===================================================================
--- lldb/lit/Suite/lldbtest.py
+++ lldb/lit/Suite/lldbtest.py
@@ -104,8 +104,8 @@
 
         passing_test_line = 'RESULT: PASSED'
         if passing_test_line not in out and passing_test_line not in err:
-            msg = ('Unable to find %r in dotest output:\n\n%s%s' %
-                   (passing_test_line, out, err))
+            msg = ('Unable to find %r in dotest output (exit code %d):\n\n%s%s'
+                   % (passing_test_line, exitCode, out, err))
             return lit.Test.UNRESOLVED, msg
 
         return lit.Test.PASS, ''


Index: lldb/lit/Suite/lldbtest.py
===================================================================
--- lldb/lit/Suite/lldbtest.py
+++ lldb/lit/Suite/lldbtest.py
@@ -104,8 +104,8 @@
 
         passing_test_line = 'RESULT: PASSED'
         if passing_test_line not in out and passing_test_line not in err:
-            msg = ('Unable to find %r in dotest output:\n\n%s%s' %
-                   (passing_test_line, out, err))
+            msg = ('Unable to find %r in dotest output (exit code %d):\n\n%s%s'
+                   % (passing_test_line, exitCode, out, err))
             return lit.Test.UNRESOLVED, msg
 
         return lit.Test.PASS, ''
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to