teemperor created this revision. teemperor added a reviewer: LLDB. Herald added subscribers: lldb-commits, JDevlieghere. Herald added a project: LLDB.
This test tests nothing as it just creates a target and runs to main. It's also using pexpect and its documentation and name don't fit its content. Repository: rLLDB LLDB https://reviews.llvm.org/D66962 Files: lldb/packages/Python/lldbsuite/test/functionalities/format/Makefile lldb/packages/Python/lldbsuite/test/functionalities/format/TestFormats.py lldb/packages/Python/lldbsuite/test/functionalities/format/main.c Index: lldb/packages/Python/lldbsuite/test/functionalities/format/main.c =================================================================== --- lldb/packages/Python/lldbsuite/test/functionalities/format/main.c +++ /dev/null @@ -1,14 +0,0 @@ -//===-- main.c --------------------------------------------------*- C++ -*-===// -// -// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. -// See https://llvm.org/LICENSE.txt for license information. -// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception -// -//===----------------------------------------------------------------------===// - -#include <stdio.h> -int main (int argc, char const *argv[]) -{ - printf("testing\n"); - return 0; -} Index: lldb/packages/Python/lldbsuite/test/functionalities/format/TestFormats.py =================================================================== --- lldb/packages/Python/lldbsuite/test/functionalities/format/TestFormats.py +++ /dev/null @@ -1,38 +0,0 @@ -""" -Test the command history mechanism -""" - -from __future__ import print_function - - -import lldb -from lldbsuite.test.decorators import * -from lldbsuite.test.lldbtest import * -from lldbsuite.test import lldbutil - - -class TestFormats(TestBase): - - mydir = TestBase.compute_mydir(__file__) - - @expectedFailureAll( - hostoslist=["windows"], - bugnumber="llvm.org/pr22274: need a pexpect replacement for windows") - def test_formats(self): - """Test format string functionality.""" - self.build() - exe = self.getBuildArtifact("a.out") - import pexpect - prompt = "(lldb) " - child = pexpect.spawn( - '%s %s -x -o "b main" -o r %s' % - (lldbtest_config.lldbExec, self.lldbOption, exe)) - # So that the spawned lldb session gets shutdown durng teardown. - self.child = child - - # Substitute 'Help!' for 'help' using the 'commands regex' mechanism. - child.expect_exact(prompt + 'target create "%s"' % exe) - child.expect_exact(prompt + 'b main') - child.expect_exact(prompt + 'r') - child.expect_exact(prompt) - child.sendline() Index: lldb/packages/Python/lldbsuite/test/functionalities/format/Makefile =================================================================== --- lldb/packages/Python/lldbsuite/test/functionalities/format/Makefile +++ /dev/null @@ -1,5 +0,0 @@ -LEVEL = ../../make - -C_SOURCES := main.c - -include $(LEVEL)/Makefile.rules
Index: lldb/packages/Python/lldbsuite/test/functionalities/format/main.c =================================================================== --- lldb/packages/Python/lldbsuite/test/functionalities/format/main.c +++ /dev/null @@ -1,14 +0,0 @@ -//===-- main.c --------------------------------------------------*- C++ -*-===// -// -// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. -// See https://llvm.org/LICENSE.txt for license information. -// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception -// -//===----------------------------------------------------------------------===// - -#include <stdio.h> -int main (int argc, char const *argv[]) -{ - printf("testing\n"); - return 0; -} Index: lldb/packages/Python/lldbsuite/test/functionalities/format/TestFormats.py =================================================================== --- lldb/packages/Python/lldbsuite/test/functionalities/format/TestFormats.py +++ /dev/null @@ -1,38 +0,0 @@ -""" -Test the command history mechanism -""" - -from __future__ import print_function - - -import lldb -from lldbsuite.test.decorators import * -from lldbsuite.test.lldbtest import * -from lldbsuite.test import lldbutil - - -class TestFormats(TestBase): - - mydir = TestBase.compute_mydir(__file__) - - @expectedFailureAll( - hostoslist=["windows"], - bugnumber="llvm.org/pr22274: need a pexpect replacement for windows") - def test_formats(self): - """Test format string functionality.""" - self.build() - exe = self.getBuildArtifact("a.out") - import pexpect - prompt = "(lldb) " - child = pexpect.spawn( - '%s %s -x -o "b main" -o r %s' % - (lldbtest_config.lldbExec, self.lldbOption, exe)) - # So that the spawned lldb session gets shutdown durng teardown. - self.child = child - - # Substitute 'Help!' for 'help' using the 'commands regex' mechanism. - child.expect_exact(prompt + 'target create "%s"' % exe) - child.expect_exact(prompt + 'b main') - child.expect_exact(prompt + 'r') - child.expect_exact(prompt) - child.sendline() Index: lldb/packages/Python/lldbsuite/test/functionalities/format/Makefile =================================================================== --- lldb/packages/Python/lldbsuite/test/functionalities/format/Makefile +++ /dev/null @@ -1,5 +0,0 @@ -LEVEL = ../../make - -C_SOURCES := main.c - -include $(LEVEL)/Makefile.rules
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
