[Lldb-commits] [PATCH] D64647: [lldb] [Process/NetBSD] Implement per-thread execution control

labath added a comment. In D64647#1609600 , @mgorny wrote: > It seems that the patch is wrong with the current logic, and this is somehow > blurry because of Linux implementation limitations. FWIU, `eStateSuspended` > will never happen and instead we sho

[Lldb-commits] [PATCH] D65555: [lldb] [Process/NetBSD] Enable reporting of new and exited threads [WIP]

labath added a comment. Looks fine to me. Minor comments inline. Comment at: lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp:271 +} +SetState(StateType::eStateRunning, true); + } break; I don't think you need this. Given that you never repor

Re: [Lldb-commits] [lldb] r367441 - Don't crash when pass by value struct has no definition.

On 01/08/2019 00:14, Jim Ingham via lldb-commits wrote: On Jul 31, 2019, at 12:50 PM, via lldb-commits wrote: -Original Message- From: lldb-commits [mailto:lldb-commits-boun...@lists.llvm.org] On Behalf Of Greg Clayton via lldb-commits Sent: Wednesday, July 31, 2019 2:29 PM To: R

[Lldb-commits] [PATCH] D65555: [lldb] [Process/NetBSD] Enable reporting of new and exited threads [WIP]

mgorny created this revision. mgorny added reviewers: labath, krytarowski. Herald added a reviewer: jfb. mgorny added a parent revision: D64647: [lldb] [Process/NetBSD] Implement per-thread execution control. Herald added a subscriber: dexonsmith. // NB: Now, this patch is most likely correct. Ho

[Lldb-commits] [PATCH] D64647: [lldb] [Process/NetBSD] Implement per-thread execution control

mgorny planned changes to this revision. mgorny added a comment. It seems that the patch is wrong with the current logic, and this is somehow blurry because of Linux implementation limitations. FWIU, `eStateSuspended` will never happen and instead we should keep threads without explicit action

[Lldb-commits] [PATCH] D65534: [clang] Change FileManager to use llvm::ErrorOr instead of null on failure

jkorous added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidy.cpp:240 +auto File = SourceMgr.getFileManager().getFile(FilePath); +if (!File) + return SourceLocation(); Previously we'd hit the assert in `translateFile()` called fro

[Lldb-commits] [PATCH] D65547: [Reproducers] Force replay in synchronous mode.

This revision was automatically updated to reflect the committed changes. Closed by commit rL367494: [Reproducers] Force replay in synchronous mode. (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:/

[Lldb-commits] [PATCH] D65534: [clang] Change FileManager to use llvm::ErrorOr instead of null on failure

harlanhaskins updated this revision to Diff 212701. harlanhaskins added a comment. Store references instead of raw pointers in FileManger's cache Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65534/new/ https://reviews.llvm.org/D65534 Files: cla

[Lldb-commits] [lldb] r367494 - [Reproducers] Force replay in synchronous mode.

Author: jdevlieghere Date: Wed Jul 31 16:34:45 2019 New Revision: 367494 URL: http://llvm.org/viewvc/llvm-project?rev=367494&view=rev Log: [Reproducers] Force replay in synchronous mode. Replaying a reproducer in asynchronous mode never makes sense. This patch disables asynchronous mode during re

[Lldb-commits] [PATCH] D65534: [clang] Change FileManager to use llvm::ErrorOr instead of null on failure

harlanhaskins added inline comments. Comment at: clang/include/clang/Basic/FileManager.h:217 /// - /// This returns NULL if the file doesn't exist. + /// This returns a \c std::error_code if there was an error loading the file. /// JDevlieghere wrote: > h

[Lldb-commits] [PATCH] D65534: [clang] Change FileManager to use llvm::ErrorOr instead of null on failure

JDevlieghere added inline comments. Comment at: clang/include/clang/Basic/FileManager.h:217 /// - /// This returns NULL if the file doesn't exist. + /// This returns a \c std::error_code if there was an error loading the file. /// harlanhaskins wrote: > j

[Lldb-commits] [PATCH] D65547: [Reproducers] Force replay in synchronous mode.

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65547/new/ https://reviews.llvm.org/D65547 ___ lldb-commits mailing list lldb-comm

[Lldb-commits] [PATCH] D65547: [Reproducers] Force replay in synchronous mode.

JDevlieghere updated this revision to Diff 212695. JDevlieghere added a comment. Be more precise in comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65547/new/ https://reviews.llvm.org/D65547 Files: lldb/lit/Reproducer/TestSynchronous.test lldb/source/Interpreter/CommandInter

[Lldb-commits] [PATCH] D65547: [Reproducers] Force replay in synchronous mode.

JDevlieghere created this revision. JDevlieghere added reviewers: jingham, labath, teemperor. Herald added a project: LLDB. Replaying a reproducer in asynchronous mode never makes sense. This patch disables asynchronous mode during replay. Repository: rLLDB LLDB https://reviews.llvm.org/D655

[Lldb-commits] [PATCH] D65546: Fix TestThreadSpecificBreakpoint on Windows

stella.stamenova accepted this revision. stella.stamenova added a comment. This revision is now accepted and ready to land. LGTM. Please keep an eye on the bot after you commit though CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65546/new/ https://reviews.llvm.org/D65546 ___

[Lldb-commits] [PATCH] D65363: [lldb-vscode] add `launchCommands` to handle launch specific commands

kusmour updated this revision to Diff 212683. kusmour added a comment. complete the corresponding test for extra `launchCommands` Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65363/new/ https://reviews.llvm.org/D65363 Files: lldb/packages/Python/lldbsuite/

[Lldb-commits] [PATCH] D65546: Fix TestThreadSpecificBreakpoint on Windows

amccarth created this revision. amccarth added a reviewer: stella.stamenova. This test was frequently hanging on Windows, causing a timeout after 10 minutes. The short delay (100 microsecond) in the sample program could cause a deadlock in the Windows thread pool, as I've explained in the test

[Lldb-commits] [PATCH] D65534: [clang] Change FileManager to use llvm::ErrorOr instead of null on failure

harlanhaskins marked 2 inline comments as done. harlanhaskins added inline comments. Comment at: clang/include/clang/Basic/FileManager.h:143 /// - llvm::StringMap SeenDirEntries; + llvm::StringMap, llvm::BumpPtrAllocator> + SeenDirEntries; jkorous wrote: >

Re: [Lldb-commits] [lldb] r367441 - Don't crash when pass by value struct has no definition.

> On Jul 31, 2019, at 12:50 PM, via lldb-commits > wrote: > > > >> -Original Message- >> From: lldb-commits [mailto:lldb-commits-boun...@lists.llvm.org] On Behalf >> Of Greg Clayton via lldb-commits >> Sent: Wednesday, July 31, 2019 2:29 PM >> To: Raphael Isemann >> Cc: lldb-commits

[Lldb-commits] [PATCH] D65534: [clang] Change FileManager to use llvm::ErrorOr instead of null on failure

jkorous added inline comments. Comment at: clang/include/clang/Basic/FileManager.h:143 /// - llvm::StringMap SeenDirEntries; + llvm::StringMap, llvm::BumpPtrAllocator> + SeenDirEntries; Maybe we could replace this with some type that has hard-to-use-incorre

[Lldb-commits] [PATCH] D65534: [clang] Change FileManager to use llvm::ErrorOr instead of null on failure

davide added a comment. [and Raphael for the clang vendor bits] Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65534/new/ https://reviews.llvm.org/D65534 ___ lldb-commits mailing list lldb-commits@lists

[Lldb-commits] [PATCH] D65534: [clang] Change FileManager to use llvm::ErrorOr instead of null on failure

davide added a comment. Really on the lldb side, Jonas is the right person to review this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65534/new/ https://reviews.llvm.org/D65534 ___ lldb-commit

[Lldb-commits] [PATCH] D64964: [API] Remove use of ClangASTContext from SBTarget

This revision was automatically updated to reflect the committed changes. Closed by commit rL367480: [API] Remove use of ClangASTContext from SBTarget (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE

[Lldb-commits] [lldb] r367480 - [API] Remove use of ClangASTContext from SBTarget

Author: xiaobai Date: Wed Jul 31 13:47:38 2019 New Revision: 367480 URL: http://llvm.org/viewvc/llvm-project?rev=367480&view=rev Log: [API] Remove use of ClangASTContext from SBTarget Summary: The methods to find types in a Target aren't clang specific and are pretty generalizable to type systems

[Lldb-commits] [lldb] r367481 - [GDBRemote] Reflow comments and improve docs.

Author: jdevlieghere Date: Wed Jul 31 13:47:44 2019 New Revision: 367481 URL: http://llvm.org/viewvc/llvm-project?rev=367481&view=rev Log: [GDBRemote] Reflow comments and improve docs. Improved the GDB client base documentation while I was reading through it. Looks like it got messed up during th

[Lldb-commits] [PATCH] D65534: [clang] Change FileManager to use llvm::ErrorOr instead of null on failure

harlanhaskins created this revision. harlanhaskins added reviewers: arphaman, bruno. Herald added subscribers: lldb-commits, cfe-commits, jsji, kadircet, dexonsmith, jkorous, MaskRay, kbarton, nemanjai. Herald added a reviewer: martong. Herald added a reviewer: shafik. Herald added projects: clang

[Lldb-commits] [PATCH] D65489: Tablegen option enum value elements

JDevlieghere added a comment. In D65489#1608936 , @labath wrote: > In D65489#1608904 , @JDevlieghere > wrote: > > > I don't have any cleanups planned for now. My motivation is purely > > aesthetical: I don't like

Re: [Lldb-commits] [lldb] r367441 - Don't crash when pass by value struct has no definition.

> -Original Message- > From: lldb-commits [mailto:lldb-commits-boun...@lists.llvm.org] On Behalf > Of Greg Clayton via lldb-commits > Sent: Wednesday, July 31, 2019 2:29 PM > To: Raphael Isemann > Cc: lldb-commits > Subject: Re: [Lldb-commits] [lldb] r367441 - Don't crash when pass by > v

[Lldb-commits] [PATCH] D64993: Fix PC adjustment in StackFrame::GetSymbolContext

JosephTremoulet added a comment. In D64993#1608452 , @labath wrote: > I haven't looked at the implementation, but I did run into the problem you > are fixing in the past, and I am happy that someone is finally implementing > this. I just wanted to say th

[Lldb-commits] [PATCH] D64993: Fix PC adjustment in StackFrame::GetSymbolContext

JosephTremoulet updated this revision to Diff 212642. JosephTremoulet added a comment. - add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64993/new/ https://reviews.llvm.org/D64993 Files: lldb/include/lldb/Core/Address.h lldb/include/lld

[Lldb-commits] [PATCH] D65489: Tablegen option enum value elements

labath added a comment. In D65489#1608904 , @JDevlieghere wrote: > I don't have any cleanups planned for now. My motivation is purely > aesthetical: I don't like the `// clang-format off` markers and think the C > arrays look messy with the multiline od

[Lldb-commits] [PATCH] D65489: Tablegen option enum value elements

JDevlieghere added a comment. In D65489#1607833 , @labath wrote: > In D65489#1607807 , @JDevlieghere > wrote: > > > In D65489#1607801 , @labath wrote: > > > > > Why do we ne

Re: [Lldb-commits] [lldb] r367441 - Don't crash when pass by value struct has no definition.

On Wed, Jul 31, 2019 at 11:29 AM Greg Clayton via lldb-commits wrote: > > > > > On Jul 31, 2019, at 10:57 AM, Raphael Isemann wrote: > > > > It seems that patch is lacking a test (which doesn't seem too hard to > > provide). > > I am not the original author of this patch that was causing the cra

Re: [Lldb-commits] [lldb] r367385 - [CompletionRequest] Remove unimplemented members.

This wasn't a "weird thing". When you have a match with potentially many hits, it would be very handy to say "give me the first 10", then "give me the next 10" so you only do the work to fetch as much as your paginator would show. That would allow us to avoid unnecessary work when somebody g

Re: [Lldb-commits] [lldb] r367441 - Don't crash when pass by value struct has no definition.

> On Jul 31, 2019, at 10:57 AM, Raphael Isemann wrote: > > It seems that patch is lacking a test (which doesn't seem too hard to > provide). I am not the original author of this patch that was causing the crash, just fixing a crash that was introduced by the patch. I am all ears for anyone

[Lldb-commits] [lldb] r367459 - [CommandCompletions] Remove commented out code.

Author: jdevlieghere Date: Wed Jul 31 11:09:26 2019 New Revision: 367459 URL: http://llvm.org/viewvc/llvm-project?rev=367459&view=rev Log: [CommandCompletions] Remove commented out code. We use version control here. Modified: lldb/trunk/include/lldb/Interpreter/CommandCompletions.h Modified

[Lldb-commits] [PATCH] D65469: Remove `bugreport` command

JDevlieghere added a comment. In D65469#1608737 , @jingham wrote: > If we don't want to forget that there was specific useful info, we could gate > this patch on implementing the "reproducer generate " feature. That > should be easy to add if we're clea

[Lldb-commits] [PATCH] D65498: Fix completion for functions in anonymous namespaces

This revision was automatically updated to reflect the committed changes. Closed by commit rL367455: Fix completion for functions in anonymous namespaces (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: ht

Re: [Lldb-commits] [lldb] r367441 - Don't crash when pass by value struct has no definition.

It seems that patch is lacking a test (which doesn't seem too hard to provide). Am Mi., 31. Juli 2019 um 18:24 Uhr schrieb Greg Clayton via lldb-commits : > > Author: gclayton > Date: Wed Jul 31 09:24:55 2019 > New Revision: 367441 > > URL: http://llvm.org/viewvc/llvm-project?rev=367441&view=rev >

[Lldb-commits] [lldb] r367455 - Fix completion for functions in anonymous namespaces

Author: jdevlieghere Date: Wed Jul 31 10:58:00 2019 New Revision: 367455 URL: http://llvm.org/viewvc/llvm-project?rev=367455&view=rev Log: Fix completion for functions in anonymous namespaces I was going through some of the old bugs and came across PR21069 which I was able to reproduce. The issue

[Lldb-commits] [PATCH] D65498: Fix completion for functions in anonymous namespaces

JDevlieghere added a comment. In D65498#1607819 , @teemperor wrote: > I think it's possible to rewrite the line when doing a completion, but I > remember that I got annoyed when I tried understand the code responsible for > that (and decipher the magic r

[Lldb-commits] [PATCH] D65469: Remove `bugreport` command

jingham added a comment. If we don't want to forget that there was specific useful info, we could gate this patch on implementing the "reproducer generate " feature. That should be easy to add if we're clear this this is the right design for reproducers. But I don't think that "bugreport unwi

[Lldb-commits] [PATCH] D65469: Remove `bugreport` command

jingham added a comment. The thing the "bugreport unwind" adds is that it runs a handful of commands that gather data useful in diagnosing unwind problems. That's useful when the information you need might not be output by the session in which the bug appeared. The same thing could be achieve

[Lldb-commits] [PATCH] D65469: Remove `bugreport` command

JDevlieghere added a comment. In D65469#1608653 , @clayborg wrote: > In D65469#1608631 , @JDevlieghere > wrote: > > > In D65469#1608278 , @clayborg > > wrote: > > > > > IMH

[Lldb-commits] [PATCH] D64993: Fix PC adjustment in StackFrame::GetSymbolContext

clayborg added a comment. Code looks fine now. Now Jason will need to chime in with comments on the new unwind functionality. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64993/new/ https://reviews.llvm.org/D64993 _

[Lldb-commits] [PATCH] D65414: Fix ClangASTContext::CreateParameterDeclaration to not call addDecl

stella.stamenova added a comment. I am able to do some testing as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65414/new/ https://reviews.llvm.org/D65414 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.or

[Lldb-commits] [PATCH] D64993: Fix PC adjustment in StackFrame::GetSymbolContext

JosephTremoulet updated this revision to Diff 212615. JosephTremoulet added a comment. - Move resolution helper from RegisterContextLLDB to lldb_private::Address - Defensively initialize out arguments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64

[Lldb-commits] [PATCH] D65469: Remove `bugreport` command

clayborg added a comment. In D65469#1608631 , @JDevlieghere wrote: > In D65469#1608278 , @clayborg wrote: > > > IMHO: we should keep this command and expand its abilities to help report > > stepping issues, expres

[Lldb-commits] [PATCH] D65469: Remove `bugreport` command

JDevlieghere added a comment. In D65469#1608278 , @clayborg wrote: > IMHO: we should keep this command and expand its abilities to help report > stepping issues, expression issues and more. Why? Getting good bug reports > from users is quite hard. Allowi

[Lldb-commits] [lldb] r367441 - Don't crash when pass by value struct has no definition.

Author: gclayton Date: Wed Jul 31 09:24:55 2019 New Revision: 367441 URL: http://llvm.org/viewvc/llvm-project?rev=367441&view=rev Log: Don't crash when pass by value struct has no definition. Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp Modified: lldb/trunk/s

[Lldb-commits] [PATCH] D64993: Fix PC adjustment in StackFrame::GetSymbolContext

clayborg added inline comments. Comment at: lldb/source/Plugins/Process/Utility/RegisterContextLLDB.cpp:595-624 +bool RegisterContextLLDB::TryResolveSymbolContextAndAddressRange( +lldb_private::Address pc, lldb_private::SymbolContext &sym_ctx, +lldb_private::AddressRange

[Lldb-commits] [PATCH] D64993: Fix PC adjustment in StackFrame::GetSymbolContext

JosephTremoulet marked an inline comment as done. JosephTremoulet added inline comments. Comment at: lldb/source/Plugins/Process/Utility/RegisterContextLLDB.cpp:595-624 +bool RegisterContextLLDB::TryResolveSymbolContextAndAddressRange( +lldb_private::Address pc, lldb_private:

[Lldb-commits] [PATCH] D64993: Fix PC adjustment in StackFrame::GetSymbolContext

labath added a comment. I haven't looked at the implementation, but I did run into the problem you are fixing in the past, and I am happy that someone is finally implementing this. I just wanted to say that for testing, I think you should be able to create some hand-written assembly that create

[Lldb-commits] [PATCH] D65435: SymbolVendor: Introduce Module::GetSymbolFile

labath added a comment. In D65435#1608276 , @clayborg wrote: > Alternatively we can switch to using a reference for: > > SymbolFile &Module::GetSymbolFile(bool can_create Stream *feedback_strm); > > > As I believe we always fall back to SymbolFileSymtab

[Lldb-commits] [PATCH] D64993: Fix PC adjustment in StackFrame::GetSymbolContext

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. I will let Jason comment on the unwind specifics since this is his area. I caught a few other things that need to be cleaned up. Comment at: lldb/include/lldb/

[Lldb-commits] [PATCH] D65469: Remove `bugreport` command

clayborg added a comment. IMHO: we should keep this command and expand its abilities to help report stepping issues, expression issues and more. Why? Getting good bug reports from users is quite hard. Allowing them to type "bugreport step --step-in" or "bugreport step --step-over" would be real

[Lldb-commits] [PATCH] D65435: SymbolVendor: Introduce Module::GetSymbolFile

clayborg added a comment. Alternatively we can switch to using a reference for: SymbolFile &Module::GetSymbolFile(bool can_create Stream *feedback_strm); As I believe we always fall back to SymbolFileSymtab don't we? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65435/new/ https://r

[Lldb-commits] [PATCH] D65435: SymbolVendor: Introduce Module::GetSymbolFile

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Just add a few null checks and this will be good to go. Comment at: source/Commands/CommandObjectTarget.cpp:2240 Module *m = target->GetImages().GetMod

[Lldb-commits] [PATCH] D65509: [lldb][CMake] Avoid 'Autogenerate scheme' dialogs in Xcode projects

sgraenitz created this revision. sgraenitz added a reviewer: jingham. Herald added a subscriber: mgorny. Herald added a project: LLDB. Supported in CMake 3.9 and higher: https://cmake.org/cmake/help/v3.9/variable/CMAKE_XCODE_GENERATE_SCHEME.html Older versions will just report it as unused in the

[Lldb-commits] [lldb] r367420 - [lldb][NFC] Check in completion crash test case

Author: teemperor Date: Wed Jul 31 05:15:21 2019 New Revision: 367420 URL: http://llvm.org/viewvc/llvm-project?rev=367420&view=rev Log: [lldb][NFC] Check in completion crash test case Added: lldb/trunk/packages/Python/lldbsuite/test/expression_command/completion-crash-incomplete-record/

[Lldb-commits] [PATCH] D65152: Fix issues with inferior stdout coming out of order

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL367418: Fix issues with inferior stdout coming out of order (authored by labath, committed by ). Herald added a project: L

[Lldb-commits] [lldb] r367416 - [lldb][NFC] Check in another crashing test case

Author: teemperor Date: Wed Jul 31 05:06:22 2019 New Revision: 367416 URL: http://llvm.org/viewvc/llvm-project?rev=367416&view=rev Log: [lldb][NFC] Check in another crashing test case Added: lldb/trunk/packages/Python/lldbsuite/test/expression_command/completion-crash2/ lldb/trunk/packa

[Lldb-commits] [lldb] r367418 - Fix issues with inferior stdout coming out of order

Author: labath Date: Wed Jul 31 05:06:50 2019 New Revision: 367418 URL: http://llvm.org/viewvc/llvm-project?rev=367418&view=rev Log: Fix issues with inferior stdout coming out of order Summary: We've had a bug where two pieces of code, executing on two threads were attempting to write inferior ou

[Lldb-commits] [PATCH] D65409: [ProcessWindows] Choose a register context file by prepocessor

This revision was automatically updated to reflect the committed changes. Closed by commit rL367414: [ProcessWindows] Choose a register context file by preprocessor (authored by tkrasnukha, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to com

[Lldb-commits] [PATCH] D65450: Add llvm-style RTTI to ObjectFile hierarchy

This revision was automatically updated to reflect the committed changes. Closed by commit rL367413: Add llvm-style RTTI to ObjectFile hierarchy (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.l

[Lldb-commits] [lldb] r367414 - [ProcessWindows] Choose a register context file by preprocessor

Author: tkrasnukha Date: Wed Jul 31 05:00:30 2019 New Revision: 367414 URL: http://llvm.org/viewvc/llvm-project?rev=367414&view=rev Log: [ProcessWindows] Choose a register context file by preprocessor Replaced Cmake option based check with the preprocessor macro as CMAKE_SYSTEM_PROCESSOR doesn't

[Lldb-commits] [lldb] r367413 - Add llvm-style RTTI to ObjectFile hierarchy

Author: labath Date: Wed Jul 31 04:57:34 2019 New Revision: 367413 URL: http://llvm.org/viewvc/llvm-project?rev=367413&view=rev Log: Add llvm-style RTTI to ObjectFile hierarchy Summary: On the heels of D62934, this patch uses the same approach to introduce llvm RTTI support to the ObjectFile hier

[Lldb-commits] [PATCH] D65414: Fix ClangASTContext::CreateParameterDeclaration to not call addDecl

labath added subscribers: amccarth, labath. labath added a comment. I think @amccarth kind of inherited the PDB stuff from Zach, but if you just need to try out a patch on windows, I can do that too. I was hoping I would be able to create a core file which you could open up on your end and repro

[Lldb-commits] [lldb] r367411 - [lldb][NFC] Check in completion crash test in lambda

Author: teemperor Date: Wed Jul 31 04:33:16 2019 New Revision: 367411 URL: http://llvm.org/viewvc/llvm-project?rev=367411&view=rev Log: [lldb][NFC] Check in completion crash test in lambda Added: lldb/trunk/packages/Python/lldbsuite/test/expression_command/completion-crash-lambda/ lldb/

[Lldb-commits] [lldb] r367410 - Add missing includes to SymbolFilePDBTests

Author: labath Date: Wed Jul 31 04:31:05 2019 New Revision: 367410 URL: http://llvm.org/viewvc/llvm-project?rev=367410&view=rev Log: Add missing includes to SymbolFilePDBTests These became needed after r367368. Modified: lldb/trunk/unittests/SymbolFile/PDB/CMakeLists.txt lldb/trunk/unitt

[Lldb-commits] [lldb] r367407 - [lldb][docs] Add CMake version notes for -B flag

Author: stefan.graenitz Date: Wed Jul 31 03:31:57 2019 New Revision: 367407 URL: http://llvm.org/viewvc/llvm-project?rev=367407&view=rev Log: [lldb][docs] Add CMake version notes for -B flag The original documentation update was reviewed with D65330 Modified: lldb/trunk/docs/_static/lldb.css

Re: [Lldb-commits] [lldb] r367358 - [SymbolFile] SymbolFileDWARF::ParseLineTable should lock its module

On 30/07/2019 23:22, Alex Langford via lldb-commits wrote: Author: xiaobai Date: Tue Jul 30 14:22:17 2019 New Revision: 367358 URL: http://llvm.org/viewvc/llvm-project?rev=367358&view=rev Log: [SymbolFile] SymbolFileDWARF::ParseLineTable should lock its module As of svn rL367298, SymbolFileDWAR

[Lldb-commits] [PATCH] D63165: Initial support for native debugging of x86/x64 Windows processes

labath added inline comments. Comment at: lldb/source/Plugins/Process/Utility/RegisterContextWindows_x86_64.cpp:141 +GetRegisterInfo_WoW64(const lldb_private::ArchSpec &arch) { + // A WoW64 register info is the same as the i386's. + std::vector &g_register_infos =

[Lldb-commits] [PATCH] D65401: SymbolVendor: Remove the object file member variable

This revision was automatically updated to reflect the committed changes. Closed by commit rL367392: SymbolVendor: Remove the object file member variable (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://

[Lldb-commits] [lldb] r367392 - SymbolVendor: Remove the object file member variable

Author: labath Date: Wed Jul 31 01:25:25 2019 New Revision: 367392 URL: http://llvm.org/viewvc/llvm-project?rev=367392&view=rev Log: SymbolVendor: Remove the object file member variable Summary: The last responsibility of the SymbolVendor was to hold an owning reference to the object file (in cas

[Lldb-commits] [PATCH] D63165: Initial support for native debugging of x86/x64 Windows processes

labath added inline comments. Comment at: lldb/source/Plugins/Process/Utility/RegisterContextWindows_i386.cpp:70-103 +static const RegisterInfo *GetRegisterInfoPtr(const ArchSpec &target_arch) { + switch (target_arch.GetMachine()) { + case llvm::Triple::x86: +return g_regi

[Lldb-commits] [PATCH] D65489: Tablegen option enum value elements

labath added a comment. In D65489#1607807 , @JDevlieghere wrote: > In D65489#1607801 , @labath wrote: > > > Why do we need a separate backend for this? Couldn't this be emitted as a > > part of the same `#include

[Lldb-commits] [PATCH] D65498: Fix completion for functions in anonymous namespaces

teemperor added a comment. I think it's possible to rewrite the line when doing a completion, but I remember that I got annoyed when I tried understand the code responsible for that (and decipher the magic return values). Can you file a radar maybe and I'll fix this once I got around to refacto

[Lldb-commits] [PATCH] D65498: Fix completion for functions in anonymous namespaces

JDevlieghere added a comment. In D65498#1607805 , @labath wrote: > I don't immediately see a better way to fix this, but I'm not terribly > familiar with this machinery either. I guess one day we may want to extend > the completion machinery to be able t

Re: [Lldb-commits] [lldb] r367385 - [CompletionRequest] Remove unimplemented members.

Thanks! Wasn’t sure back then if I can just remove that weird thing > On Jul 31, 2019, at 5:48 AM, Jonas Devlieghere via lldb-commits > wrote: > > Author: jdevlieghere > Date: Tue Jul 30 20:48:29 2019 > New Revision: 367385 > > URL: http://llvm.org/viewvc/llvm-project?rev=367385&view=rev > Log

[Lldb-commits] [PATCH] D65489: Tablegen option enum value elements

JDevlieghere added a comment. In D65489#1607801 , @labath wrote: > Why do we need a separate backend for this? Couldn't this be emitted as a > part of the same `#include "XXXProperties.inc"` which defines the property > definition? The two logically belo