[Lldb-commits] [PATCH] D58339: Changes for running LLDB test suite for Swift on PowerPC64LE

2019-02-17 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. I think you wanted to submit this patch to the downstream swift repo. I don't know exactly how that works, but I think they accept github pull requests. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58339/new/ https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D58330: 01/03: new SectionPart for Section subranges (for effective .debug_types concatenation)

2019-02-17 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. This all still seems very messy to me. It also appears that we will still end up mmapping the object file, and then copying all of the debug info out of it into a heap buffer. What's the reason we're trying so hard to concatenate things? IIRC, it was because it makes th

[Lldb-commits] [PATCH] D58125: Add ability to import std module into expression parser to improve C++ debugging

2019-02-17 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. In D58125#1399474 , @teemperor wrote: > @labath Thanks for the hint with the sysroot, but I'm not really sure what's > the best way to test this. Making a whole fake sysroot that can be used to > compile a std module seems overkil

[Lldb-commits] [PATCH] D58339: Changes for running LLDB test suite for Swift on PowerPC64LE

2019-02-17 Thread Sarvesh Tamba via Phabricator via lldb-commits
sarveshtamba created this revision. sarveshtamba added a project: LLDB. Herald added subscribers: lldb-commits, jsji, mgorny, nemanjai. The attached changes are required for running LLDB test suite related test cases for Apple Swift 5 on PowerPC64LE. Repository: rLLDB LLDB https://reviews.ll

[Lldb-commits] [PATCH] D54670: 03/03: .debug_types: Update of D32167 (.debug_types) on top of D51578 (section concatenation)

2019-02-17 Thread Jan Kratochvil via Phabricator via lldb-commits
jankratochvil updated this revision to Diff 187170. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54670/new/ https://reviews.llvm.org/D54670 Files: lldb/packages/Python/lldbsuite/test/lldbtest.py lldb/packages/Python/lldbsuite/test/make/Makefile.rules lldb

[Lldb-commits] [PATCH] D51578: 02/03: Contiguous sections (.debug_info+.debug_types) for D54670==D32167 (.debug_types)

2019-02-17 Thread Jan Kratochvil via Phabricator via lldb-commits
jankratochvil marked 2 inline comments as done. jankratochvil added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:693-707 +DataBufferHeap *databufferheap = new DataBufferHeap(); +DataBufferSP databuffer = DataBufferSP(databufferheap

[Lldb-commits] [PATCH] D51578: 02/03: Contiguous sections (.debug_info+.debug_types) for D54670==D32167 (.debug_types)

2019-02-17 Thread Jan Kratochvil via Phabricator via lldb-commits
jankratochvil updated this revision to Diff 187169. jankratochvil added a comment. > So if we have 3GB of .debug_info and 1GB of .debug_types, we are expecting to > allocate a heap based buffer and copy all the data into this? This will fail. That fallback code path is used only when there is no

[Lldb-commits] [PATCH] D58330: 01/03: new SectionPart for Section subranges (for effective .debug_types concatenation)

2019-02-17 Thread Jan Kratochvil via Phabricator via lldb-commits
jankratochvil created this revision. jankratochvil added a reviewer: clayborg. jankratochvil added a project: LLDB. Herald added subscribers: jdoerfert, arichardson, emaste. Herald added a reviewer: espindola. @clayborg requested more effective loading of

[Lldb-commits] [lldb] r354225 - Remove unused extern declaration as removed by D32167

2019-02-17 Thread Jan Kratochvil via lldb-commits
Author: jankratochvil Date: Sun Feb 17 09:12:37 2019 New Revision: 354225 URL: http://llvm.org/viewvc/llvm-project?rev=354225&view=rev Log: Remove unused extern declaration as removed by D32167 Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp Modified: lldb/trunk/sou

[Lldb-commits] [PATCH] D58125: Add ability to import std module into expression parser to improve C++ debugging

2019-02-17 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor marked 2 inline comments as done. teemperor added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/expression_command/import-std-module/conflicts/Makefile:3 +USE_LIBCPP := 1 +CXXFLAGS += -std=c++11 -fmodules -glldb -fimplicit-module-maps +CXX_SOURCES :=