labath added a comment.

This all still seems very messy to me. It also appears that we will still end 
up mmapping the object file, and then copying all of the debug info out of it 
into a heap buffer.

What's the reason we're trying so hard to concatenate things? IIRC, it was 
because it makes things appear DWARF5-like, but this is now creating a lot of 
infrastructure that will be completely unused in the dwarf5 case, so I think 
we're missing that goal. Can't we just admit that we are dealing with two 
sections here, and use one bit from the user_id_t (or whereever it's needed) to 
tell which one are we talking about?


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58330/new/

https://reviews.llvm.org/D58330



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to