labath added a comment. In D58125#1399474 <https://reviews.llvm.org/D58125#1399474>, @teemperor wrote:
> @labath Thanks for the hint with the sysroot, but I'm not really sure what's > the best way to test this. Making a whole fake sysroot that can be used to > compile a std module seems overkill, and not sure if symlinking or so is a > good approach either. I'm open to suggestions. How much of the sysroot would you actually need to recreate? Would a modulemap file and a one or two simple headers be enough? Since we're simply testing here that the prefix gets prepended, I am not too worried if we just don't test that. What would make this super-interesting for me is if it would enable testing of this feature without a hard dependency on having libc++ installed on their system (a lot of people on linux still don't have libc++ by default, or may have an older non-modularized version), so if the "sysroot" test could be made to run on those systems, it would be awesome. I am not sure though what would be needed to make that happen. I suspect this could be pretty tricky, since our test suite is not really prepared for that. The most tractable path may be via something like a core file. Like, open a core file, while specifying the sysroot, import @std, then try to display something, which would not be possible without it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58125/new/ https://reviews.llvm.org/D58125 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
