[Lldb-commits] [PATCH] D58309: [Reproducers] Have clang make use of lldb's VFS.

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. LGTM as long as we always set a custom module cache path. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58309/new/ https://reviews.llvm.org/D58309 ___

[Lldb-commits] [PATCH] D58309: [Reproducers] Have clang make use of lldb's VFS.

JDevlieghere updated this revision to Diff 187116. JDevlieghere added a comment. - Have lldb use a custom module cache and remove it before replaying the reproducer. - Remove the cocoa test now that we have a capture and replay test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58309/n

[Lldb-commits] [lldb] r354185 - Temporarily disable test:

Author: rsmith Date: Fri Feb 15 16:13:26 2019 New Revision: 354185 URL: http://llvm.org/viewvc/llvm-project?rev=354185&view=rev Log: Temporarily disable test: test/lang/cpp/class-template-parameter-pack/TestClassTemplateParameterPack.py It fails on Mac OS; apparently a VarDecl 'void *&C' is impl

[Lldb-commits] [PATCH] D58309: [Reproducers] Have clang make use of lldb's VFS.

aprantl added inline comments. Comment at: lldb/lit/Reproducer/Modules/TestModuleCXX.test:17 +# Capture the debug session. +# RUN: %lldb -x -b -s %S/Inputs/ModuleCXX.in --capture %t.repro %t.root/a.out | FileCheck %s --check-prefix CAPTURE +# CAPTURE: (success = 0) -

[Lldb-commits] [PATCH] D58309: [Reproducers] Have clang make use of lldb's VFS.

JDevlieghere updated this revision to Diff 187101. JDevlieghere added a comment. - Code review feedback Adrian CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58309/new/ https://reviews.llvm.org/D58309 Files: lldb/include/lldb/Host/FileSystem.h lldb/include/lldb/Symbol/ClangASTImport

[Lldb-commits] [PATCH] D58309: [Reproducers] Have clang make use of lldb's VFS.

aprantl added inline comments. Comment at: lldb/lit/Reproducer/Modules/Inputs/main.cpp:5 + Foo foo; + // break here. + return 0; This is not very robust, since there is no code on this line. Personally I'd use: ``` void stop() {} int main(int argc, char **a

[Lldb-commits] [PATCH] D58309: [Reproducers] Have clang make use of lldb's VFS.

JDevlieghere created this revision. JDevlieghere added reviewers: aprantl, clayborg, zturner, davide. JDevlieghere added a project: LLDB. Herald added subscribers: jdoerfert, teemperor. In r353906 we hooked up clang and lldb's reproducer infrastructure to capture files used by clang. This patch ad

[Lldb-commits] [lldb] r354181 - Add some unconditional logging on the failure points when attaching

Author: jmolenda Date: Fri Feb 15 14:39:30 2019 New Revision: 354181 URL: http://llvm.org/viewvc/llvm-project?rev=354181&view=rev Log: Add some unconditional logging on the failure points when attaching to a process so we'll always get messages in the console logs. Also make the "is frontboard

[Lldb-commits] [lldb] r354177 - Revert "Don't include UnixSignals.h from Host."

Author: davide Date: Fri Feb 15 13:55:29 2019 New Revision: 354177 URL: http://llvm.org/viewvc/llvm-project?rev=354177&view=rev Log: Revert "Don't include UnixSignals.h from Host." It broke the modules green dragon buildbot. Modified: lldb/trunk/include/lldb/Host/Host.h lldb/trunk/includ

[Lldb-commits] [PATCH] D58223: [lldb] [unittests] XFAIL two unittests failing on NetBSD

mgorny abandoned this revision. mgorny added a comment. Bad news: so far the alternate implementation suggestions don't work. Good news: we don't need after all. The `EINTR` fix seems to have fixed all the remaining tests for us. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://re

[Lldb-commits] [lldb] r354173 - Fix AST generated for a class template to connect the class inside a

Author: rsmith Date: Fri Feb 15 13:48:09 2019 New Revision: 354173 URL: http://llvm.org/viewvc/llvm-project?rev=354173&view=rev Log: Fix AST generated for a class template to connect the class inside a class template back to the template. Previously, when the ASTImporter imported the class, it di

[Lldb-commits] [PATCH] D58303: [win] Resolve the module only if there isn't one already

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB354172: [win] Resolve the module only if there isn't one already (authored by stella.stamenova, committed by ). Reposi

[Lldb-commits] [lldb] r354172 - [win] Resolve the module only if there isn't one already

Author: stella.stamenova Date: Fri Feb 15 13:40:59 2019 New Revision: 354172 URL: http://llvm.org/viewvc/llvm-project?rev=354172&view=rev Log: [win] Resolve the module only if there isn't one already Summary: This commit modifies the OnLoadModule method to resolve the module unless we already hav

[Lldb-commits] [PATCH] D58303: [win] Resolve the module only if there isn't one already

stella.stamenova created this revision. stella.stamenova added reviewers: labath, asmith. Herald added subscribers: lldb-commits, abidh. Herald added a project: LLDB. This commit modifies the OnLoadModule method to resolve the module unless we already have one Change by Hui Huang to fix the faili

[Lldb-commits] [PATCH] D57780: Don't include UnixSignals.h from Host

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB354168: Don't include UnixSignals.h from Host. (authored by zturner, committed by ). Herald added subscribers: abidh, arichardson, emaste. Herald added a reviewer: espindola. Herald added a project: LLD

[Lldb-commits] [lldb] r354168 - Don't include UnixSignals.h from Host.

Author: zturner Date: Fri Feb 15 12:43:56 2019 New Revision: 354168 URL: http://llvm.org/viewvc/llvm-project?rev=354168&view=rev Log: Don't include UnixSignals.h from Host. Host had a function to get the UnixSignals instance corresponding to the current host architecture. This means that Host ha

[Lldb-commits] [PATCH] D58279: Set cmake policy CMP0075 to NEW

xiaobai accepted this revision. xiaobai added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58279/new/ https://reviews.llvm.org/D58279 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [PATCH] D58167: Refactor user/group name resolving code

jingham added inline comments. Comment at: source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp:439 if (uid != UINT32_MAX) { -std::string name; -if (HostInfo::LookupUserName(uid, name)) { +if (auto name = HostInfo::GetUserIDResolver().GetUserNa

[Lldb-commits] [PATCH] D58257: Disable ExecControl/StopHook/stop-hook-threads.test on Linux

jingham added a comment. BTW, I still think that we should add an explicit way to indicate that stop hooks should continue. But the current intended behavior was regular. If any stop hook caused the target to proceed, it would terminate at that point and all the other stop hooks would be jett

[Lldb-commits] [PATCH] D58273: Fix TestDataFormatterLibcxxListLoop.py test

shafik added a comment. Thanks for fixing this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58273/new/ https://reviews.llvm.org/D58273 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[Lldb-commits] [PATCH] D58257: Disable ExecControl/StopHook/stop-hook-threads.test on Linux

jingham added a comment. Ah, I see what happened. stop-hooks should always be run in asynchronous mode, it doesn't make sense to have a stop hook persist over a continue. The intention is still to do that, as indicated by the fact that we set StopOnContinue to true in the options we pass to h

[Lldb-commits] [PATCH] D58050: PECOFF: Implement GetBaseAddress

stella.stamenova accepted this revision. stella.stamenova added a comment. This revision is now accepted and ready to land. LGTM. Now might not be the best time to commit it though because the LLDB build is broken on Windows. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews

[Lldb-commits] [PATCH] D58257: Disable ExecControl/StopHook/stop-hook-threads.test on Linux

This revision was automatically updated to reflect the committed changes. Closed by commit rL354149: Disable stop-hook-threads.test on Linux (authored by jgorbe, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.

[Lldb-commits] [lldb] r354149 - Disable stop-hook-threads.test on Linux

Author: jgorbe Date: Fri Feb 15 09:54:00 2019 New Revision: 354149 URL: http://llvm.org/viewvc/llvm-project?rev=354149&view=rev Log: Disable stop-hook-threads.test on Linux ExecControl/StopHook/stop-hook-threads.test is flaky on Linux (it's consistently failing on my machine, but doesn't fail on

[Lldb-commits] [PATCH] D58125: Add ability to import std module into expression parser to improve C++ debugging

aprantl added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/expression_command/import-std-module/conflicts/Makefile:3 +USE_LIBCPP := 1 +CXXFLAGS += -std=c++11 -fmodules -glldb -fimplicit-module-maps +CXX_SOURCES := main.cpp Makefile.rules defi

[Lldb-commits] [PATCH] D58125: Add ability to import std module into expression parser to improve C++ debugging

teemperor marked 2 inline comments as done. teemperor added a comment. @labath Thanks for the hint with the sysroot, but I'm not really sure what's the best way to test this. Making a whole fake sysroot that can be used to compile a std module seems overkill, and not sure if symlinking or so is

[Lldb-commits] [PATCH] D58125: Add ability to import std module into expression parser to improve C++ debugging

teemperor updated this revision to Diff 187026. teemperor added a comment. - Rebase on top of Adrian's patch (Thanks!) - Addressed the feedback from Shafik/Pavel. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58125/new/ https://reviews.llvm.org/D58125 Files: lldb/include/lldb/Express

[Lldb-commits] [PATCH] D57964: Fix potential UB when target_file directory is null

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB354145: Fix potential UB when target_file directory is null (authored by stefan.graenitz, committed by ). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D57964?vs=186

[Lldb-commits] [lldb] r354145 - Fix potential UB when target_file directory is null

Author: stefan.graenitz Date: Fri Feb 15 08:42:29 2019 New Revision: 354145 URL: http://llvm.org/viewvc/llvm-project?rev=354145&view=rev Log: Fix potential UB when target_file directory is null Summary: As seen in a crash report, the C-string returned for the directory component of `target_file`

[Lldb-commits] [PATCH] D58193: Do not explicitly depend on llvm tools during standalone build

sgraenitz added a comment. In D58193#1398376 , @labath wrote: > BTW, what's the reason for having super-high-fidelity list of dependencies in > a standalone build? There's a lot of ways to build LLDB (in-tree, standalone, monorepo, single-/multi-config

Re: [Lldb-commits] [lldb] r353778 - Define _ENABLE_EXTENDED_ALIGNED_STORAGE on Windows.

Thanks! On Fri, Feb 15, 2019 at 04:22 Pavel Labath wrote: > Ah, it's our struct XSAVE friend again. Yeah, I think I have a pretty > good idea of what this is doing, and I believe we don't need any special > alignment there, so I just went ahead and removed it. Assuming this > doesn't cause any i

[Lldb-commits] [PATCH] D58279: Set cmake policy CMP0075 to NEW

labath created this revision. labath added reviewers: sgraenitz, xiaobai. Herald added a subscriber: mgorny. The policy is about cmake_include_files ignoring CMAKE_REQUIRED_LIBRARIES in the OLD behavior. Llvm already sets this policy to NEW, but that is overridden by our cmake_minimum_required com

[Lldb-commits] [PATCH] D58050: PECOFF: Implement GetBaseAddress

labath added a comment. Herald added a subscriber: jdoerfert. ping Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58050/new/ https://reviews.llvm.org/D58050 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [lldb] r353778 - Define _ENABLE_EXTENDED_ALIGNED_STORAGE on Windows.

Ah, it's our struct XSAVE friend again. Yeah, I think I have a pretty good idea of what this is doing, and I believe we don't need any special alignment there, so I just went ahead and removed it. Assuming this doesn't cause any issues, you should be able to revert this patch. On 13/02/2019 18

[Lldb-commits] [PATCH] D58273: Fix TestDataFormatterLibcxxListLoop.py test

teemperor updated this revision to Diff 186994. teemperor edited the summary of this revision. teemperor added a comment. - Added #ifdef for 3.8 release. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58273/new/ https://reviews.llvm.org/D58273 Files: lldb/packages/Python/lldbsuite/te

[Lldb-commits] [PATCH] D57956: [www] Add ASTImporter fuzzer project.

teemperor closed this revision. teemperor added a comment. landed in llvm-svn: 354043 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57956/new/ https://reviews.llvm.org/D57956 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https:/

[Lldb-commits] [lldb] r354125 - Remove alignment from struct XSAVE altogether

Author: labath Date: Fri Feb 15 04:20:23 2019 New Revision: 354125 URL: http://llvm.org/viewvc/llvm-project?rev=354125&view=rev Log: Remove alignment from struct XSAVE altogether I reduced the alignment of this struct in r342029 to avoid compiler warnings about under-aligned allocations, but it t

[Lldb-commits] [PATCH] D58230: [lldb] [MainLoop] Add kevent() EINTR handling

This revision was automatically updated to reflect the committed changes. Closed by commit rL354122: [lldb] [MainLoop] Add kevent() EINTR handling (authored by mgorny, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews

[Lldb-commits] [PATCH] D58230: [lldb] [MainLoop] Add kevent() EINTR handling

mgorny added a comment. FTR, I've just verified this against NetBSD kernel sources and -- as I suspected and as I believe any reasonable implementation would do -- the only place where EINTR could be returned is when `kevent()` is sleeping, waiting for new events to appear in the event queue. T

[Lldb-commits] [lldb] r354122 - [lldb] [MainLoop] Add kevent() EINTR handling

Author: mgorny Date: Fri Feb 15 04:13:02 2019 New Revision: 354122 URL: http://llvm.org/viewvc/llvm-project?rev=354122&view=rev Log: [lldb] [MainLoop] Add kevent() EINTR handling Add missing EINTR handling for kevent() calls. If the call is interrupted, return from Poll() as if zero events were

[Lldb-commits] [lldb] r354114 - Fix the gdb-client test suite for python3

Author: labath Date: Fri Feb 15 02:47:34 2019 New Revision: 354114 URL: http://llvm.org/viewvc/llvm-project?rev=354114&view=rev Log: Fix the gdb-client test suite for python3 This applies the same fix that was done in r354106 to the lldb-server test: bitcasting the string to a bytes object before

[Lldb-commits] [PATCH] D58273: Fix TestDataFormatterLibcxxListLoop.py test

labath added a comment. Yeah, that sounds like a good interim solution. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58273/new/ https://reviews.llvm.org/D58273 ___ lldb-commits mailing list lldb-commits@lists.llvm

[Lldb-commits] [PATCH] D58167: Refactor user/group name resolving code

labath added inline comments. Comment at: include/lldb/Host/UserIDResolver.h:24 +public: + typedef uint32_t id_t; + virtual ~UserIDResolver(); // anchor clayborg wrote: > make this 64 bit for future proofing? And if so, just use lldb::user_id_t? I think the bes

[Lldb-commits] [PATCH] D58167: Refactor user/group name resolving code

labath updated this revision to Diff 186982. labath marked 13 inline comments as done. labath added a comment. Rename things to follow lldb style. All the remaining comments should be either marked as done, or have a comment explaining why I don't think doing that is a good idea. CHANGES SINCE L

[Lldb-commits] [lldb] r354112 - Sort files in source/Host/CMakeLists.txt

Author: labath Date: Fri Feb 15 02:06:21 2019 New Revision: 354112 URL: http://llvm.org/viewvc/llvm-project?rev=354112&view=rev Log: Sort files in source/Host/CMakeLists.txt Modified: lldb/trunk/source/Host/CMakeLists.txt Modified: lldb/trunk/source/Host/CMakeLists.txt URL: http://llvm.org/

[Lldb-commits] [PATCH] D58273: Fix TestDataFormatterLibcxxListLoop.py test

teemperor added a comment. We could also check the libc++ version via _LIBCPP_VERSION and just keep the old code around behind an ifdef? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58273/new/ https://reviews.llvm.org/D58273 ___

[Lldb-commits] [PATCH] D58273: Fix TestDataFormatterLibcxxListLoop.py test

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. The slight problem here is that we don't know which libc++ version we are going to build with, so this will then fail for people still using the old one. However, choosing the latest libc++ ve

[Lldb-commits] [PATCH] D58273: Fix TestDataFormatterLibcxxListLoop.py test

teemperor created this revision. teemperor added reviewers: shafik, zturner, labath. Herald added subscribers: lldb-commits, jdoerfert, christof. Herald added a project: LLDB. The compilation of the TestDataFormatterLibcxxListLoop.py currently fails with this error: functionalities/data-forma

[Lldb-commits] [PATCH] D58257: Disable ExecControl/StopHook/stop-hook-threads.test on Linux

labath added a comment. BTW, I am pretty sure the assert that Jorge is hitting would be reproduced everywhere when running the test in debug build (so that LLDB_CONFIGURATION_DEBUG is defined). I normally use a Release+Asserts build, hoping that has all assertions enabled, but it turns out this

[Lldb-commits] [PATCH] D58230: [lldb] [MainLoop] Add kevent() EINTR handling

krytarowski added a comment. @mgorny let's go through tech-kern@ and later checking FreeBSD/Darwin/OpenBSD. I think it's worth to clarify this in the documentation. As an intermediate version we can land this patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58230/new/ https://revi