aprantl added inline comments.
================
Comment at: lldb/lit/Reproducer/Modules/Inputs/main.cpp:5
+ Foo foo;
+ // break here.
+ return 0;
----------------
This is not very robust, since there is no code on this line. Personally I'd
use:
```
void stop() {}
int main(int argc, char **argv) {
Foo foo;
stop(); // break here
return 0;
}
```
================
Comment at: lldb/lit/Reproducer/Modules/TestModuleCXX.test:9
+# Compile the test case form the temporary root.
+# RUN: %clang %t.root/main.cpp -g -fmodules -o %t.root/a.out
+
----------------
does %clang set a -fmodule-cache-path ?
Please make sure that one is set otherwise this will cause chaos on incremental
bots where upstream clang changes the PCM file format without bumping the
version number,.
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58309/new/
https://reviews.llvm.org/D58309
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
