labath added a comment.

BTW, I am pretty sure the assert that Jorge is hitting would be reproduced 
everywhere when running the test in debug build (so that 
LLDB_CONFIGURATION_DEBUG is defined). I normally use a Release+Asserts build, 
hoping that has all assertions enabled, but it turns out this is not controlled 
by that.

I think we should at least hook things up so that LLDB_CONFIGURATION_DEBUG is 
triggered by -DLLVM_ENABLE_ASSERTIONS in cmake, but ideally, I'd just remove 
this variable altogether and replace it with standard _(N)DEBUG macros (or, for 
some of the more extreme uses of LLDB_CONFIGURATION_DEBUG, with 
LLVM_ENABLE_EXPENSIVE_CHECKS).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58257/new/

https://reviews.llvm.org/D58257



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to