[Lldb-commits] [PATCH] D56237: Implement GetLoadAddress for the Windows process plugin

labath added a comment. I like the direction this is going. I have one small comment about the code organization inline, but the bigger question I have in mind is: After these changes, is there any use for `Host::GetProcessBaseAddress` left? If so, what is it? I'd like to understand it and remo

[Lldb-commits] [PATCH] D58076: [Reproducers] Integrate FileProvider with clang

labath resigned from this revision. labath added a comment. Herald added a subscriber: jdoerfert. I don't know much about this part of the code, though the changes seem pretty straight-forward to me. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58076/new/ htt

Re: [Lldb-commits] [lldb] r353778 - Define _ENABLE_EXTENDED_ALIGNED_STORAGE on Windows.

On 12/02/2019 01:30, Jonas Devlieghere via lldb-commits wrote: Author: jdevlieghere Date: Mon Feb 11 16:30:21 2019 New Revision: 353778 URL: http://llvm.org/viewvc/llvm-project?rev=353778&view=rev Log: Define _ENABLE_EXTENDED_ALIGNED_STORAGE on Windows. Apparently there are multiple places wher

[Lldb-commits] [PATCH] D56237: Implement GetLoadAddress for the Windows process plugin

asmith updated this revision to Diff 186401. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56237/new/ https://reviews.llvm.org/D56237 Files: include/lldb/Host/Host.h source/Host/common/Host.cpp source/Host/windows/Host.cpp source/Plugins/DynamicLoader/Windows-DYLD/DynamicLoaderWi

[Lldb-commits] [lldb] r353795 - Remove redundant ::get() for smart pointer. (NFC)

Author: jdevlieghere Date: Mon Feb 11 19:47:39 2019 New Revision: 353795 URL: http://llvm.org/viewvc/llvm-project?rev=353795&view=rev Log: Remove redundant ::get() for smart pointer. (NFC) This commit removes redundant calls to smart pointer’s ::get() method. https://clang.llvm.org/extra/clang-t

[Lldb-commits] [PATCH] D58090: [WIP] Deserialize Clang module search path from DWARF

aprantl created this revision. aprantl added reviewers: teemperor, JDevlieghere. This is an unfinished patch I'm working on that Raphael may find interesting. Posting to get early feedback and to avoid stepping on each others' toes. rdar://problem/47970144 https://reviews.llvm.org/D58090 File

[Lldb-commits] [lldb] r353783 - [Thread] Update the correct variable

Author: jdevlieghere Date: Mon Feb 11 17:04:57 2019 New Revision: 353783 URL: http://llvm.org/viewvc/llvm-project?rev=353783&view=rev Log: [Thread] Update the correct variable The new shared pointer was assigning to the temporary instead of the member (m_curr_frames_sp). Modified: lldb/trunk

[Lldb-commits] [lldb] r353778 - Define _ENABLE_EXTENDED_ALIGNED_STORAGE on Windows.

Author: jdevlieghere Date: Mon Feb 11 16:30:21 2019 New Revision: 353778 URL: http://llvm.org/viewvc/llvm-project?rev=353778&view=rev Log: Define _ENABLE_EXTENDED_ALIGNED_STORAGE on Windows. Apparently there are multiple places where MSVC complains about instantiations with extended aligment. I t

[Lldb-commits] [lldb] r353768 - Some cleanup after moving to std::make_shared

Author: jdevlieghere Date: Mon Feb 11 15:48:59 2019 New Revision: 353768 URL: http://llvm.org/viewvc/llvm-project?rev=353768&view=rev Log: Some cleanup after moving to std::make_shared Addresses Tatyana Krasnukha's feedback from D57990. Modified: lldb/trunk/source/Core/IOHandler.cpp lldb

[Lldb-commits] [lldb] r353769 - [ObjectFileMachO] Revert std::make_shared

Author: jdevlieghere Date: Mon Feb 11 15:49:13 2019 New Revision: 353769 URL: http://llvm.org/viewvc/llvm-project?rev=353769&view=rev Log: [ObjectFileMachO] Revert std::make_shared This caused a rather interesting error message on MSVC: error C2338 and I'm not sure how to properly fix it. Modifi

[Lldb-commits] [PATCH] D57990: Use std::make_shared in LLDB (NFC)

Eugene.Zelenko added inline comments. Comment at: lldb/source/Plugins/Process/minidump/ProcessMinidump.cpp:10 #include "ProcessMinidump.h" + #include "ThreadMinidump.h" Spurious separator. Comment at: lldb/source/Plugins/Process/minidump/Thre

[Lldb-commits] [PATCH] D58076: [Reproducers] Integrate FileProvider with clang

JDevlieghere created this revision. JDevlieghere added reviewers: labath, shafik, davide. JDevlieghere added a project: LLDB. Herald added a subscriber: teemperor. This patch hooks up clang to LLDB's FileProvider, so that files used by clang are part of the reproducer. Repository: rLLDB LLDB

[Lldb-commits] [lldb] r353753 - Fixed function name in log statement

Author: teemperor Date: Mon Feb 11 13:45:33 2019 New Revision: 353753 URL: http://llvm.org/viewvc/llvm-project?rev=353753&view=rev Log: Fixed function name in log statement Modified: lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp Modified: lldb/trunk/source/Plugi

[Lldb-commits] [lldb] r353752 - Use of `@return` is not appropriate for a function with a void return type.

Author: jdevlieghere Date: Mon Feb 11 13:43:18 2019 New Revision: 353752 URL: http://llvm.org/viewvc/llvm-project?rev=353752&view=rev Log: Use of `@return` is not appropriate for a function with a void return type. The comment for this declaration causes a warning with -Wdocumentation: Invalid @r

Re: [Lldb-commits] [PATCH] D56904: [NativePDB] Process virtual bases in the correct order

lgtm! On Mon, Feb 11, 2019 at 7:19 AM Aleksandr Urakov via Phabricator < revi...@reviews.llvm.org> wrote: > aleksandr.urakov added a comment. > > Thanks for the help with the tests, it looks like they are ok now! So can > we proceed with this patch? > > > Repository: > rLLDB LLDB > > CHANGES SI

[Lldb-commits] [PATCH] D56531: [CMake] Replace use of llvm-config with LLVM and Clang CMake packages

sgraenitz added inline comments. Comment at: lldb/trunk/cmake/modules/LLDBStandalone.cmake:20 + # We set LLVM_MAIN_INCLUDE_DIR so that it gets included in TableGen flags. + set(LLVM_MAIN_INCLUDE_DIR "${LLVM_BUILD_MAIN_INCLUDE_DIR}" CACHE PATH "Path to LLVM's source include dir

[Lldb-commits] [PATCH] D57995: [lldb] [cmake] Use install directories for LLVM_* variables

sgraenitz added a comment. Indeed, these variables do not exist when running against a LLVM/Clang install-tree and this should be fixed. Did you give this a try running against a LLVM/Clang build-tree? Dumping the values here locally, gives me: LLVM_BUILD_MAIN_INCLUDE_DIR /path/to/llvm/includ

[Lldb-commits] [PATCH] D58052: Extract common PlatformPOSIX/Windows code into a separate class

jingham accepted this revision. jingham added a comment. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58052/new/ https://reviews.llvm.org/D58052 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[Lldb-commits] [PATCH] D57990: Use std::make_shared in LLDB (NFC)

tatyana-krasnukha added a comment. Yes, of course! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57990/new/ https://reviews.llvm.org/D57990 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/lis

[Lldb-commits] [PATCH] D57990: Use std::make_shared in LLDB (NFC)

JDevlieghere added a comment. @tatyana-krasnukha and @Eugene.Zelenko, are you okay with me addressing those thing in a follow-up? Comment at: lldb/source/API/SBData.cpp:12 +#include + #include "lldb/API/SBData.h" Eugene.Zelenko wrote: > JDevlieghere wrote: >

[Lldb-commits] [PATCH] D56537: ObjectFilePECOFF: Create a "container" section spanning the entire module image

clayborg added inline comments. Comment at: source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp:1370 -auto section = section_list->GetSectionAtIndex(section_idx); +auto section = section_list->FindSectionByID(section_id); if (!section) How fast is this

[Lldb-commits] [PATCH] D56537: ObjectFilePECOFF: Create a "container" section spanning the entire module image

amccarth added a comment. My knowledge of PECOFF is even more limited, but it's my understanding that the ImageBase is the _preferred_ address for the module. That doesn't guarantee that's the actual address it would be loaded at. Not just because of ASLR but also because there may be conflic

[Lldb-commits] [lldb] r353721 - Update SymbolVendorMacOSX for new GetUUID interface

Author: jdevlieghere Date: Mon Feb 11 09:19:26 2019 New Revision: 353721 URL: http://llvm.org/viewvc/llvm-project?rev=353721&view=rev Log: Update SymbolVendorMacOSX for new GetUUID interface The interface changed in r353714. Modified: lldb/trunk/source/Plugins/SymbolVendor/MacOSX/SymbolVendo

[Lldb-commits] [PATCH] D57999: [lldb] [lldb-instr] Add missing linkage to clang libraries

JDevlieghere added a comment. Thanks! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57999/new/ https://reviews.llvm.org/D57999 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[Lldb-commits] [lldb] r353714 - Simplify ObjectFile::GetUUID

Author: labath Date: Mon Feb 11 08:14:02 2019 New Revision: 353714 URL: http://llvm.org/viewvc/llvm-project?rev=353714&view=rev Log: Simplify ObjectFile::GetUUID instead of returning the UUID through by-ref argument and a boolean value indicating success, we can just return it directly. Since the

[Lldb-commits] [PATCH] D57990: Use std::make_shared in LLDB (NFC)

Eugene.Zelenko added inline comments. Comment at: lldb/source/API/SBTypeEnumMember.cpp:78 TypeEnumMemberImpl &SBTypeEnumMember::ref() { if (m_opaque_sp.get() == NULL) +m_opaque_sp = std::make_shared(); tatyana-krasnukha wrote: > ``` > if (!m_opaque_sp) >

[Lldb-commits] [PATCH] D57990: Use std::make_shared in LLDB (NFC)

tatyana-krasnukha added a comment. These also don't relate directly but intersect with your changes: Comment at: lldb/source/API/SBTypeEnumMember.cpp:78 TypeEnumMemberImpl &SBTypeEnumMember::ref() { if (m_opaque_sp.get() == NULL) +m_opaque_sp = std::make_shared(); -

[Lldb-commits] [PATCH] D58052: Extract common PlatformPOSIX/Windows code into a separate class

labath created this revision. labath added reviewers: jingham, zturner, clayborg, asmith. Herald added subscribers: mgorny, emaste. The two classes contained a lot of duplicated code, but there wasn't a good place to factor it to. It couldn't be the base Platform class, since we also have platform

[Lldb-commits] [PATCH] D56904: [NativePDB] Process virtual bases in the correct order

aleksandr.urakov added a comment. Thanks for the help with the tests, it looks like they are ok now! So can we proceed with this patch? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56904/new/ https://reviews.llvm.org/D56904

[Lldb-commits] [PATCH] D57809: [build.py] Add `VCINSTALLDIR` to default variables

This revision was automatically updated to reflect the committed changes. Closed by commit rL353709: [build.py] Add `-fms-compatibility-version=19` to `build.py` (authored by aleksandr.urakov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

Re: [Lldb-commits] [PATCH] D57809: [build.py] Add `VCINSTALLDIR` to default variables

Thank you! On Mon, Feb 11, 2019 at 6:01 PM Zachary Turner wrote: > Lgtm! > On Mon, Feb 11, 2019 at 12:11 AM Aleksandr Urakov via Phabricator < > revi...@reviews.llvm.org> wrote: > >> aleksandr.urakov added a comment. >> >> Zachary, can you take a look? please? >> >> >> Repository: >> rLLDB LLD

[Lldb-commits] [lldb] r353709 - [build.py] Add `-fms-compatibility-version=19` to `build.py`

Author: aleksandr.urakov Date: Mon Feb 11 07:13:33 2019 New Revision: 353709 URL: http://llvm.org/viewvc/llvm-project?rev=353709&view=rev Log: [build.py] Add `-fms-compatibility-version=19` to `build.py` Summary: `clang-cl` can't compile tests containing `char16_t` and `char32_t` types without th

Re: [Lldb-commits] [PATCH] D57809: [build.py] Add `VCINSTALLDIR` to default variables

Lgtm! On Mon, Feb 11, 2019 at 12:11 AM Aleksandr Urakov via Phabricator < revi...@reviews.llvm.org> wrote: > aleksandr.urakov added a comment. > > Zachary, can you take a look? please? > > > Repository: > rLLDB LLDB > > CHANGES SINCE LAST ACTION > https://reviews.llvm.org/D57809/new/ > > https

[Lldb-commits] [PATCH] D57990: Use std::make_shared in LLDB (NFC)

tatyana-krasnukha added a comment. A few modernizations which though don't directly relate to make_shared: Comment at: lldb/source/API/SBCommandInterpreter.cpp:560 lldb::CommandObjectSP new_command_sp; - new_command_sp.reset(new CommandPluginInterfaceImplementation( -

[Lldb-commits] [PATCH] D57689: Adds property to force enabling of GDB JIT loader for MacOS

labath added a comment. In D57689#1389212 , @yurydelendik wrote: > In D57689#1384894 , @labath wrote: > > > Do we need both this and the `enable-jit-breakpoint` setting? My impression > > was that the latter was m

[Lldb-commits] [PATCH] D57895: Breakpad: auto-detect path style of file entries

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB353702: Breakpad: auto-detect path style of file entries (authored by labath, committed by ). Herald added a subscriber: abidh. Herald added a project: LLDB. Changed prior to commit: https://reviews.

[Lldb-commits] [lldb] r353702 - Breakpad: auto-detect path style of file entries

Author: labath Date: Mon Feb 11 06:11:00 2019 New Revision: 353702 URL: http://llvm.org/viewvc/llvm-project?rev=353702&view=rev Log: Breakpad: auto-detect path style of file entries Summary: This adds support for auto-detection of path style to SymbolFileBreakpad (similar to how r351328 did the s

[Lldb-commits] [PATCH] D58000: [lldb] [test] Skip lldb-mi test if LLDB_DISABLE_PYTHON is used

This revision was automatically updated to reflect the committed changes. Closed by commit rL353700: [lldb] [test] Skip lldb-mi test if LLDB_DISABLE_PYTHON is used (authored by mgorny, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D58001: [lldb] [lit] Fix finding lld-link when it is not in 'compiler dir'

This revision was automatically updated to reflect the committed changes. mgorny marked an inline comment as done. Closed by commit rL353701: [lldb] [lit] Fix finding lld-link when it is not in 'compiler dir' (authored by mgorny, committed by ). Herald added a project: LLVM. Herald added a subscri

[Lldb-commits] [lldb] r353700 - [lldb] [test] Skip lldb-mi test if LLDB_DISABLE_PYTHON is used

Author: mgorny Date: Mon Feb 11 06:09:43 2019 New Revision: 353700 URL: http://llvm.org/viewvc/llvm-project?rev=353700&view=rev Log: [lldb] [test] Skip lldb-mi test if LLDB_DISABLE_PYTHON is used Skip running lldb-mi tests when Python support is disabled. This causes lldb-mi to unconditionally f

[Lldb-commits] [lldb] r353701 - [lldb] [lit] Fix finding lld-link when it is not in 'compiler dir'

Author: mgorny Date: Mon Feb 11 06:09:48 2019 New Revision: 353701 URL: http://llvm.org/viewvc/llvm-project?rev=353701&view=rev Log: [lldb] [lit] Fix finding lld-link when it is not in 'compiler dir' Fix the build helper to find lld-link via PATH lookup, rather than making a fragile assumption th

[Lldb-commits] [PATCH] D58001: [lldb] [lit] Fix finding lld-link when it is not in 'compiler dir'

mgorny marked 2 inline comments as done. mgorny added inline comments. Comment at: lldb/lit/helper/build.py:296 +if linker_path is None: raise ValueError('Could not find \'{}\''.format(linker_path)) return linker_path labath wrote: >

[Lldb-commits] [PATCH] D58001: [lldb] [lit] Fix finding lld-link when it is not in 'compiler dir'

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. lgtm Comment at: lldb/lit/helper/build.py:296 +if linker_path is None: raise ValueError('Could not find \'{}\''.format(linker_path)) return link

[Lldb-commits] [PATCH] D55356: Add a method to get the "base" file address of an object file

labath abandoned this revision. labath added a comment. This has been implemented for ELF in another way. PECOFF changes are waiting for review in D58050 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55356/new/ https://reviews.llvm.org/D55356 _

[Lldb-commits] [PATCH] D56537: ObjectFilePECOFF: Create a "container" section spanning the entire module image

labath added a comment. Could you please take a look at this? This is currently blocking me from making progress with breakpad symbol files. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56537/new/ https://reviews.llvm.org/D56537 ___

[Lldb-commits] [PATCH] D58050: PECOFF: Implement GetBaseAddress

labath created this revision. labath added reviewers: amccarth, zturner, stella.stamenova, asmith. labath added a project: LLDB. COFF files are modelled in lldb as having one big container section spanning the entire module image, with the actual sections being subsections of that. In this model,

[Lldb-commits] [PATCH] D57964: Fix potential UB when target_file directory is null

sgraenitz updated this revision to Diff 186224. sgraenitz added a comment. Polish && error out also on empty string CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57964/new/ https://reviews.llvm.org/D57964 Files: source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp In

[Lldb-commits] [PATCH] D57956: [www] Add ASTImporter fuzzer project.

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. > This project is about writing a fuzzer to proactively discover these ASTImporter bugs and provide minimal reproducers which make understanding and fixing the underlying bug easier. Rap

[Lldb-commits] [PATCH] D58000: [lldb] [test] Skip lldb-mi test if LLDB_DISABLE_PYTHON is used

mgorny updated this revision to Diff 186207. mgorny added a comment. Used `lit.local.cfg`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58000/new/ https://reviews.llvm.org/D58000 Files: lldb/lit/helper/toolchain.py lldb/lit/lit.site.cfg.py.in lldb/lit/tools/lldb-mi/lit.local.cfg

[Lldb-commits] [PATCH] D58001: [lldb] [lit] Fix finding lld-link when it is not in 'compiler dir'

mgorny updated this revision to Diff 186205. mgorny added a comment. Updated to use `find_executable()` unconditionally. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58001/new/ https://reviews.llvm.org/D58001 Files: lldb/lit/helper/build.py Index: lldb/lit/helper/build.py

[Lldb-commits] [lldb] r353686 - Revert "minidump: Add ability to attach (breakpad) symbol files to placeholder modules"

Author: labath Date: Mon Feb 11 02:30:24 2019 New Revision: 353686 URL: http://llvm.org/viewvc/llvm-project?rev=353686&view=rev Log: Revert "minidump: Add ability to attach (breakpad) symbol files to placeholder modules" The commit has broken TestMiniDump.py on windows. Reverting while I investi

[Lldb-commits] [PATCH] D57895: Breakpad: auto-detect path style of file entries

labath added a comment. In D57895#1390641 , @amccarth wrote: > I think `absolute_path` is great. Thanks for checking on the > `native`/`None`. I didn't want there to be any latent surprises. Thanks. BTW, I've added the auto-detection code to dwarf onl

[Lldb-commits] [PATCH] D57928: Fix x86 return pattern detection

labath added a comment. Thanks for the fix and the test. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57928/new/ https://reviews.llvm.org/D57928 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://li

[Lldb-commits] [PATCH] D57999: [lldb] [lldb-instr] Add missing linkage to clang libraries

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB353680: [lldb] [lldb-instr] Add missing linkage to clang libraries (authored by mgorny, committed by ). Changed prior to commit: https://reviews.llvm.org/D57999?vs=186111&id=186200#toc Repository:

[Lldb-commits] [PATCH] D58001: [lldb] [lit] Fix finding lld-link when it is not in 'compiler dir'

labath added inline comments. Comment at: lldb/lit/helper/build.py:293-298 if sys.platform == 'win32': name = name + '.exe' compiler_dir = os.path.dirname(self.compiler) linker_path = os.path.join(compiler_dir, name) +if not os.path

[Lldb-commits] [PATCH] D57999: [lldb] [lldb-instr] Add missing linkage to clang libraries

mgorny added a comment. Yes, I'm using the standalone build. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57999/new/ https://reviews.llvm.org/D57999 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/c

[Lldb-commits] [lldb] r353680 - [lldb] [lldb-instr] Add missing linkage to clang libraries

Author: mgorny Date: Mon Feb 11 02:02:26 2019 New Revision: 353680 URL: http://llvm.org/viewvc/llvm-project?rev=353680&view=rev Log: [lldb] [lldb-instr] Add missing linkage to clang libraries Fix build errors against shared clang by adding all the libraries used in the code. Differential Revisio

[Lldb-commits] [PATCH] D58000: [lldb] [test] Skip lldb-mi test if LLDB_DISABLE_PYTHON is used

labath added a comment. Instead of adding `REQUIRES: lldb-mi` to every test, it would be better to create an appropriate `lit.local.cfg` in the `lit/tools/lldb-mi` folder. I think something like: if not "lldb-mi" in config.available_features: config.unsupported = True ought to do the tr

[Lldb-commits] [PATCH] D57959: [lldb] [MainLoop] Initialize empty sigset_t correctly

labath added a comment. In D57959#1392394 , @mgorny wrote: > I was experimenting with disabling kevent, and apparently no other NetBSD > mechanism is supported by LLDB. Noticed this issue, so figured I'll fix it > while at it. Ok, thanks. Just FYI: I t

[Lldb-commits] [PATCH] D57999: [lldb] [lldb-instr] Add missing linkage to clang libraries

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. This happens when using the standalone build, right? I suspect this happens only there because cmake does not have enough information to correctly include transitive deps automatically. That's

[Lldb-commits] [lldb] r353677 - minidump: Add ability to attach (breakpad) symbol files to placeholder modules

Author: labath Date: Mon Feb 11 01:32:08 2019 New Revision: 353677 URL: http://llvm.org/viewvc/llvm-project?rev=353677&view=rev Log: minidump: Add ability to attach (breakpad) symbol files to placeholder modules Summary: The reason this wasn't working was that ProcessMinidump was creating odd obj

[Lldb-commits] [PATCH] D57751: minidump: Add ability to attach (breakpad) symbol files to placeholder modules

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB353677: minidump: Add ability to attach (breakpad) symbol files to placeholder modules (authored by labath, committed by ). Herald added a subscriber: abidh. Herald added a project: LLDB. Changed prior

[Lldb-commits] [PATCH] D57990: Use std::make_shared in LLDB (NFC)

labath added a comment. I agree with Eugene that the empty lines interfere with clang-format and that llvm does not use empty lines between system and own headers. However, our headers are already very inconsistent with that, so I don't think fixing that should be a part of this patch. It would

[Lldb-commits] [PATCH] D57959: [lldb] [MainLoop] Initialize empty sigset_t correctly

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB353675: [lldb] [MainLoop] Initialize empty sigset_t correctly (authored by mgorny, committed by ). Changed prior to commit: https://reviews.llvm.org/D57959?vs=186011&id=186194#toc Repository: rLLD

[Lldb-commits] [lldb] r353675 - [lldb] [MainLoop] Initialize empty sigset_t correctly

Author: mgorny Date: Mon Feb 11 01:18:46 2019 New Revision: 353675 URL: http://llvm.org/viewvc/llvm-project?rev=353675&view=rev Log: [lldb] [MainLoop] Initialize empty sigset_t correctly Fix MainLoop::RunImpl::get_sigmask() to correctly return empty sigset_t when SIGNAL_POLLING_UNSUPPORTED is tru

[Lldb-commits] [PATCH] D57959: [lldb] [MainLoop] Initialize empty sigset_t correctly

mgorny added a comment. I was experimenting with disabling kevent, and apparently no other NetBSD mechanism is supported by LLDB. Noticed this issue, so figured I'll fix it while at it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57959/new/ https://reviews.llvm.org/D57959 ___

[Lldb-commits] [PATCH] D57959: [lldb] [MainLoop] Initialize empty sigset_t correctly

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Lgtm, though I strongly suspect you will need to make sure NetBSD falls into the `! SIGNAL_POLLING_UNSUPPORTED` category to have even basic lldb-server functionality working. Have you looked a

[Lldb-commits] [PATCH] D57809: [build.py] Add `VCINSTALLDIR` to default variables

aleksandr.urakov added a comment. Zachary, can you take a look? please? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57809/new/ https://reviews.llvm.org/D57809 ___ lldb-commits mailing list lldb-commits@lists.llvm

Re: [Lldb-commits] [lldb] r353324 - [Reproducers] SBReproducer framework: Capture & Replay

Several files in this commit incorrectly use the old file headers from before the relicense. I've fixed them, but please be careful with any other outstanding commits. On Wed, Feb 6, 2019 at 10:57 AM Jonas Devlieghere via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: jdevlieghere >

[Lldb-commits] [lldb] r353663 - Update files to the new header that were incorrectly landed with the old

Author: chandlerc Date: Mon Feb 11 00:03:41 2019 New Revision: 353663 URL: http://llvm.org/viewvc/llvm-project?rev=353663&view=rev Log: Update files to the new header that were incorrectly landed with the old one. Modified: lldb/trunk/source/API/SBReproducer.cpp lldb/trunk/source/API/SBRe