labath added inline comments.
================
Comment at: lldb/lit/helper/build.py:293-298
if sys.platform == 'win32':
name = name + '.exe'
compiler_dir = os.path.dirname(self.compiler)
linker_path = os.path.join(compiler_dir, name)
+ if not os.path.exists(linker_path):
+ linker_path = find_executable(name, search_paths)
----------------
How about we replace all of this with a call like `linker_path =
find_executable(name, [compiler_dir] + search_paths)` ?
================
Comment at: lldb/lit/helper/build.py:299-300
+ linker_path = find_executable(name, search_paths)
if not os.path.exists(linker_path):
raise ValueError('Could not find \'{}\''.format(linker_path))
return linker_path
----------------
`find_executable` returns `None` on failure, so this needs to be adjusted.
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58001/new/
https://reviews.llvm.org/D58001
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
