[Lldb-commits] [PATCH] D55376: Generate LLDB website/documentation from rst with Sphinx

labath accepted this revision. labath added a comment. Let's ship it. :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55376/new/ https://reviews.llvm.org/D55376 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.o

[Lldb-commits] [PATCH] D56822: [Reproducers] Tool to insert SBReproducer macros

labath added a comment. So, if I understand this correctly, a constructor like `SBFoo::SBFoo(){}` will not be considered for macroization because it's empty? That doesn't sound right to me. Even an empty constructor has a side effect of constructing the object, which is something that I would e

[Lldb-commits] [PATCH] D56822: [Reproducers] Tool to insert SBReproducer macros

JDevlieghere updated this revision to Diff 184210. JDevlieghere added a comment. - Use join from StringExtras. - Rename Skip to ShoupdSkip and document its cases. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56822/new/ https://reviews.llvm.org/D56822 Files: tools/CMakeLists.txt to

[Lldb-commits] [lldb] r352570 - Add FileCollector + test to Xcode project.

Author: jdevlieghere Date: Tue Jan 29 15:48:53 2019 New Revision: 352570 URL: http://llvm.org/viewvc/llvm-project?rev=352570&view=rev Log: Add FileCollector + test to Xcode project. Added: lldb/trunk/lldb.xcworkspace/xcshareddata/ lldb/trunk/lldb.xcworkspace/xcshareddata/IDEWorkspaceCheck

[Lldb-commits] [PATCH] D57413: Fix some warnings with gcc on Linux

shafik added a comment. In D57413#1376280 , @davide wrote: > To clarify, I think we ought to fix the UB regardless, but Zachary's change > can go in anyway as it doesn't make the situation worse than it was before. It does not, I was more comment on the

[Lldb-commits] [PATCH] D57413: Fix some warnings with gcc on Linux

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB352557: Fix some warnings in building LLDB. (authored by zturner, committed by ). Herald added a subscriber: abidh. Changed prior to commit: https://reviews.llvm.org/D57413?vs=184163&id=184186#toc R

[Lldb-commits] [PATCH] D54617: [Reproducers] Add file provider

stella.stamenova added a comment. This change broke one of the tests on Windows: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/1099 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54617/new/ https://reviews.llvm.org/D54617 _

[Lldb-commits] [lldb] r352557 - Fix some warnings in building LLDB.

Author: zturner Date: Tue Jan 29 14:55:21 2019 New Revision: 352557 URL: http://llvm.org/viewvc/llvm-project?rev=352557&view=rev Log: Fix some warnings in building LLDB. Differential Revision: https://reviews.llvm.org/D57413 Modified: lldb/trunk/source/Commands/CommandObjectReproducer.cpp

[Lldb-commits] [lldb] r352556 - [test] Use correct macro in FileCollectorTest.cpp

Author: jdevlieghere Date: Tue Jan 29 14:53:47 2019 New Revision: 352556 URL: http://llvm.org/viewvc/llvm-project?rev=352556&view=rev Log: [test] Use correct macro in FileCollectorTest.cpp This test was supposed to be skipped on Windows but was using the wrong macro name. Modified: lldb/trun

[Lldb-commits] [PATCH] D57413: Fix some warnings with gcc on Linux

davide added a comment. To clarify, I think we ought to fix the UB regardless, but Zachary's change can go in anyway as it doesn't make the situation worse than it was before. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57413/new/ https://reviews.llvm.org/D57413 __

[Lldb-commits] [PATCH] D55376: Generate LLDB website/documentation from rst with Sphinx

jingham accepted this revision. jingham added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55376/new/ https://reviews.llvm.org/D55376 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[Lldb-commits] [PATCH] D57413: Fix some warnings with gcc on Linux

davide added inline comments. Comment at: lldb/source/Plugins/Language/ObjC/Cocoa.cpp:789-792 + assert(encodedBits.repr.unused == 0); + decodedBits.repr.sign = encodedBits.repr.sign; + decodedBits.repr.fraction = encodedBits.repr.fraction; + decodedBits.repr.exponent = decode

[Lldb-commits] [PATCH] D57413: Fix some warnings with gcc on Linux

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Ah, missed that. Whoever was probably just copying down the way the struct was defined internally in Foundation... This seems fine then - assuming Target & Host have the same endianness i

[Lldb-commits] [PATCH] D57413: Fix some warnings with gcc on Linux

shafik added inline comments. Comment at: lldb/source/Plugins/Language/ObjC/Cocoa.cpp:789-792 + assert(encodedBits.repr.unused == 0); + decodedBits.repr.sign = encodedBits.repr.sign; + decodedBits.repr.fraction = encodedBits.repr.fraction; + decodedBits.repr.exponent = decode

[Lldb-commits] [PATCH] D57363: Fix handling of CreateTemplateParameterList when there is an empty pack

teemperor accepted this revision. teemperor added a comment. LGTM, thanks for the patch! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57363/new/ https://reviews.llvm.org/D57363 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http

[Lldb-commits] [PATCH] D57413: Fix some warnings with gcc on Linux

zturner marked an inline comment as done. zturner added inline comments. Comment at: lldb/source/Plugins/Language/ObjC/NSDictionary.cpp:304-314 -union { - struct { -uint64_t _mutations; - }; - struct { -uint32_t _muts; -uint32_t _used:25

[Lldb-commits] [PATCH] D57363: Fix handling of CreateTemplateParameterList when there is an empty pack

shafik added a comment. @aprantl @teemperor @davide thank you for the review, some great catches. I believe I have addressed the comments. Comment at: packages/Python/lldbsuite/test/expression_command/radar_47565290/Makefile:1 +LEVEL = ../../make + aprantl wr

[Lldb-commits] [PATCH] D57363: Fix handling of CreateTemplateParameterList when there is an empty pack

shafik updated this revision to Diff 184173. shafik marked 19 inline comments as done. shafik added a comment. Addressed comments, including - Renamed test - Reduced test size - Stream-lined code in CreateTemplateParameterList(...) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57363/new

[Lldb-commits] [PATCH] D57413: Fix some warnings with gcc on Linux

davide added a comment. the changes that touch code I wrote lgtm. Comment at: lldb/source/Plugins/Language/ObjC/Cocoa.cpp:789-792 + assert(encodedBits.repr.unused == 0); + decodedBits.repr.sign = encodedBits.repr.sign; + decodedBits.repr.fraction = encodedBits.repr.fraction;

[Lldb-commits] [PATCH] D57330: Adjust documentation for git migration.

smeenai added a comment. In D57330#1376069 , @mehdi_amini wrote: > > You can avoid the git status pollution by adding the build directory to > > .git/info/exclude. > > Good to know! Should we include this in the doc? I can put that change up fore review

[Lldb-commits] [PATCH] D57413: Fix some warnings with gcc on Linux

zturner marked an inline comment as done. zturner added inline comments. Comment at: lldb/source/Plugins/Language/ObjC/NSDictionary.cpp:304-314 -union { - struct { -uint64_t _mutations; - }; - struct { -uint32_t _muts; -uint32_t _used:25

[Lldb-commits] [lldb] r352548 - Make a blind attempt at fixing PDBASTParser nullability issues

Author: adrian Date: Tue Jan 29 13:46:34 2019 New Revision: 352548 URL: http://llvm.org/viewvc/llvm-project?rev=352548&view=rev Log: Make a blind attempt at fixing PDBASTParser nullability issues Modified: lldb/trunk/source/Plugins/SymbolFile/PDB/PDBASTParser.cpp Modified: lldb/trunk/source/

[Lldb-commits] [PATCH] D57413: Fix some warnings with gcc on Linux

jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. I don't think the data formatter changes are right. Looks like whoever wrote these data formatters was directly reading target memory onto a host sized struct, expecting everythin

[Lldb-commits] [PATCH] D57413: Fix some warnings with gcc on Linux

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks Zachary, this LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57413/new/ https://reviews.llvm.org/D57413 ___ lldb

[Lldb-commits] [PATCH] D57413: Fix some warnings with gcc on Linux

zturner created this revision. zturner added reviewers: davide, JDevlieghere, jingham. Most of these are surrounding the ObjectiveC formatters. They use a lot of unions containing unnamed structs, which are not ISO C++ compliant and which gcc warns about. There are several other minor warnings

[Lldb-commits] [PATCH] D57330: Adjust documentation for git migration.

mehdi_amini added a comment. > You can avoid the git status pollution by adding the build directory to > .git/info/exclude. Good to know! Should we include this in the doc? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57330/new/ https://reviews.llvm.org/D57330

[Lldb-commits] [PATCH] D56602: Move FileAction, ProcessInfo and ProcessLaunchInfo from Target to Host

zturner accepted this revision. zturner added a comment. This revision is now accepted and ready to land. Seems I had forgotten about this. It looks pretty good to me, and I'm glad we're very close to breaking this dependency. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56602/new/ h

[Lldb-commits] [PATCH] D55376: Generate LLDB website/documentation from rst with Sphinx

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55376/new/ https://reviews.llvm.org/D55376 ___ lldb-commits mailing list lldb-commits

[Lldb-commits] [PATCH] D54617: [Reproducers] Add file provider

This revision was automatically updated to reflect the committed changes. Closed by commit rL352538: [Reproducers] Add file provider (authored by JDevlieghere, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D54617?vs=183968&id=184156#t

[Lldb-commits] [PATCH] D57378: [CMake] Accept entitlements for code signing in add_lldb_library()

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57378/new/ https://reviews.llvm.org/D57378 ___ lldb-commits mailing list

[Lldb-commits] [lldb] r352538 - [Reproducers] Add file provider

Author: jdevlieghere Date: Tue Jan 29 12:36:38 2019 New Revision: 352538 URL: http://llvm.org/viewvc/llvm-project?rev=352538&view=rev Log: [Reproducers] Add file provider This patch adds the file provider which is responsible for capturing files used by LLDB. When capturing a reproducer, we use

[Lldb-commits] [PATCH] D57334: [CMake] Accept ENTITLEMENTS in llvm_add_library()

bogner accepted this revision. bogner added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57334/new/ https://reviews.llvm.org/D57334 ___ lldb-commits ma

[Lldb-commits] [PATCH] D57330: Adjust documentation for git migration.

smeenai added a comment. In D57330#1375913 , @mehdi_amini wrote: > In D57330#1375096 , @labath wrote: > > > This is not an full out-of-source build, since the build folder is still a > > subfolder of the repo root

[Lldb-commits] [PATCH] D57330: Adjust documentation for git migration.

mehdi_amini added a comment. In D57330#1375096 , @labath wrote: > This is not an full out-of-source build, since the build folder is still a > subfolder of the repo root My definition of what qualify an "out-of-source" build is that the build process w

[Lldb-commits] [PATCH] D57402: build: remove custom variables

xiaobai added a comment. I don't mind you doing this. This just means that we must set LLVM_DIR and Clang_DIR instead of LLDB_PATH_TO_LLVM_BUILD and LLDB_PATH_TO_CLANG_BUILD. Maybe @sgraenitz might have something to say about this? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://

[Lldb-commits] [PATCH] D57402: build: remove custom variables

labath added a comment. I think this makes sense, but I don't use the standalone build, so it would be better if one of the standalone users reviewed it. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57402/new/ https://reviews.llvm.org/D57402 __

[Lldb-commits] [PATCH] D57402: build: remove custom variables

compnerd created this revision. compnerd added reviewers: zturner, xiaobai, sgraenitz, labath. Herald added subscribers: teemperor, mgorny. Prefer the standard CMake behaviour of using `_DIR` variables to indicate where to find the CMake configurations. This allows implicit use of the system pr

[Lldb-commits] [PATCH] D57273: Make Type::GetByteSize optional

stella.stamenova added a comment. I am not sure if you saw this, but it looks like it broke one of the tests on the Windows bot: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/1092 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57273/new/ https:/

[Lldb-commits] [PATCH] D57363: Fix handling of CreateTemplateParameterList when there is an empty pack

teemperor added inline comments. Comment at: packages/Python/lldbsuite/test/expression_command/radar_47565290/main.cpp:1 +template +class A { Maybe I miss something, but this could be simpler I think? E.g. like this: ``` template struct A { int foo() { ret

[Lldb-commits] [lldb] r352521 - Make Type::GetByteSize optional (NFC)

Author: adrian Date: Tue Jan 29 09:52:34 2019 New Revision: 352521 URL: http://llvm.org/viewvc/llvm-project?rev=352521&view=rev Log: Make Type::GetByteSize optional (NFC) This is a continuation of my quest to make the size 0 a supported value. This reapplies r352394 with additional PDB parser fi

[Lldb-commits] [PATCH] D57273: Make Type::GetByteSize optional

aprantl added a comment. Thanks a bunch, Pavel! That is very helpful. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57273/new/ https://reviews.llvm.org/D57273 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D56595: SymbolFileBreakpad: Add line table support

labath updated this revision to Diff 184103. labath added a comment. It took me a while to get back to this, but I believe this version now does what we want. It creates a compile unit for each function. The compile units are created as soon as the symbol file is initialized (it's needed to get th

[Lldb-commits] [PATCH] D57330: Adjust documentation for git migration.

This revision was automatically updated to reflect the committed changes. jyknight marked 2 inline comments as done. Closed by commit rC352514: Adjust documentation for git migration. (authored by jyknight, committed by ). Changed prior to commit: https://reviews.llvm.org/D57330?vs=183891&id=18

[Lldb-commits] [lldb] r352514 - Adjust documentation for git migration.

Author: jyknight Date: Tue Jan 29 08:37:27 2019 New Revision: 352514 URL: http://llvm.org/viewvc/llvm-project?rev=352514&view=rev Log: Adjust documentation for git migration. This fixes most references to the paths: llvm.org/svn/ llvm.org/git/ llvm.org/viewvc/ github.com/llvm-mirror/ github.

[Lldb-commits] [PATCH] D57330: Adjust documentation for git migration.

jyknight marked 8 inline comments as done. jyknight added a comment. In D57330#1375096 , @labath wrote: > I am not sure we should be recommending to people to place the build folder > under the llvm-project checkout. Is that how people use the monorepo bu

[Lldb-commits] [lldb] r352507 - BreakpadRecords: Add parsing code for FILE and LINE records

Author: labath Date: Tue Jan 29 07:39:27 2019 New Revision: 352507 URL: http://llvm.org/viewvc/llvm-project?rev=352507&view=rev Log: BreakpadRecords: Add parsing code for FILE and LINE records The two records aren't used by anything yet, but this part can be separated out easily, so I am comittin

[Lldb-commits] [PATCH] D56904: [NativePDB] Process virtual bases in the correct order

aleksandr.urakov marked an inline comment as done. aleksandr.urakov added inline comments. Comment at: lit/SymbolFile/NativePDB/tag-types.cpp:5 // Test that we can display tag types. // RUN: %build --compiler=clang-cl --nodefaultlib -o %t.exe -- %s // RUN: env LLDB_USE_NATIVE

[Lldb-commits] [PATCH] D56904: [NativePDB] Process virtual bases in the correct order

aleksandr.urakov updated this revision to Diff 184061. aleksandr.urakov added a comment. Thanks for the comments, I think that they make sense. I've updated the patch. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56904/new/ https://reviews.llvm.org/D56904 Fil

[Lldb-commits] [PATCH] D56822: [Reproducers] Tool to insert SBReproducer macros

labath added inline comments. Comment at: tools/sbrepro/SBRepro.cpp:22-31 +static std::string Join(const std::vector &V) { + std::string Str; + llvm::raw_string_ostream OS(Str); + for (std::size_t I = 0, E = V.size(); I < E; ++I) { +OS << V[I]; +if (I != E - 1) +

[Lldb-commits] [PATCH] D57334: [CMake] Accept ENTITLEMENTS in llvm_add_library()

sgraenitz added a comment. Tested this with LLDB library target. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57334/new/ https://reviews.llvm.org/D57334 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https

[Lldb-commits] [PATCH] D57378: [CMake] Accept entitlements for code signing in add_lldb_library()

sgraenitz created this revision. sgraenitz added reviewers: beanz, JDevlieghere, aprantl. Herald added a subscriber: mgorny. D57334 added entitlements support in `add_llvm_library()` so we can use it for library targets in LLDB. Additionally this patch fixes the

[Lldb-commits] [PATCH] D54617: [Reproducers] Add file provider

labath accepted this revision. labath added a comment. Looks good, thanks for bearing with me. I don't want to hold this up further, but ideally, I'd change that last test to use positive assertions instead of negative ones. E.g., right now this doesn't really fulfill my goal of documenting how

[Lldb-commits] [lldb] r352478 - [NativePDB] Fix lldb-x64-windows-ninja after r352464

Author: aleksandr.urakov Date: Tue Jan 29 02:46:28 2019 New Revision: 352478 URL: http://llvm.org/viewvc/llvm-project?rev=352478&view=rev Log: [NativePDB] Fix lldb-x64-windows-ninja after r352464 Modified: lldb/trunk/lit/SymbolFile/NativePDB/global-classes.cpp lldb/trunk/lit/SymbolFile/Na

[Lldb-commits] [PATCH] D57330: Adjust documentation for git migration.

labath added a comment. I am not sure we should be recommending to people to place the build folder under the llvm-project checkout. Is that how people use the monorepo build nowadays? This is not an full out-of-source build, since the build folder is still a subfolder of the repo root (and wit

[Lldb-commits] [PATCH] D56126: [NativePDB] Add basic support of methods recostruction in AST

This revision was automatically updated to reflect the committed changes. Closed by commit rL352464: [NativePDB] Add basic support of methods recostruction in AST (authored by aleksandr.urakov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llv

[Lldb-commits] [lldb] r352464 - [NativePDB] Add basic support of methods recostruction in AST

Author: aleksandr.urakov Date: Tue Jan 29 01:32:23 2019 New Revision: 352464 URL: http://llvm.org/viewvc/llvm-project?rev=352464&view=rev Log: [NativePDB] Add basic support of methods recostruction in AST Summary: This patch adds the basic support of methods reconstruction by native PDB plugin. I

[Lldb-commits] [PATCH] D56126: [NativePDB] Add basic support of methods recostruction in AST

aleksandr.urakov added a comment. Thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56126/new/ https://reviews.llvm.org/D56126 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[Lldb-commits] [PATCH] D57273: Make Type::GetByteSize optional

labath added a comment. The attached patch is what it took to get the tests passing for me. It could use a bit of cleanup though. F7864332: size.diff Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57273/new/ https://reviews.ll