shafik added inline comments.

================
Comment at: lldb/source/Plugins/Language/ObjC/Cocoa.cpp:789-792
+  assert(encodedBits.repr.unused == 0);
+  decodedBits.repr.sign = encodedBits.repr.sign;
+  decodedBits.repr.fraction = encodedBits.repr.fraction;
+  decodedBits.repr.exponent = decodeExponent(encodedBits.repr.exponent);
----------------
davide wrote:
> This bit is fine,  and it's the only one I can comment on, because I wrote it.
Your using the inactive member of union which is UB in C++.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57413/new/

https://reviews.llvm.org/D57413



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to