labath added inline comments.
================
Comment at: tools/sbrepro/SBRepro.cpp:22-31
+static std::string Join(const std::vector<std::string> &V) {
+ std::string Str;
+ llvm::raw_string_ostream OS(Str);
+ for (std::size_t I = 0, E = V.size(); I < E; ++I) {
+ OS << V[I];
+ if (I != E - 1)
+ OS << ", ";
----------------
There's a `join` in `ADT/StringExtras.h` which should do what you need here.
================
Comment at: tools/sbrepro/SBRepro.cpp:194-197
+ // Skip empty decls.
+ Stmt *Body = Decl->getBody();
+ if (!Body)
+ return true;
----------------
What exactly does this skip? Would e.g. a constructor with an empty body still
be considered for macro-ization?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56822/new/
https://reviews.llvm.org/D56822
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
