jingham added a comment.
For the most part this is fine. There are two bits to work on:
1. I think you could do all of this work on a static std::function object from
the data section even if you don't have a process. It might be worth seeing
whether you can do that. It looks like you can ma
This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB340218: Set path to sanitizer runtime when running tests
through LIT on macOS. (authored by adrian, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D50997?vs=161566&id=161575#toc
R
Author: adrian
Date: Mon Aug 20 15:00:31 2018
New Revision: 340218
URL: http://llvm.org/viewvc/llvm-project?rev=340218&view=rev
Log:
Set path to sanitizer runtime when running tests through LIT on macOS.
rdar://problem/42984739
Differential Revision: https://reviews.llvm.org/D50997
Modified:
Author: adrian
Date: Mon Aug 20 15:00:32 2018
New Revision: 340219
URL: http://llvm.org/viewvc/llvm-project?rev=340219&view=rev
Log:
Reflow comments
Modified:
lldb/trunk/lit/Suite/lldbtest.py
Modified: lldb/trunk/lit/Suite/lldbtest.py
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/lit/
aprantl added a comment.
Thanks, that was quite helpful!
https://reviews.llvm.org/D50997
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
vsk accepted this revision.
vsk added a comment.
This revision is now accepted and ready to land.
(LGTM with the second comment addressed.)
https://reviews.llvm.org/D50997
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.o
vsk added a comment.
Thanks so much for doing this!
Comment at: lit/Suite/lit.cfg:28
+ resource_dir = subprocess.check_output(config.cmake_cxx_compiler +
+ ' -print-resource-dir', shell=True)
+ runtime = os.path.join(resource_dir[:-1],
aprantl created this revision.
aprantl added a reviewer: vsk.
Automatically set path to sanitizer runtime when running tests on macOS.
rdar://problem/42984739
https://reviews.llvm.org/D50997
Files:
lit/Suite/lit.cfg
lit/Suite/lit.site.cfg.in
Index: lit/Suite/lit.site.cfg.in
=
EugeneBi updated this revision to Diff 161520.
EugeneBi added a comment.
Mark added the test. Please let us know if this is OK.
https://reviews.llvm.org/D49685
Files:
packages/Python/lldbsuite/test/functionalities/postmortem/elf-core/TestLinuxCore.py
source/Target/Platform.cpp
Index: sour
clayborg added a comment.
You can always run a.out through obj2yaml and check that in. There is test
suite support for using a yaml file that converts it to a binary and debugs it
functionalities/gdb_remote_client/gdbclientutils.py
429:def createTarget(self, yaml_path):
431:Cre
EugeneBi added a comment.
In https://reviews.llvm.org/D49685#1201351, @magardne wrote:
> @labath Eugene asked me to help add a unit test for this. I have the updated
> diff, but I can't seem to attach it to this code review -- it must be because
> I'm not the original author? I'll attach the di
This revision was automatically updated to reflect the committed changes.
Closed by commit rL340179: Remove manual byte counting from Opcode::Dump
(authored by teemperor, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D50677?vs=160484&
Author: teemperor
Date: Mon Aug 20 08:51:14 2018
New Revision: 340179
URL: http://llvm.org/viewvc/llvm-project?rev=340179&view=rev
Log:
Remove manual byte counting from Opcode::Dump
Summary:
Stream now has byte-counting functionality, so let's use this instead of manual
byte
counting.
Reviewers
Author: stefan.graenitz
Date: Mon Aug 20 05:37:54 2018
New Revision: 340168
URL: http://llvm.org/viewvc/llvm-project?rev=340168&view=rev
Log:
Fix lit.cfg for python3: can only concatenate str (not "bytes") to str
Modified:
lldb/trunk/lit/lit.cfg
Modified: lldb/trunk/lit/lit.cfg
URL:
http://
Oh, yeah, indeed (and probably crafting a binary with yaml2obj or
llvm-mc which triggers this reloc should be trivial [you might
consider taking a look at the tests in lld/ELF as probably have tons
of similar examples).
On Mon, Aug 20, 2018 at 12:34 PM Pavel Labath via lldb-commits
wrote:
>
> On 2
On 20/08/18 08:17, Davide Italiano via lldb-commits wrote:
> On Fri, Aug 17, 2018 at 2:36 AM Stephane Sezer via lldb-commits
> wrote:
>>
>> Author: sas
>> Date: Thu Aug 16 17:35:47 2018
>> New Revision: 339974
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=339974&view=rev
>> Log:
>> Add a relo
16 matches
Mail list logo