EugeneBi added a comment. In https://reviews.llvm.org/D49685#1201351, @magardne wrote:
> @labath Eugene asked me to help add a unit test for this. I have the updated > diff, but I can't seem to attach it to this code review -- it must be because > I'm not the original author? I'll attach the diff to this comment and maybe > you can try to update the review. Otherwise we can wait until Eugene gets > back on Monday. > > The diff makes the following changes: > > - Add an executable: > test/testcases/functionalities/postmortem/elf-core/mock_sysroot/home/labath/test/a.out > - This is a copy of linux-i386.out (which is why it's in > mock_sysroot/home/labath...). Let me know if this is ok, or if I should try > to create a new binary/core > - Implement the test you suggested: set platform and sysroot, open the core, > check threads/stacks are valid > > I verified that the test fails without the changes to Platform.cpp and > passes after the changes. > > F6945416: sysroot_cr.diff <https://reviews.llvm.org/F6945416> Mark, thanks a lot for doing this. I have one request though: let's not add new binaries to the repo. Instead, the test should create a temporary directory somewhere (in /tmp, I guess) and copy necessary files there. After the test is done, wipe it out. https://reviews.llvm.org/D49685 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
