[Lldb-commits] [lldb] r333863 - Python: adjust the include directories

Author: compnerd Date: Sun Jun 3 19:08:12 2018 New Revision: 333863 URL: http://llvm.org/viewvc/llvm-project?rev=333863&view=rev Log: Python: adjust the include directories Restructure the include search order to adjust for libedit. This ensures that the variables are not unused if they are not

[Lldb-commits] [PATCH] D46726: build: use cmake to find the libedit content

compnerd added inline comments. Comment at: scripts/Python/modules/readline/CMakeLists.txt:11 + PRIVATE + ${libedit_INCLUDE_DIRS}) if (NOT LLDB_DISABLE_LIBEDIT) lonico77 wrote: > Should this be under if (NOT

[Lldb-commits] [PATCH] D46726: build: use cmake to find the libedit content

lonico77 added inline comments. Comment at: scripts/Python/modules/readline/CMakeLists.txt:11 + PRIVATE + ${libedit_INCLUDE_DIRS}) if (NOT LLDB_DISABLE_LIBEDIT) Should this be under if (NOT LLDB_DISABLE_LIBE

[Lldb-commits] [PATCH] D47302: [lldb, lldb-mi] Add method AddCurrentTargetSharedObjectPath to the SBDebugger.

polyakov.alex added a comment. Do you know another way of implementing AppendImageSearchPaths method? Repository: rL LLVM https://reviews.llvm.org/D47302 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mail

[Lldb-commits] [PATCH] D47679: [lldb, lldb-mi] Enable lldb-mi -break-insert test on Windows.

polyakov.alex added a comment. Thank you. https://reviews.llvm.org/D47679 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D47678: [lldb, lldm-mi] Fix hanging of -exec-run command.

This revision was automatically updated to reflect the committed changes. Closed by commit rL333844: [lldb, lldm-mi] Fix hanging of -exec-run command. (authored by apolyakov, committed by ). Changed prior to commit: https://reviews.llvm.org/D47678?vs=149626&id=149641#toc Repository: rL LLVM

[Lldb-commits] [lldb] r333844 - [lldb, lldm-mi] Fix hanging of -exec-run command.

Author: apolyakov Date: Sun Jun 3 08:15:23 2018 New Revision: 333844 URL: http://llvm.org/viewvc/llvm-project?rev=333844&view=rev Log: [lldb, lldm-mi] Fix hanging of -exec-run command. Summary: -exec-run command hanged in case of invalid or dummy target. Reviewers: aprantl, stella.stamenova Re

[Lldb-commits] [PATCH] D47679: [lldb, lldb-mi] Enable lldb-mi -break-insert test on Windows.

stella.stamenova added a comment. In https://reviews.llvm.org/D47679#1120177, @polyakov.alex wrote: > In https://reviews.llvm.org/D47679#1120172, @stella.stamenova wrote: > > > In https://reviews.llvm.org/D47679#1120081, @polyakov.alex wrote: > > > > > Due to https://reviews.llvm.org/D47678 we ca

[Lldb-commits] [PATCH] D47679: [lldb, lldb-mi] Enable lldb-mi -break-insert test on Windows.

polyakov.alex added a comment. In https://reviews.llvm.org/D47679#1120172, @stella.stamenova wrote: > In https://reviews.llvm.org/D47679#1120081, @polyakov.alex wrote: > > > Due to https://reviews.llvm.org/D47678 we can enable this test with a XFAIL > > directive for Windows. > > > Not true. As

[Lldb-commits] [PATCH] D47679: [lldb, lldb-mi] Enable lldb-mi -break-insert test on Windows.

stella.stamenova added a comment. In https://reviews.llvm.org/D47679#1120081, @polyakov.alex wrote: > Due to https://reviews.llvm.org/D47678 we can enable this test with a XFAIL > directive for Windows. Not true. As I said, the original review when I disabled the test has the log of what happ

[Lldb-commits] [PATCH] D47679: [lldb, lldb-mi] Enable lldb-mi -break-insert test on Windows.

aprantl added inline comments. Comment at: lit/tools/lldb-mi/breakpoint/break-insert.test:1 -# REQUIRES: nowindows +# XFAIL: windows # -> llvm.org/pr24452 aprantl wrote: > Do we still expect the test to fail after this change? Nevermind.. phabricator folded your

[Lldb-commits] [PATCH] D47679: [lldb, lldb-mi] Enable lldb-mi -break-insert test on Windows.

aprantl added a comment. Stella, is there a public bot that runs the tests on Windows that we could watch? I found http://lab.llvm.org:8011/builders/lldb-x86-windows-msvc2015?numbuilds=1000 but it doesn't look like that one actually failed with the error you saw. Comment at:

[Lldb-commits] [PATCH] D47678: [lldb, lldm-mi] Fix hanging of -exec-run command.

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. thanks. https://reviews.llvm.org/D47678 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

[Lldb-commits] [PATCH] D47679: [lldb, lldb-mi] Enable lldb-mi -break-insert test on Windows.

polyakov.alex added a comment. In https://reviews.llvm.org/D47679#1120039, @stella.stamenova wrote: > You can actually follow the pattern in the other tests and do: > > %cc -o %t %p/inputs/break-insert.c -g > > %t then becomes the name of the output file and you can use that in our other > com

[Lldb-commits] [PATCH] D47679: [lldb, lldb-mi] Enable lldb-mi -break-insert test on Windows.

polyakov.alex updated this revision to Diff 149629. polyakov.alex added a comment. Due to https://reviews.llvm.org/D47678 we can enable this test with a XFAIL directive for Windows. https://reviews.llvm.org/D47679 Files: lit/tools/lldb-mi/breakpoint/break-insert.test Index: lit/tools/lldb-

[Lldb-commits] [PATCH] D47678: [lldb, lldm-mi] Fix hanging of -exec-run command.

polyakov.alex updated this revision to Diff 149626. polyakov.alex added a comment. Added the test. https://reviews.llvm.org/D47678 Files: lit/tools/lldb-mi/exec/exec-run-wrong-binary.test lit/tools/lldb-mi/exec/lit.local.cfg tools/lldb-mi/MICmdCmdExec.cpp Index: tools/lldb-mi/MICmdCmdEx