compnerd added inline comments.
================
Comment at: scripts/Python/modules/readline/CMakeLists.txt:11
+ PRIVATE
+ ${libedit_INCLUDE_DIRS})
if (NOT LLDB_DISABLE_LIBEDIT)
----------------
lonico77 wrote:
> Should this be under if (NOT LLDB_DISABLE_LIBEDIT) ?
>
> I'm seeing
> CMake Error: The following variables are used in this project, but they are
> set to NOTFOUND.
> Please set them or make sure they are set and tested correctly in the CMake
> files:
> /x/eng/rtpbld01/scratch/laurentn/llvm-wss/sources/llvm_import_from_git_rtp3/llvm/tools/lldb/scripts/Python/modules/readline/libedit_INCLUDE_DIRS
>
> used as include directory in directory
> /x/eng/rtpbld01/scratch/laurentn/llvm-wss/sources/llvm_import_from_git_rtp3/llvm/tools/lldb/scripts/Python/modules/readline
>
Yeah, it should be under the condition. I'll patch that soon.
https://reviews.llvm.org/D46726
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
