[Lldb-commits] [PATCH] D44056: [lldb] Fix "code unreachable" warning in HostThreadPosix::Cancel

xiaobai added inline comments. Comment at: source/Host/posix/HostThreadPosix.cpp:44 if (IsJoinable()) { #ifndef __ANDROID__ #ifndef __FreeBSD__ labath wrote: > xiaobai wrote: > > aprantl wrote: > > > What about: > > > ``` > > > #ifdef __ANDROID__ > > > e

[Lldb-commits] [PATCH] D44056: [lldb] Fix "code unreachable" warning in HostThreadPosix::Cancel

krytarowski added a comment. `::pthread_cancel` is available for NetBSD as well. https://reviews.llvm.org/D44056 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D44056: [lldb] Fix "code unreachable" warning in HostThreadPosix::Cancel

labath added inline comments. Comment at: source/Host/posix/HostThreadPosix.cpp:44 if (IsJoinable()) { #ifndef __ANDROID__ #ifndef __FreeBSD__ xiaobai wrote: > aprantl wrote: > > What about: > > ``` > > #ifdef __ANDROID__ > > error.SetErrorString("HostTh

[Lldb-commits] [PATCH] D44056: [lldb] Fix "code unreachable" warning in HostThreadPosix::Cancel

xiaobai added inline comments. Comment at: source/Host/posix/HostThreadPosix.cpp:44 if (IsJoinable()) { #ifndef __ANDROID__ #ifndef __FreeBSD__ aprantl wrote: > What about: > ``` > #ifdef __ANDROID__ > error.SetErrorString("HostThreadPosix::Cancel() not

[Lldb-commits] [PATCH] D44060: [lldb] Fix "code requires global destructor" warning in g_architecture_mutex

kubamracek created this revision. kubamracek added reviewers: jingham, jasonmolenda, davide, aprantl. https://reviews.llvm.org/D44060 Files: source/Core/PluginManager.cpp Index: source/Core/PluginManager.cpp === --- source/Core/P

[Lldb-commits] [PATCH] D44058: [lldb] Fix "code unreachable" warning in DNBArchImplX86_64::SetRegisterValue

kubamracek created this revision. kubamracek added reviewers: jingham, jasonmolenda, aprantl, davide. Looks like an actual bug and a result of a bag merge. https://reviews.llvm.org/D44058 Files: tools/debugserver/source/MacOSX/x86_64/DNBArchImplX86_64.cpp Index: tools/debugserver/source/Mac

[Lldb-commits] [PATCH] D44056: [lldb] Fix "code unreachable" warning in HostThreadPosix::Cancel

aprantl added inline comments. Comment at: source/Host/posix/HostThreadPosix.cpp:44 if (IsJoinable()) { #ifndef __ANDROID__ #ifndef __FreeBSD__ What about: ``` #ifdef __ANDROID__ error.SetErrorString("HostThreadPosix::Cancel() not supported on Android");

[Lldb-commits] [PATCH] D44055: [lldb] Fix "requires global constructor" warning in g_range_specifiers

labath added inline comments. Comment at: source/Breakpoint/BreakpointID.cpp:49 llvm::ArrayRef BreakpointID::GetRangeSpecifiers() { + static llvm::StringRef g_range_specifiers[] = {"-", "to", "To", "TO"}; return llvm::makeArrayRef(g_range_specifiers); You ca

[Lldb-commits] [PATCH] D44056: [lldb] Fix "code unreachable" warning in HostThreadPosix::Cancel

kubamracek created this revision. kubamracek added reviewers: davide, jasonmolenda, jingham, aprantl. https://reviews.llvm.org/D44056 Files: source/Host/posix/HostThreadPosix.cpp Index: source/Host/posix/HostThreadPosix.cpp === -

[Lldb-commits] [PATCH] D42955: Make Module::GetSectionList output consistent

labath added a comment. In https://reviews.llvm.org/D42955#1026216, @clayborg wrote: > AS for the ELF example where only debug info is around, it might not be > running into issues if it doesn't contain a symbol table. If it does contain > a symbol table, hopefully it is using the unified secti

[Lldb-commits] [PATCH] D44055: [lldb] Fix "requires global constructor" warning in g_range_specifiers

kubamracek created this revision. kubamracek added reviewers: jingham, davide, jasonmolenda, aprantl. https://reviews.llvm.org/D44055 Files: source/Breakpoint/BreakpointID.cpp Index: source/Breakpoint/BreakpointID.cpp === --- sou

[Lldb-commits] [lldb] r326640 - Mark ObjC testcase as skipUnlessDarwin and fix a typo in test function.

Author: adrian Date: Fri Mar 2 15:57:09 2018 New Revision: 326640 URL: http://llvm.org/viewvc/llvm-project?rev=326640&view=rev Log: Mark ObjC testcase as skipUnlessDarwin and fix a typo in test function. Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/objc/modules-cache/TestClangMo

[Lldb-commits] [PATCH] D42955: Make Module::GetSectionList output consistent

clayborg added a comment. AS for the ELF example where only debug info is around, it might not be running into issues if it doesn't contain a symbol table. If it does contain a symbol table, hopefully it is using the unified section table, otherwise if might have symbol's whose addresses have s

[Lldb-commits] [PATCH] D42955: Make Module::GetSectionList output consistent

clayborg added a comment. In https://reviews.llvm.org/D42955#1026197, @labath wrote: > In https://reviews.llvm.org/D42955#1026175, @clayborg wrote: > > > The dSYM file is a mach-o file that contains symbols only, It is because > > the dSYM file (stand alone debug info file) has all of the sectio

Re: [Lldb-commits] [lldb] r326634 - Don't compile testcase with clang modules enabled.

That didn't seem to do the trick: TBH, I'd be surprised if you can pull off compiling a fully working objc executable on linux. On 2 March 2018 at 15:15, Adrian Prantl via lldb-commits wrote: > Author: adrian > Date:

[Lldb-commits] [PATCH] D42955: Make Module::GetSectionList output consistent

labath added a comment. In https://reviews.llvm.org/D42955#1026175, @clayborg wrote: > The dSYM file is a mach-o file that contains symbols only, It is because the > dSYM file (stand alone debug info file) has all of the section definitions > from the main executable, but no section content for

[Lldb-commits] [PATCH] D42955: Make Module::GetSectionList output consistent

clayborg added a comment. In https://reviews.llvm.org/D42955#1026116, @labath wrote: > I can try to split the patch up a bit if you think it will make things > easier. I'm not sure how much I will be able to do that, as the patch is not > that big, it just needs to touch a bunch of files for t

[Lldb-commits] [lldb] r326634 - Don't compile testcase with clang modules enabled.

Author: adrian Date: Fri Mar 2 15:15:04 2018 New Revision: 326634 URL: http://llvm.org/viewvc/llvm-project?rev=326634&view=rev Log: Don't compile testcase with clang modules enabled. It isn't actually necessary for what we are testing here and should fix the test on the Linux bots. Modified:

[Lldb-commits] [PATCH] D42955: Make Module::GetSectionList output consistent

labath added a comment. I can try to split the patch up a bit if you think it will make things easier. I'm not sure how much I will be able to do that, as the patch is not that big, it just needs to touch a bunch of files for the changed interfaces. In https://reviews.llvm.org/D42955#1026061,

[Lldb-commits] [PATCH] D43984: Make the clang module cache setting available without a target

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL326628: Make the clang module cache setting available without a target (authored by adrian, committed by ). Herald added a

[Lldb-commits] [lldb] r326628 - Make the clang module cache setting available without a target

Author: adrian Date: Fri Mar 2 14:42:44 2018 New Revision: 326628 URL: http://llvm.org/viewvc/llvm-project?rev=326628&view=rev Log: Make the clang module cache setting available without a target It turns out that setting the clang module cache after LLDB has a Target can be too late. In particul

[Lldb-commits] [PATCH] D44042: Ensure that trailing characters aren't included in PECOFF section names

clayborg added a comment. Will we have the same problem with coff_symbol? https://reviews.llvm.org/D44042 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D44042: Ensure that trailing characters aren't included in PECOFF section names

clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed. Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:511 + // necessarily null-terminated + sect_name = std::string(sect.name, sizeof(sect.na

[Lldb-commits] [PATCH] D44042: Ensure that trailing characters aren't included in PECOFF section names

clayborg added a comment. Add test as well. https://reviews.llvm.org/D44042 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D42955: Make Module::GetSectionList output consistent

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks fine, a bit hard to tell exactly what is going on so I will accept as long as the following things are still true: - each lldb_private::ObjectFile has its own section list that perfe

[Lldb-commits] [PATCH] D44042: Ensure that trailing characters aren't included in PECOFF section names

zturner added a comment. Just compile something with /Z7 and you'll get a section called `.debug$S` in the object file, which is exactly 8 characters. Then teach lldb-test to dump an object file's sections. https://reviews.llvm.org/D44042 ___ lld

[Lldb-commits] [PATCH] D44042: Ensure that trailing characters aren't included in PECOFF section names

labath added a comment. Is it possible to test this? Is it possible to make yaml2obj generate a file that would trigger this? https://reviews.llvm.org/D44042 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

[Lldb-commits] [PATCH] D42955: Make Module::GetSectionList output consistent

labath requested review of this revision. labath added a comment. Explicitly requesting re-review to make sure this is on your radar. We have a new patch that would benefit from this, but if this is not ready to go in yet (it's a turned into a fairly big refact

[Lldb-commits] [PATCH] D44041: Only replace object file sections when non-empty

labath requested changes to this revision. labath added a comment. This revision now requires changes to proceed. This looks like a perfect case for lldb-test. You will run into a couple of problems which will prevent this from working out of the box. I tried to fix those in https://reviews.llvm

[Lldb-commits] [PATCH] D44042: Ensure that trailing characters aren't included in PECOFF section names

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. good catch https://reviews.llvm.org/D44042 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

[Lldb-commits] [PATCH] D44042: Ensure that trailing characters aren't included in PECOFF section names

fjricci created this revision. fjricci added reviewers: clayborg, zturner, wallace. If a section name is exactly 8 characters (the maximum section name length), and the next item in the section header struct contains a non-zero value, we would append garbage data to the end of the section name str

[Lldb-commits] [PATCH] D44041: Only replace object file sections when non-empty

fjricci created this revision. fjricci added reviewers: clayborg, zturner, labath. Herald added subscribers: JDevlieghere, arichardson, emaste. In order to allow some sections to exist either in split debug-info or in the main binary, don't replace non-empty sections with empty sections. https:

Re: [Lldb-commits] [lldb] r326552 - [testsuite] Remove workaround for categories and inline tests.

Thanks for taking care of this! vedant > On Mar 2, 2018, at 2:38 AM, Jonas Devlieghere via lldb-commits > wrote: > > Author: jdevlieghere > Date: Fri Mar 2 02:38:11 2018 > New Revision: 326552 > > URL: http://llvm.org/viewvc/llvm-project?rev=326552&view=rev > Log: > [testsuite] Remove workar

[Lldb-commits] [PATCH] D43984: Make the clang module cache setting available without a target

aprantl updated this revision to Diff 136803. aprantl added a comment. Added a testcase. https://reviews.llvm.org/D43984 Files: include/lldb/Core/ModuleList.h include/lldb/Target/Target.h packages/Python/lldbsuite/test/lang/objc/modules-cache/Makefile packages/Python/lldbsuite/test/lan

[Lldb-commits] [PATCH] D43912: [Symbol] Add InvalidTypeError, a force-checked recoverable error

labath added a comment. Thanks. The logging stuff looks good to me. I know very little about the TypeFromUser class and friends, so someone else should probably ack that. https://reviews.llvm.org/D43912 ___ lldb-commits mailing list lldb-commits@li

[Lldb-commits] [PATCH] D44015: Fix std unique pointer not printing.

alexandreyy created this revision. alexandreyy added reviewers: labath, clayborg. Std unique pointers were not being printed. The unique pointer layout was changed in libstdc++ 6.0.23. https://reviews.llvm.org/D44015 Files: source/Plugins/Language/CPlusPlus/LibStdcppUniquePointer.cpp Index

[Lldb-commits] [lldb] r326552 - [testsuite] Remove workaround for categories and inline tests.

Author: jdevlieghere Date: Fri Mar 2 02:38:11 2018 New Revision: 326552 URL: http://llvm.org/viewvc/llvm-project?rev=326552&view=rev Log: [testsuite] Remove workaround for categories and inline tests. Adding categories to inline tests does not work because the attribute is set at the function le