[Lldb-commits] [PATCH] D44058: [lldb] Fix "code unreachable" warning in DNBArchImplX86_64::SetRegisterValue

[Kuba (Brecka) Mracek via Phabricator via lldb-commits]

kubamracek created this revision.
kubamracek added reviewers: jingham, jasonmolenda, aprantl, davide.

Looks like an actual bug and a result of a bag merge.


https://reviews.llvm.org/D44058

Files:
  tools/debugserver/source/MacOSX/x86_64/DNBArchImplX86_64.cpp


Index: tools/debugserver/source/MacOSX/x86_64/DNBArchImplX86_64.cpp
===================================================================
--- tools/debugserver/source/MacOSX/x86_64/DNBArchImplX86_64.cpp
+++ tools/debugserver/source/MacOSX/x86_64/DNBArchImplX86_64.cpp
@@ -1917,9 +1917,9 @@
         success = true;
       }
       break;
+    case e_regSetFPU:
       if (reg > fpu_xmm15 && !(CPUHasAVX() || FORCE_AVX_REGS))
         return false;
-    case e_regSetFPU:
       switch (reg) {
       case fpu_fcw:
         *((uint16_t *)(&m_state.context.fpu.no_avx.__fpu_fcw)) =



Index: tools/debugserver/source/MacOSX/x86_64/DNBArchImplX86_64.cpp
===================================================================
--- tools/debugserver/source/MacOSX/x86_64/DNBArchImplX86_64.cpp
+++ tools/debugserver/source/MacOSX/x86_64/DNBArchImplX86_64.cpp
@@ -1917,9 +1917,9 @@
         success = true;
       }
       break;
+    case e_regSetFPU:
       if (reg > fpu_xmm15 && !(CPUHasAVX() || FORCE_AVX_REGS))
         return false;
-    case e_regSetFPU:
       switch (reg) {
       case fpu_fcw:
         *((uint16_t *)(&m_state.context.fpu.no_avx.__fpu_fcw)) =

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits