clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed.
================ Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:511 + // necessarily null-terminated + sect_name = std::string(sect.name, sizeof(sect.name)); return true; ---------------- This is storing any extra NULL characters in sect_name. Might be better to do: ``` sect_name = std::string(sect.name, strnlen(sect.name, sizeof(sect.name))); ``` https://reviews.llvm.org/D44042 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
