aprantl added a comment.
I am now working on building each test variant (dwarf,dwo,dsym,...) in its own
build directory so they can run in parallel and we can get rid of the lockfile.
While doing this I discovered that certain tests (e.g.,
TestPublicAPIHeaders.py, the MI tests) are invoking bui
aprantl added inline comments.
Comment at:
packages/Python/lldbsuite/test/api/check_public_api_headers/TestPublicAPIHeaders.py:46
self.line_to_break = line_number(
-self.source, '// Set breakpoint here.')
+self.getBuildArtifact(self.source), '//
Author: davide
Date: Fri Jan 26 13:46:10 2018
New Revision: 323566
URL: http://llvm.org/viewvc/llvm-project?rev=323566&view=rev
Log:
[lldbtestsuite] Don't crash on `None` input for is_exe().
Now the function returns `False`, and the caller can take the
appropriate action (in this case, for --exec
alexshap added inline comments.
Comment at: source/Plugins/SymbolFile/DWARF/DIERef.cpp:67-68
+ lldb_private::ArchSpec arch;
+ if (dwarf->GetObjectFile()->GetArchitecture(arch) &&
+ arch.GetTriple().isOSBinFormatELF()) {
+// For SymbolFileDWARFDwo/SymbolFileDWARFDwoDwp
clayborg added inline comments.
Comment at: source/Plugins/SymbolFile/DWARF/DIERef.cpp:67-68
+ lldb_private::ArchSpec arch;
+ if (dwarf->GetObjectFile()->GetArchitecture(arch) &&
+ arch.GetTriple().isOSBinFormatELF()) {
+// For SymbolFileDWARFDwo/SymbolFileDWARFDwoDwp
jingham added a comment.
The xcode build uses cmake to build llvm & clang. It passes a build flavor, by
passing -DCMAKE_BUILD_TYPE=Debug for instance, but other than that it lets the
llvm build figure out how to lay itself out.
Moreover, there are a bunch of defines that lldb sets up to find i
alexshap added a comment.
@tberghammer
> ELF specific as nothing really ties SymbolFileDWARF with the ELF format
the only reason why it's currently guarded to ELF is the fact that
for Mach-O uuid also encodes something and i didn't want to change that (see
the comment in the old version of the
Author: labath
Date: Fri Jan 26 08:05:46 2018
New Revision: 323537
URL: http://llvm.org/viewvc/llvm-project?rev=323537&view=rev
Log:
gmodules XFAIL two more tests that only fail for android (pr36109)
Modified:
lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-form
labath added inline comments.
Comment at: packages/Python/lldbsuite/test/lldbtest.py:1588
paths_to_try = [
"llvm-build/Release+Asserts/x86_64/Release+Asserts/bin/clang",
"llvm-build/Debug+Asserts/x86_64/Debug+Asserts/bin/clang",
tberghammer added a comment.
Sorry, I misunderstood your test-case in my first comment so what I wrote there
doesn't make sense. When you are trying to debug binaries (executable or shared
library) where half of it is compiled with split-dwarf while the other half is
compiled with non-split-dwa
Author: labath
Date: Fri Jan 26 03:40:59 2018
New Revision: 323520
URL: http://llvm.org/viewvc/llvm-project?rev=323520&view=rev
Log:
Fix linux fallout from c++ gmodules enable
TestLibcxxListLoop - fails because the evil "define private public"
trick does not work with gmodules. The purpose of t
tberghammer requested changes to this revision.
tberghammer added a comment.
Who is calling this method with a SimbolFileDWARF?
Instead of adding a hack to this function what looks horrible to me considering
that different debug info formats are using the upper 32bit of the UID for
different pu
labath added a comment.
I've created https://reviews.llvm.org/D42572 with the fixups necessary to make
this run on linux. It's way smaller than I expected we would need -- I
basically fixed one typo and corrected for some shared library weirdness. Can
you apply that on top of your CL?
I'll try
13 matches
Mail list logo
