[Lldb-commits] [PATCH] D42563: [lldb] attempt to fix DIERef::GetUID

[Greg Clayton via Phabricator via lldb-commits]

clayborg added inline comments.


================
Comment at: source/Plugins/SymbolFile/DWARF/DIERef.cpp:67-68
+  lldb_private::ArchSpec arch;
+  if (dwarf->GetObjectFile()->GetArchitecture(arch) &&
+      arch.GetTriple().isOSBinFormatELF()) {
+    // For SymbolFileDWARFDwo/SymbolFileDWARFDwoDwp
----------------
Why do this arch check? check? Why not just get rely on 
dwarf->GetBaseCompileUnit()? Seem like we are doing more work than needed.


Repository:
  rL LLVM

https://reviews.llvm.org/D42563



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits