[Lldb-commits] [PATCH] D35083: [TypeSystem] Guard the global `ASTSourceMap` with a mutex

jingham added a comment. This is an awfully complex solution which in the end doesn't actually enforce that you take the lock to get the SourceMap. You have to know to wrap the access in this WithExclusiveSourceMap. Wouldn't it be simpler to make GetSourceMap take a reference to a std::unique

[Lldb-commits] [PATCH] D35083: [TypeSystem] Guard the global `ASTSourceMap` with a mutex

lhames added inline comments. Comment at: source/Symbol/ClangExternalASTSourceCommon.cpp:24 +template +static decltype(std::declval()(std::declval())) +WithExclusiveSourceMap(FnType fn) { Does std::result_of::type work as the return type? http://en.cppreference

[Lldb-commits] [lldb] r307335 - Fix Xcode project file for gtest schemes.

Author: penryu Date: Thu Jul 6 16:25:35 2017 New Revision: 307335 URL: http://llvm.org/viewvc/llvm-project?rev=307335&view=rev Log: Fix Xcode project file for gtest schemes. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL: http:

[Lldb-commits] [PATCH] D35065: [LLDB][ppc64le] Rename enums in AuxVector

joerg added inline comments. Comment at: source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.cpp:115 _type: \ name = #_type switch (type) { krytarowski wrote: > brunoalr wrote: > > joer

[Lldb-commits] [PATCH] D35065: [LLDB][ppc64le] Rename enums in AuxVector

krytarowski added inline comments. Comment at: source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.cpp:115 _type: \ name = #_type switch (type) { brunoalr wrote: > joerg wrote: > > laba

[Lldb-commits] [PATCH] D35065: [LLDB][ppc64le] Rename enums in AuxVector

brunoalr added inline comments. Comment at: source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.cpp:115 _type: \ name = #_type switch (type) { joerg wrote: > labath wrote: > > If we go

[Lldb-commits] [PATCH] D35065: [LLDB][ppc64le] Rename enums in AuxVector

brunoalr added inline comments. Comment at: source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.h:46 + /// Added AUXV prefix because some targets already define names such as + /// AT_DCACHEBSIZE in system headers enum EntryType { joerg wrote: > I think most t

[Lldb-commits] [PATCH] D35065: [LLDB][ppc64le] Rename enums in AuxVector

joerg added inline comments. Comment at: source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.cpp:115 _type: \ name = #_type switch (type) { labath wrote: > If we go about renaming them,

[Lldb-commits] [lldb] r307320 - Change remaining references to lit.util.capture to use subprocess.check_output.

Author: dlj Date: Thu Jul 6 14:46:47 2017 New Revision: 307320 URL: http://llvm.org/viewvc/llvm-project?rev=307320&view=rev Log: Change remaining references to lit.util.capture to use subprocess.check_output. Summary: The capture() function was removed in r306625. This should fix PGO breakages r

[Lldb-commits] [PATCH] D35065: [LLDB][ppc64le] Rename enums in AuxVector

brunoalr updated this revision to Diff 105517. brunoalr added a comment. Add comments https://reviews.llvm.org/D35065 Files: source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.cpp source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.h source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIX

[Lldb-commits] [PATCH] D35083: [TypeSystem] Guard the global `ASTSourceMap` with a mutex

spyffe created this revision. `s_source_map` in `ClangExternalASTSourceCommon.cpp` is unguarded and therefore can break in multithreaded conditions. This can cause crashes in particular if multiple targets are being set up at once. This patch wraps `s_source_map` in a function that ensures exc

[Lldb-commits] [PATCH] D35065: [LLDB][ppc64le] Rename enums in AuxVector

brunoalr updated this revision to Diff 105515. brunoalr added a comment. Fixing replace mistake. https://reviews.llvm.org/D35065 Files: source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.cpp source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.h source/Plugins/DynamicLoader/POSIX-DYLD/Dynamic

[Lldb-commits] [PATCH] D35065: [LLDB][ppc64le] Rename enums in AuxVector

brunoalr updated this revision to Diff 105514. brunoalr added a comment. Renaming enum consistently and updating name ENTRY_NAME macro to correctly assign the standard names of aux vector entries. https://reviews.llvm.org/D35065 Files: source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.cpp s

[Lldb-commits] [lldb] r307287 - Working through testcases, converting to run_to_source_breakpoint.

Author: jingham Date: Thu Jul 6 11:06:25 2017 New Revision: 307287 URL: http://llvm.org/viewvc/llvm-project?rev=307287&view=rev Log: Working through testcases, converting to run_to_source_breakpoint. Modified: lldb/trunk/packages/Python/lldbsuite/test/expression_command/issue_11588/Test1158

[Lldb-commits] [PATCH] D35065: [LLDB][ppc64le] Rename enums in AuxVector

brunoalr marked 2 inline comments as done. brunoalr added a comment. In https://reviews.llvm.org/D35065#800906, @joerg wrote: > If you want to go this way, rename them consistently and use a different > prefix (e.g. AUXV_*) please. Wiil do. https://reviews.llvm.org/D35065

[Lldb-commits] [PATCH] D35065: [LLDB][ppc64le] Rename enums in AuxVector

brunoalr marked an inline comment as done. brunoalr added inline comments. Comment at: source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.cpp:11 // C Includes #include #include labath wrote: > Do you still get the error if you remove these includes? > > As f

[Lldb-commits] [PATCH] D35065: [LLDB][ppc64le] Rename enums in AuxVector

brunoalr added a comment. In https://reviews.llvm.org/D35065#800877, @krytarowski wrote: > What are the build failures? [2397/3183] Building CXX object tools/lldb/source/Plugins/DynamicLoader/POSIX-DYLD/CMakeFiles/lldbPluginDynamicLoaderPosixDYLD.dir/AuxVector.cpp.o FAILED: tools/lldb/s

[Lldb-commits] [PATCH] D35065: [LLDB][ppc64le] Rename enums in AuxVector

labath added inline comments. Comment at: source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.cpp:11 // C Includes #include #include Do you still get the error if you remove these includes? As far as I can tell they are unused, and this part of the code shoul

[Lldb-commits] [PATCH] D35070: Extend DynamicLibrary class to be usable without loading permanently.

marsupial created this revision. https://reviews.llvm.org/D35070 Files: include/lldb/Core/Debugger.h include/lldb/lldb-private-types.h source/API/SBDebugger.cpp source/Core/Debugger.cpp source/Core/PluginManager.cpp Index: source/Core/PluginManager.cpp =

[Lldb-commits] [PATCH] D35065: [LLDB][ppc64le] Rename enums in AuxVector

joerg added a comment. If you want to go this way, rename them consistently and use a different prefix (e.g. AUXV_*) please. https://reviews.llvm.org/D35065 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mai

[Lldb-commits] [PATCH] D35065: [LLDB][ppc64le] Rename enums in AuxVector

krytarowski added a comment. What are the build failures? https://reviews.llvm.org/D35065 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D35065: [LLDB][ppc64le] Rename enums in AuxVector

brunoalr added a comment. In https://reviews.llvm.org/D35065#800852, @krytarowski wrote: > Values like AT_NULL are macros on NetBSD and there are no problems? I haven't tested in ppc64le on NetBSD, but I'm afraid the same problems would occur. https://reviews.llvm.org/D35065 _

[Lldb-commits] [PATCH] D35065: [LLDB][ppc64le] Rename enums in AuxVector

krytarowski added a comment. Values like AT_NULL are macros on NetBSD and there are no problems? https://reviews.llvm.org/D35065 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D35065: Rename enums in AuxVector

brunoalr added reviewers: mikesart, labath. brunoalr added a comment. Adding Code Owner (Pavel Labeth) and responsible for the relevant changes (Michael Sartain). https://reviews.llvm.org/D35065 ___ lldb-commits mailing list lldb-commits@lists.llvm

[Lldb-commits] [PATCH] D35065: Rename enums in AuxVector

brunoalr created this revision. On linux on ppc64le some of the enums in AuxVector have the same name as macros defined in the system. https://reviews.llvm.org/D35065 Files: source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.cpp source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.h source/Pl

[Lldb-commits] [PATCH] D33035: Tool for using Intel(R) Processor Trace hardware feature

abhishek.aggarwal updated this revision to Diff 105434. abhishek.aggarwal added a comment. Removed std::vector<> from public APIs https://reviews.llvm.org/D33035 Files: tools/CMakeLists.txt tools/intel-features/CMakeLists.txt tools/intel-features/README.txt tools/intel-features/cli-wrap

[Lldb-commits] [PATCH] D33035: Tool for using Intel(R) Processor Trace hardware feature

abhishek.aggarwal added a comment. In https://reviews.llvm.org/D33035#799656, @clayborg wrote: > In https://reviews.llvm.org/D33035#799404, @abhishek.aggarwal wrote: > > > In https://reviews.llvm.org/D33035#799058, @clayborg wrote: > > > > > So std::vector shouldn't be used in a public API. You s

[Lldb-commits] [lldb] r307253 - Fix a copy-paste error in r307161

Author: labath Date: Thu Jul 6 04:43:25 2017 New Revision: 307253 URL: http://llvm.org/viewvc/llvm-project?rev=307253&view=rev Log: Fix a copy-paste error in r307161 Modified: lldb/trunk/tools/lldb-server/lldb-platform.cpp Modified: lldb/trunk/tools/lldb-server/lldb-platform.cpp URL: http:

[Lldb-commits] [lldb] r307252 - Revert "Android.rules: build x86 tests with -mstackrealign"

Author: labath Date: Thu Jul 6 04:43:20 2017 New Revision: 307252 URL: http://llvm.org/viewvc/llvm-project?rev=307252&view=rev Log: Revert "Android.rules: build x86 tests with -mstackrealign" Starting with android ndk r15, clang much more tests are affected by the -mstackrealign bugl (now nearly

[Lldb-commits] [PATCH] D34945: Adding Support for Error Strings in Remote Packets

ravitheja updated this revision to Diff 105395. ravitheja added a comment. Correcting mistakes. https://reviews.llvm.org/D34945 Files: docs/lldb-gdb-remote.txt source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient

[Lldb-commits] [PATCH] D34945: Adding Support for Error Strings in Remote Packets

labath added a comment. I am generally happy with this, just a couple of things I noticed below: Comment at: source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:3329 } else { - error.SetError(response.GetError(), eErrorTypeGeneric); +error = re

[Lldb-commits] [PATCH] D34945: Adding Support for Error Strings in Remote Packets

ravitheja updated this revision to Diff 105380. ravitheja added a comment. Support for Hex encoded strings and more error checking. https://reviews.llvm.org/D34945 Files: docs/lldb-gdb-remote.txt source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp source/Plugins/Process/gdb