Author: jmolenda
Date: Thu Oct 20 21:32:08 2016
New Revision: 284799
URL: http://llvm.org/viewvc/llvm-project?rev=284799&view=rev
Log:
Guard GetEscapedHostname against a nullptr hostname.
This can happen if you debug an iOS corefile on
a mac, where PlatformPOSIX::GetHostname ends up
not providing
Author: jingham
Date: Thu Oct 20 19:06:38 2016
New Revision: 284795
URL: http://llvm.org/viewvc/llvm-project?rev=284795&view=rev
Log:
Fix a race condition between "ephemeral watchpoint disable/enable" and continue
in commands.
Also, watchpoint commands, like breakpoint commands, need to run in a
Hello everyone,
Below are some buildbot numbers for the week of 10/2/2016 - 10/8/2016.
Please see the same data in attached csv files:
The longest time each builder was red during the last week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from greed
Hello everyone,
Below are some buildbot numbers for the last week of 10/9/2016 - 10/15/2016.
Please see the same data in attached csv files:
The longest time each builder was red during the last week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from
Author: jingham
Date: Thu Oct 20 17:50:00 2016
New Revision: 284792
URL: http://llvm.org/viewvc/llvm-project?rev=284792&view=rev
Log:
Add an API to remove an action from the Process PreResumeActions.
Modified:
lldb/trunk/include/lldb/Target/Process.h
lldb/trunk/source/Target/Process.cpp
Author: jingham
Date: Thu Oct 20 17:49:06 2016
New Revision: 284791
URL: http://llvm.org/viewvc/llvm-project?rev=284791&view=rev
Log:
Remove an unnecessary and incorrect check for num locations of a breakpoint
by grubbing the break list output. If you pass a number of locations into
the run_break
Author: enrico
Date: Thu Oct 20 17:10:07 2016
New Revision: 284788
URL: http://llvm.org/viewvc/llvm-project?rev=284788&view=rev
Log:
frame.script became script.frame a while ago; fix up the docs
Modified:
lldb/trunk/www/formats.html
Modified: lldb/trunk/www/formats.html
URL:
http://llvm.org
Author: enrico
Date: Thu Oct 20 17:05:21 2016
New Revision: 284787
URL: http://llvm.org/viewvc/llvm-project?rev=284787&view=rev
Log:
This debugging message has been left in the code for years, until one day it
randomly hit on some corrupted memory
It is misleading to users in its current form, a
krytarowski added a comment.
I think it's possible to specify `-DLLVM_CONFIG:PATH` option, if that does the
job.
Repository:
rL LLVM
https://reviews.llvm.org/D25830
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/
Ah, I see, thanks. If you can make a test case that fails on ARM in the
current state of things, I would be interested in taking a look at it. We had
to do an analogous little dance for stepping from one breakpoint to another.
Probably not the same solution, but we can surely get this to work
Author: cbieneman
Date: Thu Oct 20 13:01:19 2016
New Revision: 284756
URL: http://llvm.org/viewvc/llvm-project?rev=284756&view=rev
Log:
Re-landing a cleaned up implementation of r284550
This time it should actually work. The previous implementaiton was not
getting the linker or compiler flag set
dmikulin added a comment.
I'm not familiar enough with the code yet to pick up the work on moving FreeBSD
to lldb-server. Any pointers to revision numbers, internal discussions, etc,
related to the Linux lldb-server switch? Also, if there's any unfinished
FreeBSD work, it would help me get star
labath added subscribers: krytarowski, Eugene.Zelenko.
labath added a comment.
+cc: lldb standalone users
I'll defer to @beanz on this.
Repository:
rL LLVM
https://reviews.llvm.org/D25830
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
dvlahovski created this revision.
dvlahovski added reviewers: labath, zturner.
dvlahovski added subscribers: lldb-commits, amccarth.
Herald added subscribers: modocache, mgorny, beanz.
This, like the x86_64 case, reads the register values from the minidump
file, and emits a binary buffer that is o
mgorny added a comment.
I agree. Don't introduce redundant variables when the same result can be
achieved using existing means.
(note that `find_program` makes `LLVM_CONFIG` a cache variable implicity, so
you don't need to have any explicit support for altering it)
Repository:
rL LLVM
http
emaste added a comment.
On a quick look this seems OK. I'll try to test/review in detail.
Comment at: source/Plugins/Process/FreeBSD/ProcessFreeBSD.cpp:925
+
+ // eRegisterKindDWARF -> RegsiterValue
+ std::unordered_map m_register_values;
typo here
Reposito
emaste added a comment.
In https://reviews.llvm.org/D25756#574258, @labath wrote:
> No, I'm saying someone *should*. :P
>
> Ed looked into that at some point but, I don't think get got too far with it.
> Adding @emaste, who should probably review this.
Yes, it needs to be done. Maybe now that
beanz requested changes to this revision.
beanz added a comment.
This revision now requires changes to proceed.
`LLDB_PATH_TO_LLVM_BUILD` is a swift-ism that doesn't match LLVM's CMake
conventions. In LLVM we don't pass in the path to build directories, instead we
pass in `LLVM_CONFIG` to standa
tfiala added inline comments.
Comment at: cmake/modules/LLDBStandalone.cmake:20
+ find_program(LLVM_CONFIG "llvm-config"
+HINTS ${FIND_PATHS})
if(LLVM_CONFIG)
One question here would be what happens if FIND_PATHS stays "". Does
find_program deal with an
tfiala added a comment.
(It would be good to wait for feedback from the others, though).
Repository:
rL LLVM
https://reviews.llvm.org/D25830
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rL LLVM
https://reviews.llvm.org/D25830
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284741: Minidump plugin: redesign the x86_64 register
context (authored by dvlahovski).
Changed prior to commit:
https://reviews.llvm.org/D25677?vs=75154&id=75309#toc
Repository:
rL LLVM
https://rev
Author: dvlahovski
Date: Thu Oct 20 11:01:36 2016
New Revision: 284741
URL: http://llvm.org/viewvc/llvm-project?rev=284741&view=rev
Log:
Minidump plugin: redesign the x86_64 register context
Summary:
I misunderstood the format of the register context layout.
I thought it was a dynamically changin
tberghammer updated this revision to Diff 75300.
tberghammer marked 5 inline comments as done.
https://reviews.llvm.org/D25726
Files:
packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/smart_ptr/TestDataFormatterStdSmartPtr.py
source/Plugins/Language/C
tberghammer added inline comments.
Comment at: source/Plugins/Language/CPlusPlus/LibStdcppSmartPointer.cpp:138
+return 3;
+ return UINT32_MAX;
+}
labath wrote:
> I know you just copied it, but this seems wrong (size_t can be 64-bit). Will
> this work if you
Modified:
lldb/trunk/www/python_reference/toc-lldb.formatters.cpp.gnu_libstdcpp-module.html
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/www/python_reference/toc-lldb.formatters.cpp.gnu_libstdcpp-module.html?rev=284725&r1=284724&r2=284725&view=diff
=
labath added a comment.
In https://reviews.llvm.org/D25783#574873, @zturner wrote:
> In https://reviews.llvm.org/D25783#574860, @labath wrote:
>
> > > This can happen with any number of bytes and at any time. `write`,
> > > `read`, and all other related functions will return a non-negative valu
The reason you could not see this is that the issue is specific to arm
(or any target that reports watchpoint hits *before* executing the
instruction tripping the watch). In this case, we have special logic
in the client which removes the watchpoint, does a single step, and
reinstates the watchpoin
On 19 October 2016 at 18:39, Jim Ingham wrote:
>
>> On Oct 19, 2016, at 10:38 AM, Jim Ingham via lldb-commits
>> wrote:
>>
>>
>>> On Oct 19, 2016, at 6:35 AM, Pavel Labath via lldb-commits
>>> wrote:
>>>
>>>
>>>
>>> Comment at: source/Plugins/Language/CPlusPlus/LibStdcppUnique
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284706: Fix ARM/AArch64 Step-Over watchpoint issue remove
provision for duplicate… (authored by omjavaid).
Changed prior to commit:
https://reviews.llvm.org/D25057?vs=75103&id=75272#toc
Repository:
r
Author: omjavaid
Date: Thu Oct 20 04:07:26 2016
New Revision: 284706
URL: http://llvm.org/viewvc/llvm-project?rev=284706&view=rev
Log:
Fix ARM/AArch64 Step-Over watchpoint issue remove provision for duplicate
watchpoints
This patch fixes ARM/AArch64 watchpoint bug which was taking inferior out o
31 matches
Mail list logo
