[Lldb-commits] [lldb] r284787 - This debugging message has been left in the code for years, until one day it randomly hit on some corrupted memory

[Enrico Granata via lldb-commits]

Author: enrico
Date: Thu Oct 20 17:05:21 2016
New Revision: 284787

URL: http://llvm.org/viewvc/llvm-project?rev=284787&view=rev
Log:
This debugging message has been left in the code for years, until one day it 
randomly hit on some corrupted memory

It is misleading to users in its current form, and only interesting to me - 
remove it

rdar://28812568


Modified:
    lldb/trunk/source/Plugins/Language/ObjC/NSString.cpp

Modified: lldb/trunk/source/Plugins/Language/ObjC/NSString.cpp
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Language/ObjC/NSString.cpp?rev=284787&r1=284786&r2=284787&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Language/ObjC/NSString.cpp (original)
+++ lldb/trunk/source/Plugins/Language/ObjC/NSString.cpp Thu Oct 20 17:05:21 
2016
@@ -212,8 +212,7 @@ bool lldb_private::formatters::NSStringS
     uint64_t location = valobj_addr + 2 * ptr_size;
     if (is_inline) {
       if (!has_explicit_length) {
-        stream.Printf("found new combo");
-        return true;
+        return false;
       } else
         location += ptr_size;
     } else {


_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits