tberghammer added inline comments.

================
Comment at: source/Plugins/Language/CPlusPlus/LibStdcppSmartPointer.cpp:138
+    return 3;
+  return UINT32_MAX;
+}
----------------
labath wrote:
> I know you just copied it, but this seems wrong (size_t can be 64-bit). Will 
> this work if you just return `~0`.
Actually as far as I can tell all use case of this API assumes it is a uint32_t 
and compares the return value against UINT32_MAX :(
I will just leave it as it is and then we should have a separate CL what cleans 
up the mess around it


https://reviews.llvm.org/D25726



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to