Author: jmolenda
Date: Thu May 19 19:16:14 2016
New Revision: 270162
URL: http://llvm.org/viewvc/llvm-project?rev=270162&view=rev
Log:
Some changes to prevent searching down the stack for saved register
values for the pc or return address register.
On ios with arm64 and a binary that has multiple
spyffe updated this revision to Diff 57879.
spyffe added a comment.
Added a test case,
Repository:
rL LLVM
http://reviews.llvm.org/D20395
Files:
include/lldb/Symbol/ClangASTContext.h
include/lldb/Symbol/CompilerDecl.h
include/lldb/Symbol/GoASTContext.h
include/lldb/Symbol/JavaASTCont
I can try this on Windows tomorrow
On Thu, May 19, 2016 at 11:04 AM Saleem Abdulrasool
wrote:
> compnerd added a comment.
>
> Yeah, I was thinking that once this clean up is done, we should remove the
> use of TimeValue in favor of std::chrono::duration.
>
>
> Repository:
> rL LLVM
>
> http://r
Author: jingham
Date: Thu May 19 17:22:57 2016
New Revision: 270148
URL: http://llvm.org/viewvc/llvm-project?rev=270148&view=rev
Log:
Remove a should have been deleted extra assignment to a variable.
Also fix up the formatting a bit, it looks like something was inserting
actual tabs. Replace with
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
http://reviews.llvm.org/D20312
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
sas updated this revision to Diff 57854.
sas added a comment.
No need to use `.AsCString()` on these.
http://reviews.llvm.org/D20312
Files:
source/Expression/IRExecutionUnit.cpp
Index: source/Expression/IRExecutionUnit.cpp
===
-
sas added a comment.
Ah yes, good idea not to use `AsCString()` here.
I think changing the `!=` to `==` is the right thing to do here because the bug
was introduced in r263995:
@@ -122,7 +125,7 @@ IRExecutionUnit::DisassembleFunction (Stream &stream,
for (JittedFunction &function :
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
See inlined comments.
Comment at: source/Expression/IRExecutionUnit.cpp:128
@@ -127,3 +127,3 @@
{
-if (function.m_name.AsCString() != m_name.AsCStri
Author: spyffe
Date: Thu May 19 14:23:37 2016
New Revision: 270097
URL: http://llvm.org/viewvc/llvm-project?rev=270097&view=rev
Log:
Fixed a crash if a FunctionDecl couldn't be imported.
Modified:
lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.cpp
Modified:
lldb/tru
compnerd added a comment.
Yeah, I was thinking that once this clean up is done, we should remove the use
of TimeValue in favor of std::chrono::duration.
Repository:
rL LLVM
http://reviews.llvm.org/D20436
___
lldb-commits mailing list
lldb-commit
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
We should think about converting everyone over to using
std::chrono::microseconds for any timeout parameters that are currently
"uint32_t timeout_usec". But we can do that in a future chan
labath created this revision.
labath added a reviewer: clayborg.
labath added a subscriber: lldb-commits.
Herald added subscribers: srhines, danalbert, tberghammer.
This removes the last usage of Platform plugins in lldb-server -- it was used
for launching child
processes, where it can be trivial
This revision was automatically updated to reflect the committed changes.
Closed by commit rL270065: Checkout release_38 branches of llvm and clang when
building lldb 3.8 (authored by fjricci).
Changed prior to commit:
http://reviews.llvm.org/D19608?vs=55274&id=57791#toc
Repository:
rL LLVM
Author: bryanpkc
Date: Thu May 19 08:51:20 2016
New Revision: 270062
URL: http://llvm.org/viewvc/llvm-project?rev=270062&view=rev
Log:
Avoid an assertion failure when a bit field is extracted from a value of the
same size.
Summary: One of the cases handled by ValueObjectChild::UpdateValue() uses
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
Looks good with 1 minor comment inline. Feel free to ignore/postpone it if you
want
Comment at: source/Plugins/Process/Linux/NativeProcessLinux.cpp:2072-2073
@@ -21
labath added inline comments.
Comment at: unittests/Core/ScalarTest.cpp:90
@@ +89,3 @@
+ASSERT_TRUE(s_scalar.ExtractBitfield(0, 0));
+ASSERT_EQ(0, memcmp(&a1, s_scalar.GetBytes(), sizeof(a1)));
+ASSERT_TRUE(s_scalar.ExtractBitfield(len, 0));
bryanpkc w
bryanpkc added a comment.
In http://reviews.llvm.org/D20355#434117, @labath wrote:
> Do you have commit access?
Yes I do. Thanks for your review!
Comment at: unittests/Core/ScalarTest.cpp:90
@@ +89,3 @@
+ASSERT_TRUE(s_scalar.ExtractBitfield(0, 0));
+ASSERT_EQ(0, memcm
nitesh.jain added a comment.
Let me check and get back to you.
Thanks.
http://reviews.llvm.org/D20368
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath added a subscriber: labath.
labath added a comment.
Siva and Paul are not active on LLDB any more. I don't know if they are still
keeping an eye out on this, but I think you can go ahead with this if they
don't respond. It should be fine as long as the test passes.
OTOH, if it is possibl
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Looks good. Thank you for taking the time to add the tests. Please consider the
comment below though.
Do you have commit access?
Comment at: unittests/Core/ScalarTest.cpp:90
Author: tberghammer
Date: Thu May 19 05:53:10 2016
New Revision: 270040
URL: http://llvm.org/viewvc/llvm-project?rev=270040&view=rev
Log:
Fix build after rL270009
Modified:
lldb/trunk/source/Symbol/ClangASTContext.cpp
Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp
URL:
http://llvm.o
labath requested changes to this revision.
labath added a comment.
This revision now requires changes to proceed.
This adds a lot of code duplication, which should be trivial to remove. Please
address that first.
Comment at: packages/Python/lldbsuite/test/make/Makefile.rules:16
22 matches
Mail list logo
