[Lldb-commits] [lldb] r263333 - Let's not convert from UINT32_MAX to the std::numeric_limits version.

2016-03-11 Thread Jim Ingham via lldb-commits
Author: jingham Date: Fri Mar 11 21:33:36 2016 New Revision: 26 URL: http://llvm.org/viewvc/llvm-project?rev=26&view=rev Log: Let's not convert from UINT32_MAX to the std::numeric_limits version. Modified: lldb/trunk/source/Core/DataEncoder.cpp lldb/trunk/source/Core/Disassembler.

[Lldb-commits] [lldb] r263326 - This change introduces a "ExpressionExecutionThread" to the ThreadList.

2016-03-11 Thread Jim Ingham via lldb-commits
Author: jingham Date: Fri Mar 11 20:45:34 2016 New Revision: 263326 URL: http://llvm.org/viewvc/llvm-project?rev=263326&view=rev Log: This change introduces a "ExpressionExecutionThread" to the ThreadList. Turns out that most of the code that runs expressions (e.g. the ObjC runtime grubber) on

Re: [Lldb-commits] [lldb] r263312 - Fix Clang-tidy modernize-use-nullptr warnings in some files in source/Core; other minor fixes.

2016-03-11 Thread Jim Ingham via lldb-commits
We use UINT32_MAX and so forth all over in lldb. Were you planning to switch over all the uses? That seem like something you should not do unilaterally, but we should decide on as a group. I originally thought maybe this would buy us some type safety, but it looks like (and the docs seem to i

[Lldb-commits] [lldb] r263312 - Fix Clang-tidy modernize-use-nullptr warnings in some files in source/Core; other minor fixes.

2016-03-11 Thread Eugene Zelenko via lldb-commits
Author: eugenezelenko Date: Fri Mar 11 18:31:13 2016 New Revision: 263312 URL: http://llvm.org/viewvc/llvm-project?rev=263312&view=rev Log: Fix Clang-tidy modernize-use-nullptr warnings in some files in source/Core; other minor fixes. Modified: lldb/trunk/include/lldb/Core/SearchFilter.h

Re: [Lldb-commits] [PATCH] D17777: Add regression test for expressions calling functions taking anonymous struct typedef arguments

2016-03-11 Thread Sean Callanan via lldb-commits
spyffe accepted this revision. spyffe added a comment. This revision is now accepted and ready to land. This looks fine. Overloadable C functions are being tested separately, so this is fine to go in. http://reviews.llvm.org/D1 ___ lldb-commit

[Lldb-commits] [lldb] r263300 - Fix Clang-tidy modernize-use-nullptr warnings in some files in source/Core; other minor fixes.

2016-03-11 Thread Eugene Zelenko via lldb-commits
Author: eugenezelenko Date: Fri Mar 11 15:55:47 2016 New Revision: 263300 URL: http://llvm.org/viewvc/llvm-project?rev=263300&view=rev Log: Fix Clang-tidy modernize-use-nullptr warnings in some files in source/Core; other minor fixes. Modified: lldb/trunk/source/Core/Logging.cpp lldb/tru

[Lldb-commits] LLVM buildmaster will be restarted tonight

2016-03-11 Thread Galina Kistanova via lldb-commits
Hello everyone, LLVM buildmaster will be updated and restarted after 7 PM Pacific time today. Thanks Galina ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r263289 - Fix Clang-tidy modernize-use-nullptr warnings in some files in source/Core; other minor fixes.

2016-03-11 Thread Eugene Zelenko via lldb-commits
Author: eugenezelenko Date: Fri Mar 11 14:20:38 2016 New Revision: 263289 URL: http://llvm.org/viewvc/llvm-project?rev=263289&view=rev Log: Fix Clang-tidy modernize-use-nullptr warnings in some files in source/Core; other minor fixes. Modified: lldb/trunk/source/Core/IOHandler.cpp lldb/t

[Lldb-commits] [PATCH] D18096: accept any build-id length between 4 and 20 bytes inclusive

2016-03-11 Thread Ed Maste via lldb-commits
emaste created this revision. emaste added a reviewer: lldb-commits. There's a proposed patch D18091 adding build-id support to lld that would produce a 64-bit ID. There's some concern as existing tools typically expect the build-id to be either 16 or 20 bytes. Prior to this change lldb would r

Re: [Lldb-commits] [PATCH] D18075: Fix deadlock due to thread list locking in 'bt all' with obj-c

2016-03-11 Thread Greg Clayton via lldb-commits
clayborg accepted this revision. clayborg added a comment. Looks good. http://reviews.llvm.org/D18075 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D18075: Fix deadlock due to thread list locking in 'bt all' with obj-c

2016-03-11 Thread Jim Ingham via lldb-commits
jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. That looks good, thanks. http://reviews.llvm.org/D18075 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

Re: [Lldb-commits] [PATCH] D18075: Fix deadlock due to thread list locking in 'bt all' with obj-c

2016-03-11 Thread Francis Ricci via lldb-commits
fjricci updated this revision to Diff 50454. fjricci added a comment. Use vector of tids for iteration, rather than iterating over unlocked threadlist http://reviews.llvm.org/D18075 Files: source/Commands/CommandObjectThread.cpp Index: source/Commands/CommandObjectThread.cpp

[Lldb-commits] [lldb] r263283 - Remove the skip if Darwin since I fixed the crash.

2016-03-11 Thread Jim Ingham via lldb-commits
Author: jingham Date: Fri Mar 11 13:15:03 2016 New Revision: 263283 URL: http://llvm.org/viewvc/llvm-project?rev=263283&view=rev Log: Remove the skip if Darwin since I fixed the crash. Modified: lldb/trunk/packages/Python/lldbsuite/test/python_api/default-constructor/TestDefaultConstructorFo

[Lldb-commits] [lldb] r263274 - Check for a NULL input filehandle before referencing it.

2016-03-11 Thread Jim Ingham via lldb-commits
Author: jingham Date: Fri Mar 11 12:49:38 2016 New Revision: 263274 URL: http://llvm.org/viewvc/llvm-project?rev=263274&view=rev Log: Check for a NULL input filehandle before referencing it. Modified: lldb/trunk/scripts/Python/python-typemaps.swig Modified: lldb/trunk/scripts/Python/python

Re: [Lldb-commits] [PATCH] D17107: [lldb] Unicode support on Win32

2016-03-11 Thread Cameron via lldb-commits
cameron314 updated this revision to Diff 50449. cameron314 added a comment. ... and had a slash too many at the start of the path prefixes. Sorry for the spam. http://reviews.llvm.org/D17107 Files: lldb/trunk/cmake/modules/LLDBConfig.cmake lldb/trunk/include/lldb/Host/FileSystem.h lldb/t

Re: [Lldb-commits] [PATCH] D17107: [lldb] Unicode support on Win32

2016-03-11 Thread Cameron via lldb-commits
cameron314 updated this revision to Diff 50448. cameron314 added a comment. Oops, was missing a slash in the dst-prefix of the previous patch update. http://reviews.llvm.org/D17107 Files: /lldb/trunk/cmake/modules/LLDBConfig.cmake /lldb/trunk/include/lldb/Host/FileSystem.h /lldb/trunk/inc

Re: [Lldb-commits] [PATCH] D17107: [lldb] Unicode support on Win32

2016-03-11 Thread Cameron via lldb-commits
cameron314 updated this revision to Diff 50447. cameron314 added a comment. Here we go! http://reviews.llvm.org/D17549 has been committed, so I've rebased this patch onto that latest version (r263233). http://reviews.llvm.org/D17107 Files: /lldb/trunkcmake/modules/LLDBConfig.cmake /lldb/tr

Re: [Lldb-commits] [PATCH] D17957: Expression evaluation for overloaded C functions

2016-03-11 Thread Sean Callanan via lldb-commits
spyffe added a reviewer: clayborg. spyffe added a comment. Added Greg to look at the testsuite changes. Repository: rL LLVM http://reviews.llvm.org/D17957 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mai

Re: [Lldb-commits] [PATCH] D17957: Expression evaluation for overloaded C functions

2016-03-11 Thread Sean Callanan via lldb-commits
spyffe requested changes to this revision. spyffe added a comment. This revision now requires changes to proceed. There are a few changes I'd recommend to this patch. The biggest one is to move mangling knowledge from IRExecutionUnit to LanguageCPlusPlus, where it logically fits better. The tes

Re: [Lldb-commits] [PATCH] D18082: [LLDB]{MIPS] Fix TestPlatformProcessConnect.py

2016-03-11 Thread Greg Clayton via lldb-commits
clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. Repository: rL LLVM http://reviews.llvm.org/D18082 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm

Re: [Lldb-commits] [PATCH] D17957: Expression evaluation for overloaded C functions

2016-03-11 Thread Greg Clayton via lldb-commits
clayborg resigned from this revision. clayborg removed a reviewer: clayborg. clayborg added a comment. I will let Sean Callanan review this one as the expression parser is his area. Repository: rL LLVM http://reviews.llvm.org/D17957 ___ lldb-comm

[Lldb-commits] [lldb] r263233 - Fixed MemoryCache L1 cache flush

2016-03-11 Thread Marianne Mailhot-Sarrasin via lldb-commits
Author: mamai Date: Fri Mar 11 07:50:10 2016 New Revision: 263233 URL: http://llvm.org/viewvc/llvm-project?rev=263233&view=rev Log: Fixed MemoryCache L1 cache flush Use the same method to find the cache line as in Read(). Differential Revision: http://reviews.llvm.org/D18050 Added: lldb/tru

Re: [Lldb-commits] [PATCH] D18050: Fixed MemoryCache L1 cache flush

2016-03-11 Thread Marianne Mailhot-Sarrasin via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL263233: Fixed MemoryCache L1 cache flush (authored by mamai). Changed prior to commit: http://reviews.llvm.org/D18050?vs=50297&id=50422#toc Repository: rL LLVM http://reviews.llvm.org/D18050 Files:

Re: [Lldb-commits] [PATCH] D18082: [LLDB]{MIPS] Fix TestPlatformProcessConnect.py

2016-03-11 Thread Pavel Labath via lldb-commits
labath added a comment. If I understand correctly, you have simply copied the implementation from PlatformRemoteAndroidGDBServer. Could you also remove it from that class, since it's going to inherit the implementation anyway? Apart from that, it looks good to me, but let's give a chance for @c

[Lldb-commits] [PATCH] D18082: [LLDB]{MIPS] Fix TestPlatformProcessConnect.py

2016-03-11 Thread Nitesh Jain via lldb-commits
nitesh.jain created this revision. nitesh.jain added reviewers: clayborg, tberghammer, labath. nitesh.jain added subscribers: jaydeep, bhushan, sagar, mohit.bhakkad, lldb-commits. nitesh.jain set the repository for this revision to rL LLVM. The patch http://reviews.llvm.org/D14952 which modifies

Re: [Lldb-commits] [PATCH] D17957: Expression evaluation for overloaded C functions

2016-03-11 Thread Ewan Crawford via lldb-commits
EwanCrawford added a comment. friendly ping Repository: rL LLVM http://reviews.llvm.org/D17957 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D17856: Fix expression evaluation with operator new

2016-03-11 Thread Pavel Labath via lldb-commits
labath added a comment. Any thoughts on this? http://reviews.llvm.org/D17856 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r263209 - Fix a bunch of signedness warnings in unittests

2016-03-11 Thread Pavel Labath via lldb-commits
Author: labath Date: Fri Mar 11 03:00:23 2016 New Revision: 263209 URL: http://llvm.org/viewvc/llvm-project?rev=263209&view=rev Log: Fix a bunch of signedness warnings in unittests Modified: lldb/trunk/unittests/Editline/EditlineTest.cpp lldb/trunk/unittests/SymbolFile/PDB/SymbolFilePDBTe

[Lldb-commits] [lldb] r263207 - Fix a couple of cornercases in FileSpec + tests

2016-03-11 Thread Pavel Labath via lldb-commits
Author: labath Date: Fri Mar 11 02:44:44 2016 New Revision: 263207 URL: http://llvm.org/viewvc/llvm-project?rev=263207&view=rev Log: Fix a couple of cornercases in FileSpec + tests Summary: This fixes a couple of corner cases in FileSpec, related to AppendPathComponent and handling of root direc

Re: [Lldb-commits] [PATCH] D18044: Fix a couple of cornercases in FileSpec + tests

2016-03-11 Thread Pavel Labath via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL263207: Fix a couple of cornercases in FileSpec + tests (authored by labath). Changed prior to commit: http://reviews.llvm.org/D18044?vs=50275&id=50396#toc Repository: rL LLVM http://reviews.llvm.or

[Lldb-commits] [lldb] r263205 - skip newly segfaulting test on OS X public CI

2016-03-11 Thread Todd Fiala via lldb-commits
Author: tfiala Date: Fri Mar 11 02:12:36 2016 New Revision: 263205 URL: http://llvm.org/viewvc/llvm-project?rev=263205&view=rev Log: skip newly segfaulting test on OS X public CI Modified: lldb/trunk/packages/Python/lldbsuite/test/python_api/default-constructor/TestDefaultConstructorForAPIOb