labath added a comment. If I understand correctly, you have simply copied the implementation from PlatformRemoteAndroidGDBServer. Could you also remove it from that class, since it's going to inherit the implementation anyway?
Apart from that, it looks good to me, but let's give a chance for @clayborg to respond first. Repository: rL LLVM http://reviews.llvm.org/D18082 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
