[Linuxdcpp-team] [Bug 1774502] Re: Free GeoIP Database Format Change

2020-05-22 Thread Francisco Blas Izquierdo Riera (klondike)
I do agree with cologic's rationale on this :) I did avoid mmap for the following reasons: * My objective was a C implementation that was easy to use everywhere. mmap is UNIX specific, Windows for example uses a different API https://docs.microsoft.com/en-us/windows/win32/memory/file-mapping lib

Re: [Linuxdcpp-team] [Question #682215]: Simple release bot

2019-08-14 Thread Francisco Blas Izquierdo Riera (klondike)
Question #682215 on ADCH++ changed: https://answers.launchpad.net/adchpp/+question/682215 Status: Expired => Solved Francisco Blas Izquierdo Riera (klondike) changed the question status: I mailed laurent some code. Hopefully it can help him kickstart the development. -- You received t

Re: [Linuxdcpp-team] [Question #682215]: Simple release bot

2019-07-21 Thread Francisco Blas Izquierdo Riera (klondike)
Question #682215 on ADCH++ changed: https://answers.launchpad.net/adchpp/+question/682215 Status: Open => Needs information Francisco Blas Izquierdo Riera (klondike) requested more information: Are you familiar with any specific programming language? I used to code python based ADC bots

[Linuxdcpp-team] [Bug 1774502] Re: Free GeoIP Database Format Change

2019-02-25 Thread Francisco Blas Izquierdo Riera (klondike)
Hi eMtee, I coded this little library over the weekend, hopefully it will help :D https://github.com/klondi/mmdb -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1774502 Title: Free GeoIP Database F

Re: [Linuxdcpp-team] [Question #677391]: what lines of code determines what user has a key (like OP and Admin)

2019-01-08 Thread Francisco Blas Izquierdo Riera (klondike)
Question #677391 on ADCH++ changed: https://answers.launchpad.net/adchpp/+question/677391 Francisco Blas Izquierdo Riera (klondike) posted a new comment: Hi Derek, >From my side it's been a really long time since I last played with ADCH++ but I think I did this before. If you check the

[Linuxdcpp-team] [Question #632353]: Update to lua 5.1.5

2017-05-12 Thread Francisco Blas Izquierdo Riera (klondike)
New question #632353 on ADCH++: https://answers.launchpad.net/adchpp/+question/632353 Lua 5.1.5 has been avilable for quite some time already and is stable on Gentoo. It'd be nice if we could upgrade the embedded version and update the required system lua to the new version. -- You received th

[Linuxdcpp-team] [Bug 1620106] Re: Upgrade to OpenSSL 1.1

2016-09-04 Thread Francisco Blas Izquierdo Riera (klondike)
Hi, Although I'm all in for the cool new crypto I'd like to recommend waiting a bit (say 3 months) before releasing a client with the new OpenSSL version. My point is mostly based on OpenSSL's history itself, last time a major update happened: https://www.openssl.org/news/changelog.html#x9 and h

[Linuxdcpp-team] [Bug 1506210] Re: Decision on how to move forward with IPv6 connectivity setup

2016-08-29 Thread Francisco Blas Izquierdo Riera (klondike)
Hi guys, I have been reading this and I'm a bit confused regarding the port mappers and IPv6. In case it helps here is my knowledge about it: * UPnP has a draft for IPv6 https://tools.ietf.org/html/draft-bnss-v6ops-upnp-01 To my knowledge UPnP is the most extended solution for this task but I do

[Linuxdcpp-team] [Bug 1419454] Re: Error in processing NMDC search requests allows DC++ to be used for UDP DDOS attacks

2015-02-08 Thread Francisco Blas Izquierdo Riera (klondike)
poy, since the info is already public and has been made public at http ://te-home.net/?id=54&title=Second+largest+exploit+in+NMDC+history ¿shall we keep it private? -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchp

[Linuxdcpp-team] [Bug 1384543] [NEW] Update to lua 5.1.5

2014-10-22 Thread Francisco Blas Izquierdo Riera (klondike)
Public bug reported: Lua 5.1.5 has been avilable for quite some time already and is stable on Gentoo. It'd be nice if we could upgrade the embedded version and update the required system lua to the new version. ** Affects: adchpp Importance: Wishlist Status: Confirmed -- You recei

[Linuxdcpp-team] [Bug 907291] Re: adchpp doesnt shutdown on kill

2014-10-22 Thread Francisco Blas Izquierdo Riera (klondike)
I have had a commit around for this for some time on my branch but I can't remind why I didn't forward it. In case it helps it's at http://bazaar.launchpad.net/~klondike/adchpp/adchpp/revision/662 -- You received this bug notification because you are a member of Dcplusplus

[Linuxdcpp-team] [Bug 1308290] Re: Require TLS 1.2 connections for ADCS

2014-04-15 Thread Francisco Blas Izquierdo Riera (klondike)
Something that came just out of my head, couldn't we use the URI parameters as we do with the kp to implement this restriction? -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1308290 Title: Requir

[Linuxdcpp-team] [Bug 1297688] Re: Moving away from Win API to Multiplatform

2014-03-26 Thread Francisco Blas Izquierdo Riera (klondike)
Well there is EiskaltDC++ and the beta the guys at ApexDC are doing. So it's not such a bad world :P -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1297688 Title: Moving away from Win API to Multip

Re: [Linuxdcpp-team] [Question #236015]: rpi compile

2013-09-20 Thread klondike
Question #236015 on ADCH++ changed: https://answers.launchpad.net/adchpp/+question/236015 Status: Open => Answered klondike proposed the following answer: Nah I know it's gcc 4.6 :P I think I have found the issue in http://bazaar.launchpad.net /~dcplusplus-team/adchpp/trunk/view/he

Re: [Linuxdcpp-team] [Question #236015]: rpi compile

2013-09-20 Thread klondike
Question #236015 on ADCH++ changed: https://answers.launchpad.net/adchpp/+question/236015 Status: Open => Answered klondike proposed the following answer: This is caused because the linker rejects the undefined symbols of the lua wrapper for the bloom plugin. That's a strange bug s

Re: [Linuxdcpp-team] [Question #236015]: rpi compile

2013-09-20 Thread klondike
Question #236015 on ADCH++ changed: https://answers.launchpad.net/adchpp/+question/236015 Status: Open => Needs information klondike requested more information: BTW which version of adch++ are you trying to compile? -- You received this question notification because you are a member

[Linuxdcpp-team] [Bug 1206293] Re: Adch++ Goes down again

2013-08-22 Thread klondike
If I had to place a bet the issue may be because when unloading the Script plugin the associated pluginDatas aren't deleted so when they are later deleted the swig code to tell lua to free them isn't there. -- You received this bug notification because you are a member of Dcplusplus-team, which i

[Linuxdcpp-team] [Bug 1206293] Re: Adch++ Goes down again

2013-08-22 Thread klondike
The issue is that the code there for some reason assumes info is an entity and not a table thus trying to get the level from there. Commenting these lines should do the trick until info.changes should do the trick (I don't know access.guard well enough to say where the propper code should though).

[Linuxdcpp-team] [Bug 1132636] Re: Allow using the system lua libraries

2013-07-15 Thread klondike
** Changed in: adchpp Status: New => Fix Released -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to ADCH++. https://bugs.launchpad.net/bugs/1132636 Title: Allow using the system lua libraries Status in ADCH++: Fix Released Bug

[Linuxdcpp-team] [Bug 1132714] Re: Allow using the system boost libraries

2013-07-15 Thread klondike
** Changed in: adchpp Status: New => Fix Released -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to ADCH++. https://bugs.launchpad.net/bugs/1132714 Title: Allow using the system boost libraries Status in ADCH++: Fix Released Bu

[Linuxdcpp-team] [Bug 1132332] Re: The transition to STATE_DATA is not marked when using setDataMode

2013-07-15 Thread klondike
To the people needing this in the future: Fixing this caused a lot of crashes on the server I suppose because of code expecting STATE_NORMAL to happen only once. As done with Bloom plugin it's easier to add instead a specific notification when a particular instance of this happens (as of now this

[Linuxdcpp-team] [Bug 1131963] Re: The function add_stats(stat) should be exported

2013-07-15 Thread klondike
** Changed in: adchpp Status: New => Fix Released -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to ADCH++. https://bugs.launchpad.net/bugs/1131963 Title: The function add_stats(stat) should be exported Status in ADCH++: Fix Rel

[Linuxdcpp-team] [Bug 1131570] Re: adchpp::Core *getCurrentCore in swig/lua.i is broken because it shouldn't use fixed indices

2013-07-15 Thread klondike
** Changed in: adchpp Status: New => Fix Released -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to ADCH++. https://bugs.launchpad.net/bugs/1131570 Title: adchpp::Core *getCurrentCore in swig/lua.i is broken because it shouldn't

[Linuxdcpp-team] [Bug 1130835] Re: Allow TTH searchs on the bloom plugin to other plugins

2013-07-15 Thread klondike
** Changed in: adchpp Status: New => Fix Released -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to ADCH++. https://bugs.launchpad.net/bugs/1130835 Title: Allow TTH searchs on the bloom plugin to other plugins Status in ADCH++:

[Linuxdcpp-team] [Bug 1128591] Re: +regnick is broken on trunk

2013-07-15 Thread klondike
** Changed in: adchpp Status: New => Fix Released ** Changed in: adchpp Status: Fix Released => Fix Committed ** Changed in: adchpp Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed t

Re: [Linuxdcpp-team] [Merge] lp:~klondike/adchpp/adchpp into lp:adchpp

2013-07-10 Thread klondike
I have listed them, I hope that helps you, and thanks for the fixes (remerged them) too. -- https://code.launchpad.net/~klondike/adchpp/adchpp/+merge/150163 Your team Dcplusplus-team is subscribed to branch lp:adchpp. ___ Mailing list: https

Re: [Linuxdcpp-team] [Merge] lp:~klondike/adchpp/adchpp into lp:adchpp

2013-07-09 Thread klondike
Review: Abstain Hey poy added the signal API you requested I haven't tested it in depth yet but I'd like to know your comments. Made a mistake with the commit message though, sorry for that. -- https://code.launchpad.net/~klondike/adchpp/adchpp/+merge/150163 Your team Dcpluspl

[Linuxdcpp-team] [Bug 1189975] Re: Forbidden commands in ADC

2013-06-17 Thread klondike
Added ADCH++ and ADCH++ lan we should provide a way to filter those whilst the patches roll out. ** Also affects: adchpp-lan Importance: Undecided Status: New ** Changed in: adchpp-lan Assignee: (unassigned) => klondike (klondike) ** Also affects: adchpp Importance: Undeci

[Linuxdcpp-team] [Bug 1189975] Re: Forbidden commands in ADC

2013-06-12 Thread klondike
I can write a simple script to block these on ADCH++, has any of you managed to confirm this? -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1189975 Title: Forbidden commands in ADC Status in DC++

Re: [Linuxdcpp-team] [Merge] lp:~klondike/adchpp/adchpp into lp:adchpp

2013-03-06 Thread klondike
n, I can't see any other legitimate use for this that would return a shared_ptr here. The main problem is that if you are not returning a shared_ptr and the plugin gets removed then you may end up dereferencing invalid memory. -- https://code.launchpad.net/~klondike/adchpp/adchpp

Re: [Linuxdcpp-team] [Merge] lp:~klondike/adchpp/adchpp into lp:adchpp

2013-02-25 Thread klondike
de a little too, and add a getcon function to the dev system that will set up most of the values we set in each config. -- https://code.launchpad.net/~klondike/adchpp/adchpp/+merge/150163 Your team Dcplusplus-team is subscribed to branch lp:adchpp. ___

[Linuxdcpp-team] [Bug 1132714] Re: Allow using the system boost libraries

2013-02-25 Thread klondike
Please note this patch requires applying the lua one first. ** Branch linked: lp:~klondike/adchpp/adchpp -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to ADCH++. https://bugs.launchpad.net/bugs/1132714 Title: Allow using the system

[Linuxdcpp-team] [Bug 1132714] [NEW] Allow using the system boost libraries

2013-02-25 Thread klondike
Public bug reported: Similar as done with lua, if the system already provides a boost implementation there is no reason to try to use the bundled ones unless they are very old. The attached patch adds the systemboost variable which when set to yes will make the build system try to use the system

[Linuxdcpp-team] [Bug 1131963] Re: The function add_stats(stat) should be exported

2013-02-24 Thread klondike
** Changed in: adchpp Importance: Undecided => Wishlist -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to ADCH++. https://bugs.launchpad.net/bugs/1131963 Title: The function add_stats(stat) should be exported Status in ADCH++: New

[Linuxdcpp-team] [Bug 1130835] Re: Allow TTH searchs on the bloom plugin to other plugins

2013-02-24 Thread klondike
** Changed in: adchpp Importance: Undecided => Wishlist -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to ADCH++. https://bugs.launchpad.net/bugs/1130835 Title: Allow TTH searchs on the bloom plugin to other plugins Status in ADCH++:

[Linuxdcpp-team] [Bug 1132636] Re: Allow using the system lua libraries

2013-02-24 Thread klondike
** Branch linked: lp:~klondike/adchpp/adchpp -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to ADCH++. https://bugs.launchpad.net/bugs/1132636 Title: Allow using the system lua libraries Status in ADCH++: New Bug description: Now

[Linuxdcpp-team] [Bug 1131962] Re: Some local variables aren't marked as such

2013-02-24 Thread klondike
Closing as per the branch review. This is not a bug, ** Changed in: adchpp Status: New => Won't Fix ** Changed in: adchpp Assignee: (unassigned) => klondike (klondike) ** Changed in: adchpp Status: Won't Fix => Invalid -- You received this bug notificatio

[Linuxdcpp-team] [Bug 1132636] [NEW] Allow using the system lua libraries

2013-02-24 Thread klondike
Public bug reported: Now you can basically pick between using the lua library embedded in adch++ or the lua library embedded in adch++ (pun intended). The attached patch allows to use instead the system lua library if desired. For this the lua binary is required (and similar to python and ruby can

[Linuxdcpp-team] [Bug 1132332] Re: The transition to STATE_DATA is not marked when using setDataMode

2013-02-24 Thread klondike
The patch2 was incorrect, you'll need these changes too for it to work. Sorry for the inconvenience (fever isn't helping) ** Patch added: "Fix patch 2/2 so calls are properly made and move the method to the cpp file." https://bugs.launchpad.net/adchpp/+bug/1132332/+attachment/3545203/+files/a

[Linuxdcpp-team] [Bug 713742] Re: TimerManager generate double tick per second on some situations

2013-02-23 Thread klondike
Fixed the calls to the minute timer (the previous one got called 59 times xD) this time we use instead the samethod as with the second timer to get the information. Again this timer is still lossy, if you prefer a non lossy one (i,e, if suddendly 5 seconds pass it will mark the 5 seconds replace

Re: [Linuxdcpp-team] [Merge] lp:~klondike/adchpp/adchpp into lp:adchpp

2013-02-23 Thread klondike
Poy I also added the fix for bug #1132332 -- https://code.launchpad.net/~klondike/adchpp/adchpp/+merge/150163 Your team Dcplusplus-team is subscribed to branch lp:adchpp. ___ Mailing list: https://launchpad.net/~linuxdcpp-team Post to : linuxdcpp

[Linuxdcpp-team] [Bug 1132332] Re: The transition to STATE_DATA is not marked when using setDataMode

2013-02-23 Thread klondike
Nevermind, since you could get the previous state this is really easy to fix. ** Patch added: "Patch 1/2 check the previous state to ignore transitions coming from the DATA state" https://bugs.launchpad.net/adchpp/+bug/1132332/+attachment/3544135/+files/check_data_state.patch -- You receive

[Linuxdcpp-team] [Bug 1132332] Re: The transition to STATE_DATA is not marked when using setDataMode

2013-02-23 Thread klondike
** Patch added: "Patch 2/2 change the state to data and back to the previous one" https://bugs.launchpad.net/adchpp/+bug/1132332/+attachment/3544136/+files/send_data_state.patch -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to ADCH++.

[Linuxdcpp-team] [Bug 1132332] Re: The transition to STATE_DATA is not marked when using setDataMode

2013-02-23 Thread klondike
As usual copyright for the above patches is assigned to Jacek Sieka. ** Branch linked: lp:~klondike/adchpp/adchpp -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to ADCH++. https://bugs.launchpad.net/bugs/1132332 Title: The transition to

[Linuxdcpp-team] [Bug 1132332] [NEW] The transition to STATE_DATA is not marked when using setDataMode

2013-02-23 Thread klondike
Public bug reported: When using the setDataMode function the client won't change to the STATE_DATA state and thus scripts will not be noticed of the state change, similarly the transition back to STATE_NORMAL won't be notified. The main reason why this is not a trivial change is that a lot of our

Re: [Linuxdcpp-team] [Merge] lp:~klondike/adchpp/adchpp into lp:adchpp

2013-02-23 Thread klondike
to an empty string then the flag is gone for that environment (which is usually used for a single file). -- https://code.launchpad.net/~klondike/adchpp/adchpp/+merge/150163 Your team Dcplusplus-team is subscribed to branch lp:adchpp. ___ Mailing l

[Linuxdcpp-team] [Bug 1131962] Re: Some local variables aren't marked as such

2013-02-23 Thread klondike
Okay, that's then my mistake, I'm sorry for that, I'll revert the commits on the branch -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to ADCH++. https://bugs.launchpad.net/bugs/1131962 Title: Some local variables aren't marked as such S

[Linuxdcpp-team] [Bug 713742] Re: TimerManager generate double tick per second on some situations

2013-02-22 Thread klondike
I don't know if this will compile well or not, but basically it replaces the current code by other more simple that still follows the same guidelines (i.e. don't mark unmarked past events more than once but provide a tick count so it can be used to see how long has passed since the last call). The

[Linuxdcpp-team] [Bug 1131962] Re: Some local variables aren't marked as such

2013-02-22 Thread klondike
This patch is bigger but checks all the cases, it basically promotes up the variables with the same name amongst various for loops to the first block that will merge all the uses and is not inside a for without going out of the current function . Thus: * Variables in nested for won't get reallocat

[Linuxdcpp-team] [Bug 1128591] Re: +regnick is broken on trunk

2013-02-22 Thread klondike
** Branch linked: lp:~klondike/adchpp/adchpp -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to ADCH++. https://bugs.launchpad.net/bugs/1128591 Title: +regnick is broken on trunk Status in ADCH++: New Bug description: Apparantly I

[Linuxdcpp-team] [Bug 1130835] Re: Allow TTH searchs on the bloom plugin to other plugins

2013-02-22 Thread klondike
** Branch linked: lp:~klondike/adchpp/adchpp -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to ADCH++. https://bugs.launchpad.net/bugs/1130835 Title: Allow TTH searchs on the bloom plugin to other plugins Status in ADCH++: New Bug

[Linuxdcpp-team] [Bug 1131570] Re: adchpp::Core *getCurrentCore in swig/lua.i is broken because it shouldn't use fixed indices

2013-02-22 Thread klondike
** Branch linked: lp:~klondike/adchpp/adchpp -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to ADCH++. https://bugs.launchpad.net/bugs/1131570 Title: adchpp::Core *getCurrentCore in swig/lua.i is broken because it shouldn't use

[Linuxdcpp-team] [Bug 1131962] Re: Some local variables aren't marked as such

2013-02-22 Thread klondike
** Branch linked: lp:~klondike/adchpp/adchpp -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to ADCH++. https://bugs.launchpad.net/bugs/1131962 Title: Some local variables aren't marked as such Status in ADCH++: New Bug descri

[Linuxdcpp-team] [Bug 1131963] [NEW] The function add_stats(stat) should be exported

2013-02-22 Thread klondike
quot; https://bugs.launchpad.net/bugs/1131963/+attachment/3542415/+files/export_add_stat.patch ** Branch linked: lp:~klondike/adchpp/adchpp -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to ADCH++. https://bugs.launchpad.net/bugs/1131963 Title:

[Linuxdcpp-team] [Merge] lp:~klondike/adchpp/adchpp into lp:adchpp

2013-02-22 Thread klondike
klondike has proposed merging lp:~klondike/adchpp/adchpp into lp:adchpp. Requested reviews: Dcplusplus-team (dcplusplus-team) Related bugs: Bug #1128591 in ADCH++: "+regnick is broken on trunk" https://bugs.launchpad.net/adchpp/+bug/1128591 Bug #1130835 in ADCH++: "Allow

[Linuxdcpp-team] [Bug 1131962] [NEW] Some local variables aren't marked as such

2013-02-22 Thread klondike
Public bug reported: Some local variables aren't marked as such which could cause problems to some users. attached patch fixes it. ** Affects: adchpp Importance: Undecided Status: New ** Patch added: "Mark some local variables as local. Copyright assigned to Jacek Sieka." http

[Linuxdcpp-team] [Bug 1130835] Re: Allow TTH searchs on the bloom plugin to other plugins

2013-02-22 Thread klondike
And I also have updated the swig interface properly. ** Patch added: "3/3: Lua interface for the Bloom plugin. Copyright assigned to Jacek Sieka and stuff xD" https://bugs.launchpad.net/adchpp/+bug/1130835/+attachment/3541360/+files/bloom_lua.patch -- You received this bug notification beca

[Linuxdcpp-team] [Bug 1130835] Re: Allow TTH searchs on the bloom plugin to other plugins

2013-02-22 Thread klondike
I have updated the patch so it will also allow reading the statistics collected by the hub. ** Patch removed: "1/3: Export the hasTTH and hasBloom method so queries can be made from other plugins. Copyright assigned to Jacek Sieka and stuff xD" https://bugs.launchpad.net/adchpp/+bug/1130835/

[Linuxdcpp-team] [Bug 1130835] Re: Allow TTH searchs on the bloom plugin to other plugins

2013-02-21 Thread klondike
My mistake, but no comodity methods, anyway there was no reason to use them. -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to ADCH++. https://bugs.launchpad.net/bugs/1130835 Title: Allow TTH searchs on the bloom plugin to other plugins

[Linuxdcpp-team] [Bug 1130835] Re: Allow TTH searchs on the bloom plugin to other plugins

2013-02-21 Thread klondike
This version solves all the shortcomings: it provides a getBM method that doesn't require any arguments, and provides both the hasTTH and hasBloom methods as functions (so we call getBM) and as methods of the BloomManager object. ** Patch removed: "3/3: Lua interface for the Bloom plugin. Copyrigh

[Linuxdcpp-team] [Bug 1131570] [NEW] adchpp::Core *getCurrentCore in swig/lua.i is broken because it shouldn't use fixed indices

2013-02-21 Thread klondike
Public bug reported: The function adchpp::Core *getCurrentCore is broken since it uses the static index 1 when calling lua_touserdata despite more elements may have been added to the stack (the index should instead be the output of lua_gettop(l) ). The reason why it had worked until now was becaus

[Linuxdcpp-team] [Bug 1130835] Re: Allow TTH searchs on the bloom plugin to other plugins

2013-02-21 Thread klondike
I have used a proxy class to wrap the smart pointer so it can be accessed properly. The solution is still ugly but much less ugly than using .get() ** Patch removed: "3/3: Lua interface for the Bloom plugin. Copyright assigned to Jacek Sieka and stuff xD" https://bugs.launchpad.net/adchpp/+bu

[Linuxdcpp-team] [Bug 1130835] Re: Allow TTH searchs on the bloom plugin to other plugins

2013-02-21 Thread klondike
Lua interface for the bloom plugin. It's defined on a different module so it will be loaded only when explicitly imported. Current caveats: It's necessary to pass around the PM object since I couldn't get a valid core with the method available in lua.i Swig with lua and shared_ptr don't like each

[Linuxdcpp-team] [Bug 1130835] Re: Allow TTH searchs on the bloom plugin to other plugins

2013-02-21 Thread klondike
Updated the patch so it can also be queried whether the Bloom plugin has or not TTH information on the user. ** Patch removed: "Export the hasTTH method so queries can be made from other plugins. Copyright assigned to Jacek Sieka and stuff xD" https://bugs.launchpad.net/adchpp/+bug/1130835/+a

[Linuxdcpp-team] [Bug 1130835] Re: Allow TTH searchs on the bloom plugin to other plugins

2013-02-21 Thread klondike
Allow undefined symbols conditionally (needed to compile against plugins.so files since those don't start by lib). ** Patch added: "2/3: Allow undefined symbols conditionally. Copyright assigned to Jacek Sieka and stuff xD" https://bugs.launchpad.net/adchpp/+bug/1130835/+attachment/3540964/+

[Linuxdcpp-team] [Bug 1130835] [NEW] Allow TTH searchs on the bloom plugin to other plugins

2013-02-20 Thread klondike
Public bug reported: It would be very useful to be able to query the BLOOM filters of the users over other plugins (this includes at least lua). The attached patch adds a hasTTH method to the BLOOM plugin interface so other plugins can do this request. I intend to add also an extra lua library fo

[Linuxdcpp-team] [Bug 1128591] [NEW] +regnick is broken on trunk

2013-02-17 Thread klondike
Public bug reported: Apparantly I missed a case when preparing the get_user_level patch the attached patch fixed +reguser so it won't crash with a nil comparison error. ** Affects: adchpp Importance: Undecided Status: New ** Tags: blind is klondike ** Patch added: "Pa

[Linuxdcpp-team] [Bug 1038556] Re: Per session level handling

2013-02-10 Thread klondike
Let's do this then. Attached is the autolevel script as used in some of the lan parties where I have set up hubs. ** Attachment added: "Autolevel script, copyright assigned to Jacek sieka except on the 30th of February when it will be assigned back to me for the day." https://bugs.launchpad.

[Linuxdcpp-team] [Bug 1038556] Re: Per session level handling

2013-02-08 Thread klondike
yup, I'd appreciate if at least one more person reviewed the code to make sure I didn't overlook anything. All I can say is that it works in my hub. -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to ADCH++. https://bugs.lau

[Linuxdcpp-team] [Bug 1038556] Re: Per session level handling

2013-02-08 Thread klondike
On the future I plan having a command to assign a temporary level without need of registering as done in verlihub. Right now the only case I can come from its automatic level assignment based on external conditions ( in my case ip inside a range and share amount) to

[Linuxdcpp-team] [Bug 1038556] Re: Per session level handling

2013-02-08 Thread klondike
The previous centralization patch had some issues on access.guard (basically it didn't make it use access.get_level) this is fixed with this one. Remind this one needs to be applied before the other one. ** Patch added: "Patch to centralize level accesses into get_level. Copyright is hereby give

[Linuxdcpp-team] [Bug 1038556] Re: Per session level handling

2013-02-08 Thread klondike
** Patch removed: "Patch to centralize level accesses into get_level. Copyright is hereby given to Jacek Sieka (edit)" https://bugs.launchpad.net/adchpp/+bug/1038556/+attachment/3520405/+files/use_get_level.patch -- You received this bug notification because you are a member of Dcplusplus-te

[Linuxdcpp-team] [Bug 1038556] Re: Per session level handling

2013-02-08 Thread klondike
The attached patch contains the rest of the older patch using the new plugindata API in lua. It takes care of requesting the handler. Modifies the get_level function to use it and adds a set_level function. Finally it also adds the propper callbacks for the set_level function. ** Patch added: "Pat

[Linuxdcpp-team] [Bug 930960] Re: Adch++ doesnt work on ARM architecture

2013-02-08 Thread klondike
This patch makes all the scripts use the get_level function to check the user level. This makes it easier to have per session levels, or in general any other kind of level handling since it is now registered. -- You received this bug notification because you are a member of Dcplusplus-team, which

[Linuxdcpp-team] [Bug 1038556] Re: Per session level handling

2013-02-08 Thread klondike
This patch makes all the scripts use the get_level function to check the user level. This makes it easier to have per session levels, or in general any other kind of level handling since it is now centralized. ** Patch removed: "Same patch as above but with some fixes copyright assigned to Jacek

[Linuxdcpp-team] [Bug 930960] Re: Adch++ doesnt work on ARM architecture

2013-02-08 Thread klondike
Gah wrong bug, sorry for the noise. -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to ADCH++. https://bugs.launchpad.net/bugs/930960 Title: Adch++ doesnt work on ARM architecture Status in ADCH++: New Bug description: Hi, i compi

[Linuxdcpp-team] [Bug 1118699] Re: Add typeless object storage in per connection data in lua

2013-02-07 Thread klondike
Ok, never mind I'm stupid and was testing my own patch which apparently was broken (what a surprise). Thanks for improving over my code poy, now let's see if I can get a working (and cleaner) implementation of the per connection level patch for the other bug :D I have cherrypicked your patch into

[Linuxdcpp-team] [Bug 1118699] Re: Add typeless object storage in per connection data in lua

2013-02-07 Thread klondike
I can't confirm 2 but I can confirm 1 is false. If the the same handler on the same connection is assigned twice on the script the free_lua_ref function won't be called to free the old reference. -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribe

[Linuxdcpp-team] [Bug 1118699] Re: Add typeless object storage in per connection data in lua

2013-02-07 Thread klondike
The following patch (applied against the last commit) should do the trick. ** Patch added: "Patch to fix memory leaks and a possible NPE. Copyright asigned to Jacek Sieka" https://bugs.launchpad.net/adchpp/+bug/1118699/+attachment/3519817/+files/use_SWIGLUA_REF.patch -- You received this bu

[Linuxdcpp-team] [Bug 1118699] Re: Add typeless object storage in per connection data in lua

2013-02-07 Thread klondike
Poy, the committed patch as is is likely to cause some issues. Since no check for null is made on free_lua_ref this may crash if it is used with a null pointer passed by no data being added. Also on setPluginData you need to get the previous reference and free it with free_lua_ref or as was done

[Linuxdcpp-team] [Bug 1118699] Re: Add typeless object storage in per connection data in lua

2013-02-07 Thread klondike
Bear on mind this patch still requires some testing. -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to ADCH++. https://bugs.launchpad.net/bugs/1118699 Title: Add typeless object storage in per connection data in lua Status in ADCH++: N

[Linuxdcpp-team] [Bug 1038556] Re: Per session level handling

2013-02-07 Thread klondike
A patch to get any object stored is on bug #1118699 I'll rewrite the acces.lua patch to use that api when it gets applied. -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to ADCH++. https://bugs.launchpad.net/bugs/1038556 Title: Per sessio

[Linuxdcpp-team] [Bug 1118699] [NEW] Add typeless object storage in per connection data in lua

2013-02-07 Thread klondike
Public bug reported: Using SWIGLUA_REF is possible to store arbitrary lua object references for later usage. The propossed implementation should return nil if the object is not set and take care of keeping the references. ** Affects: adchpp Importance: Undecided Status: New ** Patc

[Linuxdcpp-team] [Bug 1038556] Re: Per session level handling

2012-08-19 Thread klondike
1) Indeed but these functions aren't documented. 2) The patch intends two things, first providing an easy a way to keep some session dependent data, and , on the other hand make a user level non dependent on the registration data. The intent is not only allowing users to have a different level t

[Linuxdcpp-team] [Bug 1038556] Re: Per session level handling

2012-08-19 Thread klondike
** Patch added: "Same patch as above but with some fixes copyright assigned to Jacek Sieka" https://bugs.launchpad.net/adchpp/+bug/1038556/+attachment/3267354/+files/session_level_v2.patch ** Patch removed: "Patch to add per session levels. Blah blah blah copyright assigned to jacek sieka bl

[Linuxdcpp-team] [Bug 1038556] Re: Per session level handling

2012-08-19 Thread klondike
Fixed some bugs involving SID data handling, now all seems kosher. -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to ADCH++. https://bugs.launchpad.net/bugs/1038556 Title: Per session level handling Status in ADCH++: New Bug descripti

[Linuxdcpp-team] [Bug 1038556] Re: Per session level handling

2012-08-19 Thread klondike
** Patch added: "Patch to add per session levels. Blah blah blah copyright assigned to jacek sieka blah blah blah" https://bugs.launchpad.net/bugs/1038556/+attachment/3267299/+files/session_level.patch -- You received this bug notification because you are a member of Dcplusplus-team, which i

[Linuxdcpp-team] [Bug 1038556] [NEW] Per session level handling

2012-08-19 Thread klondike
Public bug reported: This patch provides a per session element with some user data, currently this is just the level but in the future it could be other data. Similarly it modifies all the other example scripts so they use get_level and thus the session based level. ** Affects: adchpp Import

[Linuxdcpp-team] [Bug 940751] Re: Enable python on x64 and ia64 arches

2012-08-14 Thread klondike
This patch removes python only on windows arches not being x86 since these seem to be the problematic ones, posix works flawlessly ** Patch added: "Patch to fix that v2. Copyright is hereby given to Jacek Sieka" https://bugs.launchpad.net/adchpp/+bug/940751/+attachment/3260956/+files/adchpp-2.

[Linuxdcpp-team] [Bug 940751] Re: Enable python on x64 and ia64 arches

2012-05-26 Thread klondike
This fix was reversed, poy if you could please thell me what's the issue I can try to get it fixed. ** Changed in: adchpp Status: Fix Committed => Confirmed -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to ADCH++. https://bugs.launc

[Linuxdcpp-team] [Bug 676676] Re: building ruby module fails with msvc

2012-05-26 Thread klondike
This is because we seem to be missing the inttypes.h header in MSVC, there is a project providing these headers which we could bundle: http://code.google.com/p/msinttypes/ -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to ADCH++. https://bug

[Linuxdcpp-team] [Bug 940756] Re: Fix ruby.h detection and ruby path

2012-05-26 Thread klondike
Patch reordering environment setting to fix ruby detection on linux, please try on windows before commiting. ** Patch added: "Patch to fix that v2. Copyright is hereby given to Jacek Sieka" https://bugs.launchpad.net/adchpp/+bug/940756/+attachment/3164674/+files/ruby_fix_v2.patch -- You rec

[Linuxdcpp-team] [Bug 940756] Re: Fix ruby.h detection and ruby path

2012-05-26 Thread klondike
The new revision still fails, I tried to reorder environment settings to ensure the propper envrionment is set before looking for the header this seems to work well in linux but should be tried on windows. ** Changed in: adchpp Status: Fix Committed => Confirmed -- You received this bug n

[Linuxdcpp-team] [Bug 945674] [NEW] Please add more UNIX friendly paths.

2012-03-03 Thread klondike
Public bug reported: Currently the adch++ server uses a quite centralized system which is awful from a security point of view and is anything but helpful on most unices. Here is the propossal: * Since we don't have SONAMEs for the libraries we can install them along with the adchppd binary in /

[Linuxdcpp-team] [Bug 940756] Re: Fix ruby.h detection and ruby path

2012-02-24 Thread klondike
** Attachment added: "Patch to fix that. Copyright is hereby given to Jacek Sieka" https://bugs.launchpad.net/bugs/940756/+attachment/2781084/+files/adchpp-fix_ruby.patch -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to ADCH++. https:/

[Linuxdcpp-team] [Bug 940756] [NEW] Fix ruby.h detection and ruby path

2012-02-24 Thread klondike
Public bug reported: This patch allows the user select the path to the ruby binary (for example it is ruby19 in gentoo due to slot dependencies) it also fixes the CHeader file checking by letting the ruby binary set an appropriate environment before the test. ** Affects: adchpp Importance: U

[Linuxdcpp-team] [Bug 940751] [NEW] Enable python on x64 and ia64 arches

2012-02-24 Thread klondike
Public bug reported: There seems to be no need nowadays for this check according to swig documentation so we now check for this. ** Affects: adchpp Importance: Undecided Status: New -- You received this bug notification because you are a member of Dcplusplus-team, which is subscri

[Linuxdcpp-team] [Bug 940751] Re: Enable python on x64 and ia64 arches

2012-02-24 Thread klondike
** Patch added: "Patch to fix that. Copyright is hereby given to Jacek Sieka" https://bugs.launchpad.net/bugs/940751/+attachment/2781058/+files/adchpp-fix_python.patch -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to ADCH++. https://bug

[Linuxdcpp-team] [Bug 940750] [NEW] Fix guide path changing novice for expert

2012-02-24 Thread klondike
Public bug reported: This patch fixes a doc build problem by updating the path from novice guide to expert guide. ** Affects: adchpp Importance: Undecided Status: New -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to ADCH++.

[Linuxdcpp-team] [Bug 940750] Re: Fix guide path changing novice for expert

2012-02-24 Thread klondike
** Patch added: "Patch to fix that. Copyright is hereby given to Jacek Sieka" https://bugs.launchpad.net/bugs/940750/+attachment/2781057/+files/adchpp-fix_guide_paths.patch -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to ADCH++. https:

  1   2   >