[Linuxdcpp-team] [Bug 631913] Re: QP - Upload queue notification Support

Yes it sends to the transferview -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/631913 Title: QP - Upload queue notification Support Status in DC++: New Bug description: would love to have th

Re: [Linuxdcpp-team] [Bug 631913] Re: QP - Upload queue notification Support

yes it shows in transferview -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/631913 Title: QP - Upload queue notification Support Status in DC++: New Bug description: would love to have this f

[Linuxdcpp-team] [Bug 1032870] [NEW] ZLIF Support

Public bug reported: DC++ has supported ZLIF since any news on support in ADCH (this has been in DC++ for 8 months or so now) ** Affects: adchpp Importance: Wishlist Status: New -- You received this bug

[Linuxdcpp-team] [Bug 631913] Re: QP - Upload queue notification Support

yeah, the position is sent on the uploader's side, but i was wondering whether DC++ actually displays it when receiving a QP message. (can't test, i'm going by e-mail diffs.) -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bu

[Linuxdcpp-team] [Bug 631913] Re: QP - Upload queue notification Support

The race condition im going to look at I think i have a feasible solution. per the NMDC protocol, for the sake of being tired of arguing, i'll revert the change on the NMDC side as for point#4 I'm somewhat confused by the question (well just one part "is him") so let me answer as best as I can, i

[Linuxdcpp-team] [Bug 631913] Re: QP - Upload queue notification Support

i like the creative lambda in rev 3022. :) however, it re-introduces the race in the reserveSlot function. that one isn't trivial to solve by the way, because of the presence of the connect function. also, there is still another connect call inside a lock which should be taken out (BigMuscle men

[Linuxdcpp-team] [Branch ~dcplusplus-team/dcplusplus/trunk] Rev 3022: partially revert r3021, guard hasFreeSlot by the mutex

revno: 3022 committer: iceman50 branch nick: dcplusplus timestamp: Fri 2012-08-03 14:07:49 -0500 message: partially revert r3021, guard hasFreeSlot by the mutex modified: dcpp/UploadManager.cpp -- lp:dcplusplus https://code.launchp

[Linuxdcpp-team] [Bug 631913] Re: QP - Upload queue notification Support

Poy: theoretically it's not a NMDC feature since it lives in the core (protocol independent) also potential issues for older clients (iirc that wasn't an issue when removing DcLst and some other things) and I'll stick to the notion that since there is no protocol definition that, $MaxedOut was neve

[Linuxdcpp-team] [Bug 631913] Re: QP - Upload queue notification Support

- yes, UploadManager.cpp, line 108 is not protected - although calling ClientManager functions from UploadManager's critical section should be safe, I do not recomment to do it, because it can bring problems in the future (and it is not only about line 293 but also 488 which is called inside lo

[Linuxdcpp-team] [Bug 631913] Re: QP - Upload queue notification Support

re rev 3021: - i don't think it's safe to call ClientManager::getInstance()->connect from inside the lock - the previous code took good care to avoid that. - there was no need to add the lock to notifyQueuedUsers. - still a missing lock hasFreeSlot. as for #2, adding anything there is a protocol

[Linuxdcpp-team] [Branch ~dcplusplus-team/dcplusplus/trunk] Rev 3021: Guard waiting/connectingUsers by the mutex

revno: 3021 committer: iceman50 branch nick: dcplusplus timestamp: Fri 2012-08-03 06:40:07 -0500 message: Guard waiting/connectingUsers by the mutex modified: dcpp/UploadManager.cpp -- lp:dcplusplus https://code.launchpad.net/~dcpl