i like the creative lambda in rev 3022. :) however, it re-introduces the race in the reserveSlot function. that one isn't trivial to solve by the way, because of the presence of the connect function. also, there is still another connect call inside a lock which should be taken out (BigMuscle mentioned it).
re NMDC change: sigh, i'm not sure how to make it clearer that any deviation from the status quo, no matter how trivial, is a protocol change unless the protocol had a spec associated to it that allowed additional params. there may very well be a client/bot out there that considers that MaxedOut as ill-formed and stops trying to ask for the file again / bans the user (extreme, but it illustrates my point). one other point (let's call it #4): unless i missed it, the downloading user isn't notified of his position in the queue, is him? -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/631913 Title: QP - Upload queue notification Support Status in DC++: New Bug description: would love to have this feature added into dcpp so i know my place in que when downloading something http://adc.sourceforge.net/versions/ADC- EXT-1.0.4.html#_qp_upload_queue_notification To manage notifications about this bug go to: https://bugs.launchpad.net/dcplusplus/+bug/631913/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~linuxdcpp-team Post to : linuxdcpp-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~linuxdcpp-team More help : https://help.launchpad.net/ListHelp
