re rev 3021: - i don't think it's safe to call ClientManager::getInstance()->connect from inside the lock - the previous code took good care to avoid that. - there was no need to add the lock to notifyQueuedUsers. - still a missing lock hasFreeSlot.
as for #2, adding anything there is a protocol change since the protocol is not defined; so moving out of its current state, even with a seemingly innocuous bit such as this one, is a protocol change that can create potential issues. besides, we just don't want to add new features to NMDC. -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/631913 Title: QP - Upload queue notification Support Status in DC++: New Bug description: would love to have this feature added into dcpp so i know my place in que when downloading something http://adc.sourceforge.net/versions/ADC- EXT-1.0.4.html#_qp_upload_queue_notification To manage notifications about this bug go to: https://bugs.launchpad.net/dcplusplus/+bug/631913/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~linuxdcpp-team Post to : linuxdcpp-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~linuxdcpp-team More help : https://help.launchpad.net/ListHelp
