Re: [ANN] Media sessions in Lyon in October: libcamera

ee emails as well, so these things >> can be discussed in separate threads. >> >> All sessions are in room Terreaux VIP Lounge - Level 0. >> There is a maximum of 15 people. >> >> The second session deals with libcamera and is on Wednesday morning >> from

Re: [PATCH v3 5/6] rcar-vin: Add support for V4L2_FIELD_ALTERNATE

e this change a sensor providing data using alternate would be > always combined to an interlaced frame. After this change the user can s/would be always/would always be/ > request to receive frames as alternate if the sensor provides it. > > Signed-off-by: Niklas Söderlund

Re: [PATCH v3 2/6] rcar-vin: Make use of V4L2_FIELD_IS_INTERLACED() macro

On 04/09/2019 22:54, Niklas Söderlund wrote: > The V4L2_FIELD_IS_INTERLACED() can be used to make the code more > readable, use it. Definitely! > > Signed-off-by: Niklas Söderlund > Reviewed-by: Laurent Pinchart Reviewed-by: Kieran Bingham > --- > drivers/media/p

Re: [PATCH v3 1/6] rcar-vin: Fix incorrect return statement in rvin_try_format()

Hi Niklas, On 04/09/2019 22:54, Niklas Söderlund wrote: > While refactoring code the return statement became corrupted, fix it by > returning the correct return code. > > Reported-by: Kieran Bingham > Fixes: 897e371389e77514 ("media: rcar-vin: simplify how formats are set an

Re: [RFC] V4L2 & Metadata: switch to /dev/v4l-metaX instead of /dev/videoX

Hi Hans, On 12/09/2019 08:48, Hans Verkuil wrote: > Hi all, > > I am increasingly unhappy about the choice of /dev/videoX for metadata > devices. > > It is confusing for end-users (especially w.r.t. the common uvc driver) and > if we want to change this, then we need to do it soon. > > This pa

Re: [PATCH] rcar-vin: Use bytes per line instead of width for UV offset

ware, the width/ ? > Eeep, Subtle bug :) Reviewed-by: Kieran Bingham > Signed-off-by: Niklas Söderlund > --- > drivers/media/platform/rcar-vin/rcar-dma.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/platform/rcar-vin

Re: [PATCH] media: cx231xx: Spelling s/diconencted/diconnected/

Hi Geert, On 31/07/2019 14:40, Geert Uytterhoeven wrote: > Signed-off-by: Geert Uytterhoeven > --- > drivers/media/usb/cx231xx/cx231xx-cards.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/usb/cx231xx/cx231xx-cards.c > b/drivers/media/usb/cx231xx/cx231x

Re: [PATCH v2] v4l: rcar-fcp: Read IP version register at probe time

fine FCP_BA_REF_Y20x0118 > +#define FCP_BA_REF_C 0x011c Do we need to pull in all these extra register definitions just to read the version? They don't hurt if they're for something e

Re: [PATCH 2/2] max9286: Add MAX9286 driver

Hi Niklas, On 09/08/2019 13:23, Niklas Söderlund wrote: > Hi Kieran, > > On 2019-08-09 13:12:49 +0100, Kieran Bingham wrote: >> On 09/08/2019 13:04, Niklas Söderlund wrote: >>> Hi Kieran, >>> >>> Thanks for your feedback. >>> >>> On 201

Re: [PATCH 2/2] max9286: Add MAX9286 driver

On 09/08/2019 13:04, Niklas Söderlund wrote: > Hi Kieran, > > Thanks for your feedback. > > On 2019-08-09 09:09:43 +0100, Kieran Bingham wrote: >> Hi Niklas, >> >> This should be at least v5. > > I don't agree ;-) This is a "new" series whe

Re: [PATCH 2/2] max9286: Add MAX9286 driver

communications with connected cameras across the reverse control > channel. > > Signed-off-by: Jacopo Mondi > Signed-off-by: Kieran Bingham > Signed-off-by: Laurent Pinchart > Signed-off-by: Niklas Söderlund > --- > MAINTAINERS | 10 + > drivers/m

Re: [PATCH 1/2] dt-bindings: media: i2c: Add bindings for Maxim Integrated MAX9286

; Multimedia Serial Links (GMSL) and outputs them on a CSI-2 port using up > to 4 data lanes. > > Signed-off-by: Laurent Pinchart > Signed-off-by: Jacopo Mondi > Signed-off-by: Kieran Bingham > Reviewed-by: Niklas Söderlund > Signed-off-by: Niklas Söderlund > --- > .

Re: [PATCH 3/4] rcar-vin: Add support for V4L2_FIELD_ALTERNATE

Hi Niklas, On 05/07/2019 05:55, Niklas Söderlund wrote: > The hardware is capable to passing V4L2_FIELD_ALTERNATE to user-space. > Allow users to request this field format but still default to using the > hardware interlacer if alternating is not explicitly requested. I'm afraid I have found this

Re: [PATCH v2] rcar-vin: Clean up correct notifier in error path

gt; Signed-off-by: Niklas Söderlund > Reviewed-by: Jacopo Mondi > Tested-by: Geert Uytterhoeven Reviewed-by: Kieran Bingham > --- > drivers/media/platform/rcar-vin/rcar-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/rc

Re: [PATCH 4/4] rcar-vin: Clean up how format is set on subdevice

Hi Niklas, On 05/07/2019 05:55, Niklas Söderlund wrote: > With support for V4L2_FIELD_ALTERNATE added it's possible to clean up > how formats are set on the subdevice. This makes the code easier to read > as variable names now more clearly express their intent. > > Signed-off-by: Niklas Söderlund

Re: [PATCH 2/4] rcar-vin: Do not reset the crop and compose rectangles in s_fmt

e rectangles may be different after this call that might be worth expressing somehow. > Signed-off-by: Niklas Söderlund Does this deserve a fixes tag? Or is this more of a solitary change. With the wordings fixed, and expanded if you desire: Reviewed-by: Kieran Bingham > --- > drivers/me

Re: [PATCH 1/4] rcar-vin: Rename rectangle holding holding the video source information

name it src_rect in > preparation of refactoring code. > Sounds reasonable to me, and matches the other _rect instances in the code base. Reviewed-by: Kieran Bingham > Signed-off-by: Niklas Söderlund > --- > drivers/media/platform/rcar-vin/rcar-v4l2.c | 33 +++-- >

Re: [PATCH] rcar-vin: Centralize black listing of pixel formats

ded against in multiple locations. Centralise the format restriction by allowing the rvin_format_from_pixel() function to inspect the current platform and return a null pointer for unsupported formats. > Signed-off-by: Niklas Söderlund Otherwise, Reviewed-by: Kieran Bingham > ---

Re: [PATCH for 5.3] videodev2.h: change V4L2_PIX_FMT_BGRA444 define: fourcc was already in use

ooking at how these are all laid out. There's not a lot of choice of letters left, with BA12 and RA12, consumed, so GA12 seems reasonable. It's a shame the SRGB formats didn't choose an 'S' leading char or such. > Signed-off-by: Hans Verkuil > Cc: # for v5.2

[PATCH 0/6] media: i2c: Convert to probe_new()

-kieran.bingham+rene...@ideasonboard.com/ Kieran Bingham (6): media: radio: si4713: Convert to new i2c device probe() media: radio: si470x: Convert to new i2c device probe() media: i2c: smiapp: Convert to new i2c device probe() media: i2c: s5c73m3: Convert to new i2c device probe() media: i2c: et8ek8

Re: [PATCH] media: fdp1: Reduce FCP not found message level to debug

Hi Geert, On 09/07/2019 11:13, Geert Uytterhoeven wrote: > Hi Kieran, > > On Tue, Jul 9, 2019 at 12:07 PM Kieran Bingham > wrote: >> On 09/07/2019 10:59, Geert Uytterhoeven wrote: >>> When support for the IPMMU is not enabled, the FDP driver may be >>> pr

Re: [PATCH] media: fdp1: Reduce FCP not found message level to debug

Hi Geert, On 09/07/2019 10:59, Geert Uytterhoeven wrote: > When support for the IPMMU is not enabled, the FDP driver may be > probe-deferred multiple times, causing several messages to be printed > like: > > rcar_fdp1 fe94.fdp1: FCP not found (-517) > rcar_fdp1 fe944000.fdp1: FCP not

Re: [PATCH v3 4/4] rcar-vin: Always setup controls when opening video device

ret = v4l2_ctrl_handler_setup(&vin->ctrl_handler); > - if (ret) > - goto err_parallel; > - } > - } > mutex_unlock(&vin->lock); > > return 0; It was already here before this

Re: [PATCH v3 3/4] rcar-vin: Add support for RGB formats with alpha component

rol. Hrm, I expected there to be more ARGB formats supported, but the Gen3 datasheet does seem to indicate only the two. > Signed-off-by: Niklas Söderlund Reviewed-by: Kieran Bingham > --- > drivers/media/platform/rcar-vin/rcar-dma.c | 35 + > drivers/medi

Re: [PATCH v3 2/4] rcar-vin: Add control for alpha component

Pinchart Comment/Question below, but: Reviewed-by: Kieran Bingham > --- > drivers/media/platform/rcar-vin/rcar-core.c | 53 - > drivers/media/platform/rcar-vin/rcar-dma.c | 5 ++ > drivers/media/platform/rcar-vin/rcar-vin.h | 5 ++ > 3 files chang

Re: [PATCH v3 1/4] rcar-vin: Rename VNDMR_DTMD_ARGB1555 to VNDMR_DTMD_ARGB

cht > Reviewed-by: Laurent Pinchart Reviewed-by: Kieran Bingham > --- > drivers/media/platform/rcar-vin/rcar-dma.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/platform/rcar-vin/rcar-dma.c > b/drivers/media/platform/rcar-

Re: [linux-uvc-devel] Supported device missing. Realtek Integrated Webcam. 0bda:5751

Hi Jerinho, On 25/06/2019 13:55, jerinho via Linux-uvc-devel wrote: > Hi. I just want to report on a missing device for support by USB Video > Class driver. Details is as below > > Device details > > 1. Vendor Id / Device Id : 0bda / 5751 > 2. Device name : Realtek Integrated Webcam >

Re: [linux-uvc-devel] PAN+TILT for Logitech BCC950 ConferenceCam

Hi Andrej, On 17/06/2019 12:33, Andrej Pashnin wrote: > Dear developers,  > > I would like to control (pan-tilt-zoom) the following conference camera: >> Bus 001 Device 005: ID 046d:0837 Logitech, Inc. BCC950 ConferenceCam > It's a PTZ (pan-tilt-zoom) camera and I can control all 3 parameters > w

[PATCH] media: fdp1: Support M3N and E3 platforms

: Kieran Bingham --- drivers/media/platform/rcar_fdp1.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/media/platform/rcar_fdp1.c b/drivers/media/platform/rcar_fdp1.c index 6bda1eee9170..4f103be215d3 100644 --- a/drivers/media/platform/rcar_fdp1.c +++ b/drivers/media/platform

[PATCH v4 4/4] media: vsp1: Provide partition overlap algorithm

through the entity list. Each entity is given the opportunity to expand its window on the reverse sweep, and clip or increase the offset on the forwards sweep. Signed-off-by: Kieran Bingham --- v2: - Configure HSTP and HEDP in uds_configure_partition for single partitions - refactored to use

[PATCH v4 1/4] media: vsp1: Define partition algorithm helper

Provide a helper to describe when the partition algorithm is in use on a given pipeline. This improves readability to the purpose of the code, rather than obtusely checking the number of partitions. Signed-off-by: Kieran Bingham Reviewed-by: Laurent Pinchart --- v4: - Fix periods at the end

[PATCH v4 0/4] media: vsp1: Phased partition overlap support

update any offset which will mark left pixels to be discarded by the WPF (or UDS). Any expanded pixels to the right edge will automatically be clipped by the WPF as it's partition window will remain fixed. Kieran Bingham (4): media: vsp1: Define partition algorithm helper media: vsp1: Doc

[PATCH v4 3/4] media: vsp1: Split out pre-filter calculation

y a single function needs to be modified. Signed-off-by: Kieran Bingham --- drivers/media/platform/vsp1/vsp1_uds.c | 26 ++ 1 file changed, 18 insertions(+), 8 deletions(-) diff --git a/drivers/media/platform/vsp1/vsp1_uds.c b/drivers/media/platform/vsp1/vsp1_uds.c index 27

[PATCH v4 2/4] media: vsp1: Document partition algorithm in code header

The image partition algorithm operates on the image dimensions as input into the WPF entity. Document this in the code block header. Reviewed-by: Laurent Pinchart Signed-off-by: Kieran Bingham --- drivers/media/platform/vsp1/vsp1_video.c | 8 1 file changed, 8 insertions(+) diff

Re: [PATCH v3 5/5] media: vsp1: Provide partition overlap algorithm

Hi Laurent, On 18/04/2019 13:42, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Thu, Apr 11, 2019 at 05:12:56PM +0100, Kieran Bingham wrote: >> To improve image quality, entities involved within the image partition >> algorithm may exten

[PATCH v3 5/5] media: vsp1: Provide partition overlap algorithm

through the entity list. Each entity is given the opportunity to expand it's window on the reverse sweep, and clip or increase the offset on the forwards sweep. Signed-off-by: Kieran Bingham --- v2: - Configure HSTP and HEDP in uds_configure_partition for single partitions - refactored t

[PATCH v3 1/5] media: vsp1: Define partition algorithm helper

Provide a helper to describe when the partition algorithm is in use on a given pipeline. This improves readability to the purpose of the code, rather than obtusely checking the number of partitions. Signed-off-by: Kieran Bingham --- drivers/media/platform/vsp1/vsp1_pipe.c | 8

Re: Suppor for a new usb webcam for the uvcdriver

Hi Salvador, Sorry for the delay here, I've just seen this due to searching on the mailing list. On 07/03/2019 18:26, Salvador ` wrote: > Hi developers, > > In the past( https://www.spinics.net/lists/linux-media/msg147477.html > ) I reported how to add support to a new HP USB webcam for the > uv

Re: [PATCH] media: uvcvideo: Read support

Hi Hughes, On 04/03/2019 12:35, Hugues Fruchet wrote: > Add support of read() call from userspace by implementing > uvc_v4l2_read() with vb2_read() helper. Just thinking out loud, This opens up UVC devices to read raw full frame images through this interface as well. Due to the UVC protocol, th

Re: [RFC PATCH v2 5/5] media: vsp1: Provide partition overlap algorithm

On 01/03/2019 17:08, Kieran Bingham wrote: > From: Kieran Bingham > > To improve image quality when scaling using the UDS we need to correctly > determine the start phase value for each partition window, and apply a > margin to overlap discontinous pixels. > > Provide

[RFC PATCH v2 5/5] media: vsp1: Provide partition overlap algorithm

From: Kieran Bingham To improve image quality when scaling using the UDS we need to correctly determine the start phase value for each partition window, and apply a margin to overlap discontinous pixels. Provide helper functions for calculating the phase parameters, and source locations for a

[RFC PATCH v2 4/5] media: vsp1: Split out pre-filter multiplier

From: Kieran Bingham The 'mp' value is used through many calculations in determining the scaling factors of the UDS. Factor this out so that it can be reused in further calculations, and also ensure that if the BLADV control is ever changed only a single function needs to be modifie

[RFC PATCH v2 1/5] media: vsp1: Define partition algorithm helper

From: Kieran Bingham Provide a helper to describe when the partition algorithm is in use on a given pipeline. This improves readability to the purpose of the code, rather than obtusely checking the number of partitions. Signed-off-by: Kieran Bingham --- drivers/media/platform/vsp1

[RFC PATCH v2 0/5] media: vsp1: Partition phased overlap support

From: Kieran Bingham The UDS and SRU (and SHP) require expanded partition windows to support overlapping partition windows as a means of discarding discontinous pixel data, due to repeated pixels in their input filters. The first four patches are clean ups and helpers to facilitate the

[RFC PATCH v2 3/5] media: vsp1: Document partition algorithm in code header

From: Kieran Bingham The image partition algorithm operates on the image dimensions as input into the WPF entity. Document this in the code block header. Reviewed-by: Laurent Pinchart Signed-off-by: Kieran Bingham --- drivers/media/platform/vsp1/vsp1_video.c | 8 1 file changed, 8

[RFC PATCH v2 2/5] media: vsp1: Initialise partition windows

From: Kieran Bingham Ensure that the partition window is correctly initialised before being utilised. Signed-off-by: Kieran Bingham --- drivers/media/platform/vsp1/vsp1_video.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/vsp1/vsp1_video.c b

Re: [linux-uvc-devel] HD Camera (4e45:5501) support

Hi Amila, I believe this topic might get more attention on the linux-media mailing list (which I've added to Cc), but I have some comments below too: On 27/02/2019 16:41, Amila Manoj wrote: > Hello, > > > I'm trying to get this camera working with Ubuntu 18 (4.15.0-20-generic > x86_64 GNU/Linu

Re: [PATCH 3/3] rcar-csi2: Move setting of Field Detection Control Register

rcsi2_write(priv, PHYCNT_REG, phycnt); > rcsi2_write(priv, LINKCNT_REG, LINKCNT_MONITOR_EN | > LINKCNT_REG_MONI_PACT_EN | LINKCNT_ICLK_NONSTOP); > + rcsi2_write(priv, FLD_REG, fld); However, I can see that this matches the flow chart in figures 25.{17,18

Re: [PATCH 2/3] rcar-csi2: Update start procedure for H3 ES2

ct startup sequence. > > Signed-off-by: Niklas Söderlund Assuming the step1 table is accurate, which I have not yet been able to validate: Reviewed-by: Kieran Bingham > --- > drivers/media/platform/rcar-vin/rcar-csi2.c | 39 ++--- > 1 file changed, 35 insertions(+)

Re: [PATCH] rcar-vin: Fix lockdep warning at stream on

Hi Niklas, On 18/02/2019 01:43, Niklas Söderlund wrote: > Hi Kieran, > > On 2019-02-17 22:27:27 +0000, Kieran Bingham wrote: >> Hi Niklas, >> >> On 13/02/2019 22:07, Niklas Söderlund wrote: >>> Changes to v4l2-fwnode in commit [1] triggered a lockdep warning i

Re: [PATCH] rcar-vin: Fix lockdep warning at stream on

1. commit eae2aed1eab9bf08 ("media: v4l2-fwnode: Switch to > v4l2_async_notifier_add_subdev") > > Fixes: 6458afc8c49148f0 ("media: rcar-vin: remove unneeded locking in async > callbacks") > Signed-off-by: Niklas Söderlund Only a couple of minorish comments below. Wit

Re: [PATCH v4 6/7] media: vsp1: Replace the display list internal flag with a flags field

Hi Laurent, On 17/02/2019 02:48, Laurent Pinchart wrote: > To prepare for addition of more flags to the display list, replace the > 'internal' flag field by a bitmask 'flags' field. > > Signed-off-by: Laurent Pinchart Reviewed-by: Kieran Bingham > --- >

Re: [PATCH v4 5/7] media: vsp1: Refactor vsp1_video_complete_buffer() for later reuse

plete_buffer() to vsp1_video_complete_next_buffer(). > > Signed-off-by: Laurent Pinchart This looks good to me - except perhaps the documentation /might/ need some refresh. With or without updates there, the code changes look good to me: Reviewed-by: Kieran Bingham > --- > dri

Re: [PATCH v4 4/7] media: vsp1: Fix addresses of display-related registers for VSP-DL

ne used both LIF's :) (which I'm sure happens) > Signed-off-by: Laurent Pinchart Reviewed-by: Kieran Bingham > --- > drivers/media/platform/vsp1/vsp1_drm.c | 4 ++-- > drivers/media/platform/vsp1/vsp1_regs.h | 6 +++--- > drivers/media/platform/vsp1/vsp1_wpf.c |

Re: [PATCH v4 3/7] media: vsp1: Replace leftover occurrence of fragment with body

ut got in /after/ they were removed or something. > Signed-off-by: Laurent Pinchart Regardless, it looks correct to fix this up. Reviewed-by: Kieran Bingham > --- > drivers/media/platform/vsp1/vsp1_dl.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/

Re: [PATCH v4 2/7] media: vsp1: wpf: Fix partition configuration for display pipelines

an allocating a table for a single partition (which is what I had locally). > Signed-off-by: Laurent Pinchart I like that this change also simplifies the flip/rotate handling code to make that easier to read. Reviewed-by: Kieran Bingham > --- > drivers/media/platform/vsp1/vsp1_wpf.c | 1

Re: [PATCH v4 7/7] media: vsp1: Provide a writeback video device

Hi Laurent, On 17/02/2019 20:06, Kieran Bingham wrote: > Hi Laurent, > > Thank you for updating the patch, > > On 17/02/2019 02:48, Laurent Pinchart wrote: >> From: Kieran Bingham >> >> When the VSP1 is used in an active display pipeline, the output of the

Re: [PATCH v4 7/7] media: vsp1: Provide a writeback video device

Hi Laurent, Thank you for updating the patch, On 17/02/2019 02:48, Laurent Pinchart wrote: > From: Kieran Bingham > > When the VSP1 is used in an active display pipeline, the output of the > WPF can supply the LIF entity directly and simultaneously write to > memory. &g

Re: [linux-uvc-devel] metadata device file

Hi Moritz, On 15/02/2019 08:45, Moritz Dötterl wrote: > Hello > > Recently we updated the Kernel on our Ubuntu machines from 4.15 to 4.18 > because the OS was randomly freezing. However with the new Kernel we ran > into a problem regarding our two webcams. We had two /dev/video device > files per

Re: [PATCH 4/6] vsp1: fix smatch warning

then I looked at your patch ... So my initial reaction was completely wrong - and you have indeed got a good patch :) As this function is to 'setup the brx' I think it's very reasonable to use the chosen BRX pointer to do the configuration. (once all the dancing has gone on to sw

Re: [PATCH 3/6] uvc: fix smatch warning

Hi Hans, On 07/02/2019 10:13, Hans Overkill wrote: > drivers/media/usb/uvc/uvc_video.c: drivers/media/usb/uvc/uvc_video.c:1893 > uvc_video_start_transfer() warn: argument 2 to %u specifier is cast from > pointer > > Signed-off-by: Hans Verkuil This look fine to me. Revi

Re: ipu3-imgu 0000:00:05.0: required queues are disabled

Hi Kai-Heng, On 27/01/2019 05:56, Kai-Heng Feng wrote: > Hi, > > We have a bug report [1] that the ipu3 doesn’t work. > Does ipu3 need special userspace to work? Yes, it will need further userspace support to configure the pipeline, and to provide 3A algorithms for white balance, focus, and expo

Re: [PATCH 1/2] media: i2c: adv748x: Convert SW reset routine to function

Hi Hans, On 18/01/2019 12:09, Hans Verkuil wrote: > On 1/11/19 6:41 PM, Kieran Bingham wrote: >> The ADV748x is currently reset by writting a small table of registers to >> the device. s/writting/writing/ >> >> The table lacks documentation and contains magic value

[PATCH v2] media: i2c: adv748x: Remove PAGE_WAIT

The ADV748X_PAGE_WAIT is a fake page to insert arbitrary delays in the register tables. Its only usage was removed, so we can remove the handling and simplify the code. Reviewed-by: Laurent Pinchart Reviewed-by: Niklas Söderlund Signed-off-by: Kieran Bingham --- v2: - Use for loop with regs

Re: [PATCH v3 0/6] media: adv748x: Implement dynamic routing support

Hi Jacopo, for this series: Tested-by: Kieran Bingham For anyone else who wants to use this series, please remember that if you reset links on the media controller you will now have to set up the links between the HDMI/AFE and TXA/TXB with this series in place. The driver will default to the

Re: [PATCH v2] media: i2c: adv748x: Use devm to allocate the device struct

Hi Niklas, On 14/01/2019 13:06, Niklas Söderlund wrote: > Hi Kieran, > > Thanks for your work. > > On 2019-01-11 16:17:03 +, Kieran Bingham wrote: >> From: Steve Longerbeam >> >> Switch to devm_kzalloc() when allocating the adv748x device struct. >>

Re: [PATCH 1/2] media: i2c: adv748x: Convert SW reset routine to function

Hi Laurent, Thanks for the review, On 11/01/2019 20:15, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Friday, 11 January 2019 19:41:40 EET Kieran Bingham wrote: >> The ADV748x is currently reset by writting a small table of registers to >>

Re: [PATCH 2/2] media: i2c: adv748x: Remove PAGE_WAIT

Hi Laurent, On 11/01/2019 20:23, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Friday, 11 January 2019 19:41:41 EET Kieran Bingham wrote: >> The ADV748X_PAGE_WAIT is a fake page to insert arbitrary delays in the >> register tables. >>

[PATCH 1/2] media: i2c: adv748x: Convert SW reset routine to function

of the specific writes along the way. Signed-off-by: Kieran Bingham --- drivers/media/i2c/adv748x/adv748x-core.c | 32 drivers/media/i2c/adv748x/adv748x.h | 16 2 files changed, 38 insertions(+), 10 deletions(-) diff --git a/drivers/media/i2c/adv748x

[PATCH 0/2] media: i2c: adv748x: Refactor sw_reset handling

the delay workaround. Kieran Bingham (2): media: i2c: adv748x: Convert SW reset routine to function media: i2c: adv748x: Remove PAGE_WAIT drivers/media/i2c/adv748x/adv748x-core.c | 49 ++-- drivers/media/i2c/adv748x/adv748x.h | 17 +++- 2 files changed, 44 inserti

[PATCH 2/2] media: i2c: adv748x: Remove PAGE_WAIT

The ADV748X_PAGE_WAIT is a fake page to insert arbitrary delays in the register tables. Its only usage was removed, so we can remove the handling and simplify the code. Signed-off-by: Kieran Bingham --- drivers/media/i2c/adv748x/adv748x-core.c | 17 ++--- drivers/media/i2c/adv748x

[PATCH v2] media: i2c: adv748x: Use devm to allocate the device struct

From: Steve Longerbeam Switch to devm_kzalloc() when allocating the adv748x device struct. The sizeof() is updated to determine the correct allocation size from the dereferenced pointer type rather than hardcoding the struct type. Signed-off-by: Steve Longerbeam Reviewed-by: Kieran Bingham

Re: [PATCH 2/2] media: i2c: adv748x: Use devm to allocate the device struct

Hi Steve, On 11/01/2019 15:43, Kieran Bingham wrote: > From: Steve Longerbeam Thank you for the patch, (which was forwarded to me from the BSP team) > Switch to devm_kzalloc() when allocating the adv748x device struct. > > Signed-off-by: Steve Longerbeam > --- > drivers

Re: [PATCH 1/2] media: i2c: adv7482: Fix wait procedure usleep_range from msleep

Hi Matsuoka-san, Thank you for the patch, On 11/01/2019 15:43, Kieran Bingham wrote:> > From: Koji Matsuoka > > By Documentation/timers/timers-howto.txt, when waiting 20ms from 10us, > it is correct to use usleep_range. this patch corrects it. > > Signed-off-by: Koji Matsu

[PATCH 2/2] media: i2c: adv748x: Use devm to allocate the device struct

From: Steve Longerbeam Switch to devm_kzalloc() when allocating the adv748x device struct. Signed-off-by: Steve Longerbeam --- drivers/media/i2c/adv748x/adv748x-core.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/media/i2c/adv748x/adv748x-core.c b/drivers/

[PATCH 1/2] media: i2c: adv7482: Fix wait procedure usleep_range from msleep

From: Koji Matsuoka By Documentation/timers/timers-howto.txt, when waiting 20ms from 10us, it is correct to use usleep_range. this patch corrects it. Signed-off-by: Koji Matsuoka (cherry picked from horms/renesas-bsp commit af0cdba377bc8a784cdae6a77fb7a822cebc7083) Signed-off-by: Steve Longerb

Re: [PATCH v4 0/4] i2c: adv748x: add support for CSI-2 TXA to work in 1-, 2- and 4-lane mode

Hi Niklas, Thank you for this series. I think it really helps towards breaking down those pre-defined tables of register data. -- Kieran On 29/11/2018 02:01, Niklas Söderlund wrote: > Hi, > > This series allows the TXA CSI-2 transmitter of the adv748x to function > in 1-, 2- and 4- lane mode.

Re: [PATCH v4 4/4] i2c: adv748x: configure number of lanes used for TXA CSI-2 transmitter

er/value writes > when powering up/down the TXA and TXB transmitters which include the > write to the NUM_LANES register. By converting the tables into functions > and using parameters the power up/down functions for TXA and TXB power > up/down can be merged and used for both transmitte

Re: [PATCH v4 3/4] i2c: adv748x: store number of CSI-2 lanes described in device tree

h TX private data structure. > > TXA supports 1, 2 and 4 lanes while TXB supports 1 lane. > Reviewed-by: Kieran Bingham > Signed-off-by: Niklas Söderlund > Reviewed-by: Jacopo Mondi > Reviewed-by: Laurent Pinchart > Tested-by: Jacopo Mondi > > --- > * Change

Re: [PATCH v4 2/4] i2c: adv748x: reuse power up sequence when initializing CSI-2

hardware reducing code duplicating as well aligning with the > documentation. > > Signed-off-by: Niklas Söderlund > Reviewed-by: Laurent Pinchart > Tested-by: Jacopo Mondi Reviewed-by: Kieran Bingham > > --- > * Changes since v2 > - Bring in the undocum

Re: [PATCH v4 1/4] dt-bindings: adv748x: make data-lanes property mandatory for CSI-2 endpoints

llback on. > > Signed-off-by: Niklas Söderlund Reviewed-by: Kieran Bingham > > --- > * Changes since v3 > - Add paragraph to describe the accepted values for the source endpoint > data-lane property. Thanks Jacopo for pointing this out and sorry for > missing this in v2

Re: [PATCH v3 6/6] media: adv748x: Implement TX link_setup callback

at link setup time, to route > the selected video stream to the desired TX output. Reviewed-by: Kieran Bingham > Signed-off-by: Jacopo Mondi > --- > drivers/media/i2c/adv748x/adv748x-core.c | 48 +++- > drivers/media/i2c/adv748x/adv748x.h | 2 + >

Re: [PATCH v2 6/6] media: adv748x: Implement TX link_setup callback

Hi Jacopo, On 10/01/2019 08:58, Jacopo Mondi wrote: > On Wed, Jan 09, 2019 at 02:15:33PM +0000, Kieran Bingham wrote: >> On 09/01/2019 00:15, Laurent Pinchart wrote: >>> Hello, >>> >>> On Monday, 7 January 2019 14:36:28 EET Kieran Bingham wrote: >>

Re: [PATCH v2 6/6] media: adv748x: Implement TX link_setup callback

Hi Jacopo, One more comment below: On 07/01/2019 12:36, Kieran Bingham wrote: > Hi Jacopo, > > On 06/01/2019 15:54, Jacopo Mondi wrote: >> When the adv748x driver is informed about a link being created from HDMI or >> AFE to a CSI-2 TX output, the 'link_setup()&

Re: [PATCH v2 6/6] media: adv748x: Implement TX link_setup callback

On 09/01/2019 00:15, Laurent Pinchart wrote: > Hello, > > On Monday, 7 January 2019 14:36:28 EET Kieran Bingham wrote: >> On 06/01/2019 15:54, Jacopo Mondi wrote: >>> When the adv748x driver is informed about a link being created from HDMI >>> or AFE to a

Re: [PATCH v2 6/6] media: adv748x: Implement TX link_setup callback

Hi Jacopo, On 06/01/2019 15:54, Jacopo Mondi wrote: > When the adv748x driver is informed about a link being created from HDMI or > AFE to a CSI-2 TX output, the 'link_setup()' callback is invoked. Make > sure to implement proper routing management at link setup time, to route > the selected video

Re: [PATCH v2 5/6] media: adv748x: Store the TX sink in HDMI/AFE

stopping the stream. > Great - decouples the AFE/HDMI from a specific TX. Reviewed-by: Kieran Bingham > Reviewed-by: Laurent Pinchart > Signed-off-by: Jacopo Mondi > --- > drivers/media/i2c/adv748x/adv748x-afe.c | 2 +- > drivers/media/i2c/adv748x/adv748x-csi2.c | 15 +++

Re: [PATCH v2 4/6] media: adv748x: Store the source subdevice in TX

en HDMI and AFE entities to > TXA, checking which TX the function is operating on is not meaningful anymore. > > To fix this, store the subdevice of the source providing video data to the > CSI-2 TX in the 'struct adv748x_csi2' representing the TX and check on it. > Rev

Re: [PATCH v2 1/6] media: adv748x: Add is_txb()

Hi Jacopo, On 07/01/2019 10:05, Jacopo Mondi wrote: > Hi Kieran, >>> diff --git a/drivers/media/i2c/adv748x/adv748x.h >>> b/drivers/media/i2c/adv748x/adv748x.h >>> index b482c7fe6957..bc2da1b5ce29 100644 >>> --- a/drivers/media/i2c/adv748x/adv748x.h >>> +++ b/drivers/media/i2c/adv748x/adv748x.

Re: [PATCH v2 3/6] media: adv748x: csi2: Link AFE with TXA and TXB

g > from existing ones. Great - this looks good to me. Small nit below - but it's not a big deal. Reviewed-by: Kieran Bingham > Signed-off-by: Jacopo Mondi > --- > drivers/media/i2c/adv748x/adv748x-csi2.c | 44 +--- > 1 file changed, 23 insertions(+),

Re: [PATCH v2 2/6] media: adv748x: Rename reset procedures

Hi Jacopo, On 06/01/2019 15:54, Jacopo Mondi wrote: > Rename the chip reset procedure as they configure the CP (HDMI) and SD > (AFE) cores. Reviewed-by: Kieran Bingham > Reviewed-by: Laurent Pinchart > Signed-off-by: Jacopo Mondi > --- > drivers/media/i2c/adv748x/a

Re: [PATCH v2 1/6] media: adv748x: Add is_txb()

Hi Jacopo On 06/01/2019 15:54, Jacopo Mondi wrote: > Add small is_txb() macro to the existing is_txa() and use it where > appropriate. Thank you. I think this will make the code much better to read than if (!is_txa). > Signed-off-by: Jacopo Mondi Reviewed-by: Kiera

Re: [PATCH 5/5] media: adv748x: Implement link_setup callback

Hi Jacopo, On 12/12/2018 08:27, jacopo mondi wrote: > Hi Kieran, > > On Tue, Dec 11, 2018 at 11:43:08PM +0000, Kieran Bingham wrote: >> Hi Jacopo, >> >> On 11/12/2018 15:16, Jacopo Mondi wrote: >>> When the adv748x driver is informed about a link being create

Re: [PATCH 2/5] media: adv748x: csi2: Link AFE with TXA and TXB

Hi Jacopo, On 12/12/2018 08:21, jacopo mondi wrote: > Hi Kieran, > > On Tue, Dec 11, 2018 at 11:07:09PM +0000, Kieran Bingham wrote: >> Hi Jacopo, >> >> Thank you for the patch, >> >> On 11/12/2018 15:16, Jacopo Mondi wrote: >>> The ADV748x chip

Re: [PATCH 1/5] media: adv748x: Rework reset procedure

Heya On 12/12/2018 08:16, jacopo mondi wrote: > Hi Kieran, >thanks for review > > On Tue, Dec 11, 2018 at 11:52:03PM +0000, Kieran Bingham wrote: >> Hi Jacopo, >> >> On 11/12/2018 15:16, Jacopo Mondi wrote: >>> Re-work the chip reset procedure

Re: [PATCH 1/5] media: adv748x: Rework reset procedure

Hi Jacopo, On 11/12/2018 15:16, Jacopo Mondi wrote: > Re-work the chip reset procedure to configure the CP (HDMI) and SD (AFE) cores > before resetting the MIPI CSI-2 TXs. > > Signed-off-by: Jacopo Mondi > --- > drivers/media/i2c/adv748x/adv748x-core.c | 24 ++-- > 1 file ch

Re: [PATCH 5/5] media: adv748x: Implement link_setup callback

Hi Jacopo, On 11/12/2018 15:16, Jacopo Mondi wrote: > When the adv748x driver is informed about a link being created from HDMI or > AFE to a CSI-2 TX output, the 'link_setup()' callback is invoked. Make > sure to implement proper routing management at link setup time, to route > the selected video

Re: [PATCH 4/5] media: adv748x: Store the TX sink in HDMI/AFE

Hi Jacopo, On 11/12/2018 15:16, Jacopo Mondi wrote: > Both the AFE and HDMI s_stream routines (adv748x_afe_s_stream() and > adv748x_hdmi_s_stream()) have to enable the CSI-2 TX they are streaming video > data to. > > With the introduction of dynamic routing between HDMI and AFE entities to > TXA,

Re: [PATCH 3/5] media: adv748x: Store the source subdevice in TX

Hi Jacopo, On 11/12/2018 15:16, Jacopo Mondi wrote: > The power_up_tx() procedure needs to set a few registers conditionally to > the selected video source, but it currently checks for the provided tx to > be either TXA or TXB. > > With the introduction of dynamic routing between HDMI and AFE ent

Re: [PATCH 2/5] media: adv748x: csi2: Link AFE with TXA and TXB

Hi Jacopo, Thank you for the patch, On 11/12/2018 15:16, Jacopo Mondi wrote: > The ADV748x chip supports routing AFE output to either TXA or TXB. > In order to support run-time configuration of video stream path, create an > additional (not enabled) "AFE:8->TXA:0" link, and remove the IMMUTABLE f

  1   2   3   4   5   6   7   8   9   >