FW: skcipher and aead API question

2019-07-05 Thread Pascal Van Leeuwen
(+mailing list +davem) > > > You can just read tfm->authsize as that's what the default > > > setauthsize function will set. > > > > > I was referring to the case where it actually needed to be configurable. > > No that's what I meant. Look at the generic authenc template. > It supports truncati

FW: skcipher and aead API question

2019-07-05 Thread Pascal Van Leeuwen
(+mailing list +davem) > > Hmmm for a HW driver, the HW would have to do the truncation. > > So it must be capable of doing that AND it must be instructed to do so. > > I guess big deal is a relative term :-) > > Right for decryption you'd need to use a fallback. > Or I need to tell the HW

FW: skcipher and aead API question

2019-07-05 Thread Pascal Van Leeuwen
(+mailing list +davem) > > > Finally, I noticed that aead.h defines an additional callback > > 'setauthsize', which the > > driver currently also keeps at NULL and that *seems* to work fine with all > > current > > testmgr tests ... so I do wonder whether that is a must implement or not? > > And

Re: skcipher and aead API question

2019-07-05 Thread Herbert Xu
On Fri, Jul 05, 2019 at 09:48:53AM +, Pascal Van Leeuwen wrote: > Hi, > > Just browsing through include/crypto/skcipher.h and include/crypto/aead.h I > noticed that > struct skcipher_alg and struct aead_alg define callbacks named 'init' and > 'exit' as well as a > field called 'chunksize'. T

skcipher and aead API question

2019-07-05 Thread Pascal Van Leeuwen
Hi, Just browsing through include/crypto/skcipher.h and include/crypto/aead.h I noticed that struct skcipher_alg and struct aead_alg define callbacks named 'init' and 'exit' as well as a field called 'chunksize'. The inside-secure driver is currently initializing these fields to NULL or 0 and t