Re: BUG: Seems un-initialed dst pointer received from algif_aead when outlen is zero

2017-03-21 Thread Herbert Xu
On Tue, Mar 21, 2017 at 04:00:04PM +0100, Stephan Müller wrote: > Am Dienstag, 21. März 2017, 14:23:31 CET schrieb Harsh Jain: > > Hi Harsh, > > > Yes, Driver can figure out when to discard dst SGL but for that Driver > > has to put checks before accessing dst SGL. Isn't better if AF_ALG > > send

Re: BUG: Seems un-initialed dst pointer received from algif_aead when outlen is zero

2017-03-21 Thread Stephan Müller
Am Dienstag, 21. März 2017, 14:23:31 CET schrieb Harsh Jain: Hi Harsh, > Yes, Driver can figure out when to discard dst SGL but for that Driver > has to put checks before accessing dst SGL. Isn't better if AF_ALG > sends NULL for dst SGL. With the code in [1], the first longer patch is planned t

Re: BUG: Seems un-initialed dst pointer received from algif_aead when outlen is zero

2017-03-21 Thread Harsh Jain
On Tue, Mar 21, 2017 at 5:13 PM, Stephan Müller wrote: > Am Dienstag, 21. März 2017, 11:59:54 CET schrieb Harsh Jain: > > Hi Harsh, > >> > Executing this command on a 4.9 kernel, I get: >> > >> > bin/kcapi -x 2 -c "gcm(aes)" -i 0d92aa861746b324f20ee6b7 -k >> > f4a6a5e5f2066f6dd9ec6fc5169c2904356

Re: BUG: Seems un-initialed dst pointer received from algif_aead when outlen is zero

2017-03-21 Thread Harsh Jain
On Tue, Mar 21, 2017 at 4:29 PM, Harsh Jain wrote: > On Tue, Mar 21, 2017 at 3:34 PM, Stephan Müller wrote: >> Am Dienstag, 21. März 2017, 07:13:53 CET schrieb Harsh Jain: >> >> Hi Harsh, >> >>> Hi, >>> >>> For tag only AEAD decrypt operation(Zero length Payload). The dst sg >>> list pointer pani

Re: BUG: Seems un-initialed dst pointer received from algif_aead when outlen is zero

2017-03-21 Thread Stephan Müller
Am Dienstag, 21. März 2017, 11:59:54 CET schrieb Harsh Jain: Hi Harsh, > > Executing this command on a 4.9 kernel, I get: > > > > bin/kcapi -x 2 -c "gcm(aes)" -i 0d92aa861746b324f20ee6b7 -k > > f4a6a5e5f2066f6dd9ec6fc5169c29043560ef595c9e81e76f42d29212cc581c -a "" -t > > "5f24c68cbe6f32c296524

Re: BUG: Seems un-initialed dst pointer received from algif_aead when outlen is zero

2017-03-21 Thread Harsh Jain
On Tue, Mar 21, 2017 at 3:34 PM, Stephan Müller wrote: > Am Dienstag, 21. März 2017, 07:13:53 CET schrieb Harsh Jain: > > Hi Harsh, > >> Hi, >> >> For tag only AEAD decrypt operation(Zero length Payload). The dst sg >> list pointer panic with general protection fault. I think it should be >> NULL

Re: BUG: Seems un-initialed dst pointer received from algif_aead when outlen is zero

2017-03-21 Thread Stephan Müller
Am Dienstag, 21. März 2017, 07:13:53 CET schrieb Harsh Jain: Hi Harsh, > Hi, > > For tag only AEAD decrypt operation(Zero length Payload). The dst sg > list pointer panic with general protection fault. I think it should be > NULL when output buffer is supposed to be empty. > > Kcapi command to