From: Markus Elfring
Date: Sat, 12 Oct 2024 09:51:58 +0200
Move the reset of the data structure member “n” to a null pointer
into an if branch so that this assignment will be performed only after
a key parsing failure.
Signed-off-by: Markus Elfring
---
drivers/crypto/virtio
>> The kfree() function was called in up to two cases by the
>> __virtio_crypto_akcipher_do_req() function during error handling
>> even if the passed variable contained a null pointer.
>> This issue was detected by using the Coccinelle software.
>
> If the script is short and simple would you mind
From: Markus Elfring
Date: Tue, 26 Dec 2023 11:00:20 +0100
The kfree() function was called in up to two cases by the
__virtio_crypto_akcipher_do_req() function during error handling
even if the passed variable contained a null pointer.
This issue was detected by using the Coccinelle software
From: Markus Elfring
Date: Sun, 24 Dec 2023 20:42:19 +0100
The kfree() function was called in up to two cases by the
__virtio_crypto_akcipher_do_req() function during error handling
even if the passed variable contained a null pointer.
This issue was detected by using the Coccinelle software
…
> +++ b/drivers/crypto/chelsio/chcr_algo.c
> @@ -1224,7 +1224,7 @@ static int chcr_handle_cipher_resp(struct
> skcipher_request *req,
> wrparam.bytes = bytes;
> skb = create_cipher_wr(&wrparam);
> if (IS_ERR(skb)) {
> - pr_err("chcr : %s : Failed to form WR. No memo
> The error handling path of 'chcr_authenc_setkey()' is the same as this
> error handling code.
I find this change description improvable.
> So just 'goto out' as done everywhere in the function to simplify the code.
I propose to adjust jump targets a bit more for better exception handling
in t
> Fix this by …
Please replace the beginning of this sentence with the tag “Fixes”.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=625d3449788f85569096780592549d0340e9c0c7#n183
>>>
>>> No, not really. The co
>>> Fix this by …
>>
>> Please replace the beginning of this sentence with the tag “Fixes”.
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=625d3449788f85569096780592549d0340e9c0c7#n183
>
> No, not really. The comment you (p
> Fix this by …
Please replace the beginning of this sentence with the tag “Fixes”.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=625d3449788f85569096780592549d0340e9c0c7#n183
Regards,
Markus
> Indeed and I did but for some reason I cannot fathom the cover letter
> did not make it to the list.
Now it seems that I have got a questionable impression because you chose
to send only two messages from this patch series also to my email address
directly.
[PATCH 0/3] fixes and update to essi
> Brings the ccree essiv interface …
Wording adjustments:
Bring the …
> also use a fallback if requested a smaller key size.
… fallback if a smaller key size was requested.
Regards,
Markus
> Fix a small resource leak on the error path of cipher processing.
I find it more appropriate to resend this patch series with a cover letter
together with all update steps.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=646
I propose to avoid a typo in the previous patch subject.
> This patch brings the ccree essiv interface into
> compliance with kernel crypto api one.
Can an imperative wording be nicer for the commit message?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/pr
> Fix a small resource leak on the error path of cipher processing.
Would you like to add the tag “Fixes” to the commit message?
…
> +++ b/drivers/crypto/ccree/cc_cipher.c
…
> @@ -190,21 +198,19 @@ static int cc_cipher_init(struct crypto_tfm *tfm)
…
> - return rc;
> +out_key:
> + kfree(
> I respect your work, but please let us to focus on the code itself. I think
> experts in this area know what these patches want to solve after look at the
> code.
I suggest to reconsider such a view.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/s
>>> … Thus release specific resources before
>>
>> Is there a need to improve also this information another bit?
>>
> You mean the last two paragraph is redundant ?
No.
I became curious if you would like to choose a more helpful information
according to the wording “specific resources”.
Regards,
>> I suggest to move the addition of such input parameter validation
>> to a separate update step.
>>
> Um...The 'src_nents' will be used as a loop condition,
> so validate it here is needed ?
Would you prefer to add such checking as the first update in
another small patch series?
Regards,
Markus
> The system'll crash when the users insmod crypto/tcrypto.ko with mode=155
> ( testing "authenc(hmac(sha1),cbc(aes))" ). It's caused by reuse the memory
> of request structure.
Wording adjustments:
* … system will crash …
* … It is caused by reusing the …
> when these memory will be used again.
> Fix it by sg_next() on calculation of src/dst scatterlist.
Wording adjustment:
… by calling the function “sg_next” …
…
> +++ b/drivers/crypto/virtio/virtio_crypto_algs.c
> @@ -350,13 +350,18 @@ __virtio_crypto_skcipher_do_req(struct
> virtio_crypto_sym_request *vc_sym_req,
…
> src_nents
> Could you help me to make the sentence better?
How do you think about a wording variant like the following?
So the system will crash when this memory will be used again.
>> * You proposed to move a call of the function
>> “crypto_finalize_skcipher_request”.
>> How does this change fit to
> … So the system will crash
> at last when this memory be used again.
I would prefer a wording with less typos here.
> We can free the resources before calling ->complete to fix this issue.
* An imperative wording can be nicer.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.
> The system will crash when we insmod crypto/tcrypt.ko whit mode=38.
* I suggest to use the word “with” in this sentence.
* Will it be helpful to explain the passed mode number?
> BTW I add a check for sg_nents_for_len() its return value since
> sg_nents_for_len() function could fail.
Please
> In crypto_reportstat, a new skb is created by nlmsg_new(). This skb is
> leaked if crypto_reportstat_alg() fails. Required release for skb is
> added.
Please improve this change description.
Regards,
Markus
> In crypto_report, a new skb is created via nlmsg_new(). This skb should
> be released if crypto_report_alg() fails.
Please improve this change description.
Regards,
Markus
From: Markus Elfring
Date: Wed, 18 Sep 2019 09:34:11 +0200
Simplify this function implementation by using a known wrapper function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/char/hw_random/mtk-rng.c | 9 +
1 file changed, 1
From: Markus Elfring
Date: Wed, 18 Sep 2019 09:09:22 +0200
Simplify this function implementation by using a known wrapper function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/char/hw_random/iproc-rng200.c | 9 +
1 file changed
Hello,
The file “/proc/sys/kernel/random/uuid” provides a bit of useful data.
The formal definition of the string representation for universally unique
identifiers requires the use of four dashes for the concatenation of fields.
https://tools.ietf.org/html/rfc4122#page-4
https://stackoverflow.com/
From: Markus Elfring
Date: Mon, 12 Mar 2018 14:18:23 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/crypto/talitos.c | 1 -
1 file changed, 1 deletion(-)
diff
From: Markus Elfring
Date: Mon, 12 Mar 2018 14:08:55 +0100
Add jump targets so that an error message and the setting of a specific
error code is stored only once at the end of this function.
Signed-off-by: Markus Elfring
---
drivers/crypto/talitos.c | 24
1 file
From: Markus Elfring
Date: Mon, 12 Mar 2018 14:24:34 +0100
Two update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
Use common error handling code
Delete an error message for a failed memory allocation
drivers/crypto/talitos.c | 25
From: Markus Elfring
Date: Mon, 5 Mar 2018 13:50:13 +0100
Reuse existing functionality from memdup_user() instead of keeping
duplicate source code.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/crypto/ccp/psp-dev.c | 15 +--
1
> This patch is pointless as kfree on NULL is a no-op.
I prefer to avoid unnecessary function calls generally.
Regards,
Markus
>> @@ -1032,14 +1032,13 @@ static int omap_aes_get_res_pdev(struct omap_aes_dev
>> *dd,
>> static int omap_aes_probe(struct platform_device *pdev)
>> {
>> struct device *dev = &pdev->dev;
>> -struct omap_aes_dev *dd;
>> struct crypto_alg *algp;
>> struct aead_alg *aalg;
>>
From: Markus Elfring
Date: Thu, 15 Feb 2018 11:38:30 +0100
Omit extra messages for a memory allocation failure in these functions.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/crypto/atmel-aes.c | 6 +-
drivers/crypto/atmel-sha.c
From: Markus Elfring
Date: Wed, 14 Feb 2018 22:22:20 +0100
The kfree() function was called in one case by the do_shash() function
during error handling even if the passed variable contained a null pointer.
* Reorder two function calls at the end.
* Add a jump target.
Signed-off-by: Markus
From: Markus Elfring
Date: Wed, 14 Feb 2018 22:05:11 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/crypto/bcm/util.c | 1 -
1 file changed, 1 deletion(-)
diff
From: Markus Elfring
Date: Wed, 14 Feb 2018 22:30:07 +0100
Two update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
Delete an error message for a failed memory allocation
One function call less after error detection
drivers/crypto/bcm/util.c | 7
From: Markus Elfring
Date: Wed, 14 Feb 2018 21:34:54 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/crypto/bfin_crc.c | 4 +---
1 file changed, 1 insertion(+), 3
From: Markus Elfring
Date: Wed, 14 Feb 2018 19:14:49 +0100
Add jump targets so that a bit of exception handling can be better reused
at the end of these functions.
Signed-off-by: Markus Elfring
---
drivers/crypto/caam/caamalg.c | 32
drivers/crypto/caam
From: Markus Elfring
Date: Wed, 14 Feb 2018 18:22:38 +0100
Omit an extra message for a memory allocation failure in these functions.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/crypto/caam/caamalg.c | 6 +-
drivers/crypto/caam
From: Markus Elfring
Date: Wed, 14 Feb 2018 19:23:45 +0100
Two update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
Delete an error message for a failed memory allocation in seven functions
Use common error handling code in four functions
From: Markus Elfring
Date: Wed, 14 Feb 2018 17:05:13 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/crypto/nx/nx-842-pseries.c | 5 ++---
1 file changed, 2
From: Markus Elfring
Date: Wed, 14 Feb 2018 16:12:05 +0100
Replace the specification of data structures by pointer dereferences
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.
This
From: Markus Elfring
Date: Wed, 14 Feb 2018 16:00:33 +0100
Omit an extra message for a memory allocation failure in these functions.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/crypto/omap-aes.c | 5 ++---
drivers/crypto/omap-des.c
From: Markus Elfring
Date: Wed, 14 Feb 2018 16:18:19 +0100
Two update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
Delete error messages for a failed memory allocation
Improve size determinations
drivers/crypto/omap-aes.c | 8 +++-
drivers
From: Markus Elfring
Date: Wed, 14 Feb 2018 14:14:05 +0100
Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.
This
From: Markus Elfring
Date: Wed, 14 Feb 2018 14:10:03 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/crypto/sahara.c | 4 +---
1 file changed, 1 insertion(+), 3
From: Markus Elfring
Date: Wed, 14 Feb 2018 14:30:28 +0100
Two update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
Delete an error message for a failed memory allocation
Improve a size determination
drivers/crypto/sahara.c | 6 ++
1 file
From: Markus Elfring
Date: Wed, 14 Feb 2018 10:56:38 +0100
Two local variables will eventually be set to appropriate pointers
a bit later. Thus omit their explicit initialisation at the beginning.
Signed-off-by: Markus Elfring
---
drivers/crypto/ux500/cryp/cryp_core.c | 4 ++--
1 file changed
From: Markus Elfring
Date: Wed, 14 Feb 2018 10:47:31 +0100
Replace the function name in this error message so that the same name
is mentioned according to what was called before.
Signed-off-by: Markus Elfring
---
drivers/crypto/ux500/cryp/cryp_core.c | 2 +-
1 file changed, 1 insertion(+), 1
From: Markus Elfring
Date: Wed, 14 Feb 2018 10:38:44 +0100
The local variable "cryp_error" was used only for two condition checks.
* Check the return values from these function calls directly instead.
* Delete this variable which became unnecessary with this refactoring.
Signed-off-
From: Markus Elfring
Date: Wed, 14 Feb 2018 10:12:38 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/crypto/ux500/cryp/cryp_core.c | 1 -
1 file changed, 1
From: Markus Elfring
Date: Wed, 14 Feb 2018 11:12:34 +0100
A few update suggestions were taken into account
from static source code analysis.
Markus Elfring (4):
Delete an error message for a failed memory allocation
Adjust two condition checks
Adjust an error message
Delete two
>> From: Markus Elfring
>> Date: Sun, 22 Oct 2017 15:00:27 +0200
>>
>> Add a jump target so that a bit of exception handling can be better reused
>> at the end of this function.
>>
>> This issue was detected by using the Coccinelle software.
>>
>
From: Markus Elfring
Date: Sun, 22 Oct 2017 15:00:27 +0200
Add a jump target so that a bit of exception handling can be better reused
at the end of this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/crypto/s5p-sss.c | 13
From: Markus Elfring
Date: Sun, 22 Oct 2017 14:10:33 +0200
Add a jump target so that a bit of exception handling can be better reused
at the end of this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/crypto/ccp/sp-platform.c | 16
> Though, jumping back and forth like this with goto directives is something
> that looks a bit strange. At least to my taste, may I suggest to have gotos
> pointing only downwards and not up again? (Note, the same applies to the
> ansi_cprng patch set).
>
> What about something like following:
From: Markus Elfring
Date: Sat, 21 Oct 2017 19:33:45 +0200
The variable "ret" will eventually be set to an error code a bit later.
Thus omit the explicit initialisation at the beginning.
Signed-off-by: Markus Elfring
---
crypto/testmgr.c | 2 +-
1 file changed, 1 insertion(+),
From: Markus Elfring
Date: Sat, 21 Oct 2017 19:29:11 +0200
Adjust jump targets so that a bit of exception handling can be better
reused at the end of this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
crypto/testmgr.c | 31
From: Markus Elfring
Date: Sat, 21 Oct 2017 19:47:43 +0200
Two update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
Use common error handling code
Delete an unnecessary variable initialisation
crypto/testmgr.c | 33
From: Markus Elfring
Date: Sat, 21 Oct 2017 16:27:56 +0200
The script "checkpatch.pl" pointed information out like the following.
CHECK: Please don't use multiple blank lines
Thus fix the affected source code places.
Signed-off-by: Markus Elfring
---
crypto/ansi_cprng.c |
From: Markus Elfring
Date: Sat, 21 Oct 2017 16:10:43 +0200
Adjust a jump target so that two error code assignments which are redundant
before condition checks can be removed because the same value will be set
as an exception handling at the end of this function.
Signed-off-by: Markus Elfring
From: Markus Elfring
Date: Sat, 21 Oct 2017 15:17:52 +0200
Adjust jump targets so that a bit of exception handling can be better
reused at the end of this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
crypto/ansi_cprng.c | 34
From: Markus Elfring
Date: Sat, 21 Oct 2017 19:06:54 +0200
Two update suggestions were taken into account
from static source code analysis.
Markus Elfring (3):
Use common error handling code in get_prng_bytes()
Delete two variable assignments in get_prng_bytes()
Delete unnecessary blank
From: Markus Elfring
Date: Thu, 11 May 2017 17:05:17 +0200
Omit an extra message for a memory allocation failure in these functions.
This issue was detected by using the Coccinelle software.
Link:
http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
From: Markus Elfring
Date: Wed, 19 Apr 2017 10:50:04 +0200
The script "checkpatch.pl" pointed information out like the following.
WARNING: quoted string split across lines
Thus fix the affected source code places.
Signed-off-by: Markus Elfring
---
drivers/char/hw_random/n2
From: Markus Elfring
Date: Wed, 19 Apr 2017 10:30:47 +0200
* A multiplication for the size determination of a memory allocation
indicated that an array data structure should be processed.
Thus use the corresponding function "devm_kcalloc".
* Replace the specification of a data st
From: Markus Elfring
Date: Wed, 19 Apr 2017 11:00:11 +0200
Two update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
Use devm_kcalloc()
Combine substrings for two messages
drivers/char/hw_random/n2-drv.c | 12 +---
1 file changed, 5
From: Markus Elfring
Date: Thu, 15 Sep 2016 16:00:55 +0200
Move statements for error handling which were identical
in two if branches to the end of these functions.
Signed-off-by: Markus Elfring
---
drivers/crypto/caam/caamhash.c | 26 ++
1 file changed, 14 insertions
From: Markus Elfring
Date: Thu, 15 Sep 2016 15:24:02 +0200
The local variable "ret" will be set to an appropriate value a bit later.
Thus omit the explicit initialisation at the beginning.
Signed-off-by: Markus Elfring
---
drivers/crypto/caam/caamhash.c | 14 +++---
1 file
From: Markus Elfring
Date: Thu, 15 Sep 2016 14:56:12 +0200
* Return a value at the end without storing it in an intermediate variable.
* Delete the local variable "ret" which became unnecessary with
this refactoring.
Signed-off-by: Markus Elfring
---
drivers/crypto/caam/caam
From: Markus Elfring
Date: Thu, 15 Sep 2016 14:43:38 +0200
Adjust jump labels according to the current Linux coding style convention.
Signed-off-by: Markus Elfring
---
drivers/crypto/caam/caamhash.c | 49 +++---
1 file changed, 22 insertions(+), 27
From: Markus Elfring
Date: Thu, 15 Sep 2016 13:54:49 +0200
Adjust jump labels according to the current Linux coding style convention.
Signed-off-by: Markus Elfring
---
drivers/crypto/caam/caamhash.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/crypto
From: Markus Elfring
Date: Thu, 15 Sep 2016 11:20:09 +0200
* A multiplication for the size determination of a memory allocation
indicated that an array data structure should be processed.
Thus use the corresponding function "kmalloc_array".
This issue was detected by using the
From: Markus Elfring
Date: Thu, 15 Sep 2016 16:27:23 +0200
Some update suggestions were taken into account
from static source code analysis.
Markus Elfring (6):
Use kmalloc_array() in ahash_setkey()
Rename jump labels in ahash_setkey()
Rename a jump label in five functions
Return a
From: Markus Elfring
Date: Tue, 16 Aug 2016 07:51:21 +0200
The field "owner" is set by the core.
Thus delete an unneeded initialisation.
Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
Signed-off-by: Markus Elfring
---
drivers/char/hw_random/pic32-rng.c | 1 -
1 fi
>> Delete unnecessary checks before the function call "dma_pool_destroy"
It seems that you accepted this specific update suggestion, didn't you?
https://lkml.org/lkml/2015/11/17/391
https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1021951.html
>> Reduce assignment for a variable
From: Markus Elfring
Date: Tue, 17 Nov 2015 16:15:21 +0100
The dma_pool_destroy() function was called in up to two cases by the
init_ixp_crypto() function during error handling even if a call of
the dma_pool_create() function failed.
This implementation detail could be improved by the
From: Markus Elfring
Date: Tue, 17 Nov 2015 15:45:32 +0100
The variable "ret" was set more often than necessary by the
init_ixp_crypto() function.
* Omit its initialisation at the beginning.
* Use an error return code in two cases directly.
* Improve compliance with the Linux co
From: Markus Elfring
Date: Sun, 15 Nov 2015 16:51:21 +0100
The dma_pool_destroy() function tests whether its argument is NULL
and then returns immediately. Thus the test around the calls is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
From: Markus Elfring
Date: Tue, 17 Nov 2015 16:26:01 +0100
Subject: [PATCH 0/3] crypto-ixp4xx: Deletion of a few unnecessary checks
Further update suggestions were taken into account after a patch
was applied from static source code analysis.
Markus Elfring (3):
Delete unnecessary checks
From: Markus Elfring
Date: Sun, 15 Nov 2015 19:23:55 +0100
The dma_pool_destroy() function was called in up to two cases by the
init_ixp_crypto() function during error handling even if a call of
the dma_pool_create() function failed.
This implementation detail could be improved by the
From: Markus Elfring
Date: Sun, 15 Nov 2015 19:06:44 +0100
The variable "ret" was set more often than necessary by the
init_ixp_crypto() function.
* Omit its initialisation at the beginning.
* Use an error return code in two cases directly.
* Improve compliance with the Linux co
From: Markus Elfring
Date: Sun, 15 Nov 2015 18:28:39 +0100
The dma_pool_destroy() function was called twice with a null pointer
if a "npe_error" was reported.
This implementation detail could be improved by the introduction
of another jump label.
Signed-off-by: Markus Elfring
--
From: Markus Elfring
Date: Sun, 15 Nov 2015 16:51:21 +0100
The dma_pool_destroy() function tests whether its argument is NULL
and then returns immediately. Thus the test around the calls is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
From: Markus Elfring
Date: Sun, 15 Nov 2015 19:39:00 +0100
Further update suggestions were taken into account after a patch
was applied from static source code analysis.
Markus Elfring (4):
Delete unnecessary checks before the function call "dma_pool_destroy"
Two function cal
From: Markus Elfring
Date: Fri, 26 Jun 2015 20:30:11 +0200
The functions kfree() and release_firmware() test whether their argument
is NULL and then return immediately.
Thus the test around the calls is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus
From: Markus Elfring
Date: Tue, 23 Jun 2015 22:30:21 +0200
The kzfree() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
crypto
> Sorry but you're too late as someone else has already fixed this :)
Thanks for your feedback.
https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/crypto/drbg.c?id=46f64f6ef978dc1f36ebaa50ed79c7c8386711ee
Regards,
Markus
--
To unsubscribe from this list: send the line "unsu
From: Markus Elfring
Date: Wed, 19 Nov 2014 10:11:04 +0100
The kzfree() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
crypto
90 matches
Mail list logo
