From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Sun, 15 Nov 2015 16:51:21 +0100

The dma_pool_destroy() function tests whether its argument is NULL
and then returns immediately. Thus the test around the calls is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net>
---
 drivers/crypto/ixp4xx_crypto.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/crypto/ixp4xx_crypto.c b/drivers/crypto/ixp4xx_crypto.c
index 8f27903..e52496a 100644
--- a/drivers/crypto/ixp4xx_crypto.c
+++ b/drivers/crypto/ixp4xx_crypto.c
@@ -510,10 +510,8 @@ npe_error:
        printk(KERN_ERR "%s not responding\n", npe_name(npe_c));
        ret = -EIO;
 err:
-       if (ctx_pool)
-               dma_pool_destroy(ctx_pool);
-       if (buffer_pool)
-               dma_pool_destroy(buffer_pool);
+       dma_pool_destroy(ctx_pool);
+       dma_pool_destroy(buffer_pool);
        npe_release(npe_c);
        return ret;
 }
-- 
2.6.2
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to