> Though, jumping back and forth like this with goto directives is something > that looks a bit strange. At least to my taste, may I suggest to have gotos > pointing only downwards and not up again? (Note, the same applies to the > ansi_cprng patch set). > > What about something like following: > > ... > memcmp > goto free_rng;
Do you find an additional jump really acceptable at such a source code place? > report_failure: > <failure report> > > free_rng: > <the deallocation code> I am curious on how feedback will evolve also for the other design approach. Regards, Markus
