Re: [PATCH 0/4] RFC: "New" /dev/crypto user-space interface

2010-08-11 Thread Nikos Mavrogiannopoulos
2010/8/11 Linus Walleij : Hello, > Hi Miloslav, >   c.f how the ALSA mixer presents a lot of things to userspace without >   using any enums at all in /dev/snd/controlC0 for card 0. For example >   in include/linux/soundcard.h you find the different control knobs >   enumerated with strings so as

[PATCH] crypto/Kconfig: fix typo

2010-08-11 Thread Andy Isaacson
algolithm -> algorithm Signed-off-by: Andy Isaacson --- crypto/Kconfig |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/crypto/Kconfig b/crypto/Kconfig index 1cd497d..27484e4 100644 --- a/crypto/Kconfig +++ b/crypto/Kconfig @@ -102,7 +102,7 @@ config CRYPTO_MANAGER2

[PATCH] Add maintainer entries for padata/pcrypt

2010-08-11 Thread Steffen Klassert
Signed-off-by: Steffen Klassert --- MAINTAINERS | 16 1 files changed, 16 insertions(+), 0 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 8939947..3e9502e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4327,6 +4327,15 @@ L: linux-...@vger.kernel.org S: M

Re: [PATCH 0/4] RFC: "New" /dev/crypto user-space interface

2010-08-11 Thread Miloslav Trmac
- "Neil Horman" wrote: > On Tue, Aug 10, 2010 at 10:06:05PM -0400, Miloslav Trmac wrote: > > - "Neil Horman" wrote: > > > Ok, well, I suppose we're just not going to agree on this. I don't know > > > how > > > else to argue my case, you seem to be bent on re-inventing the wheel > > >

Re: [PATCH 0/4] RFC: "New" /dev/crypto user-space interface

2010-08-11 Thread Neil Horman
On Tue, Aug 10, 2010 at 10:06:05PM -0400, Miloslav Trmac wrote: > - "Neil Horman" wrote: > > Ok, well, I suppose we're just not going to agree on this. I don't know how > > else to argue my case, you seem to be bent on re-inventing the wheel > > instead of > > using what we have. Good luck.

Re: [PATCH 0/4] RFC: "New" /dev/crypto user-space interface

2010-08-11 Thread Miloslav Trmac
Hello, thanks your review and all comments. - "Linus Walleij" wrote: >For internal keys, a function for compare of HMAC function results >could improve security considerably. I'm afraid I don't understand what this refers to. Can you give me an example? (You already can use OP_VERI

Re: [PATCH 2/4] /dev/crypto implementation

2010-08-11 Thread Herbert Xu
On Thu, Aug 05, 2010 at 10:17:55PM +0200, Miloslav Trmač wrote: > > +static const struct algo_properties_st algo_properties[] = { > + { .algo = NCR_ALG_NULL, .kstr = "ecb(cipher_null)", > + .needs_iv = 0, .is_symmetric=1, .can_encrypt=1, > + .key_type = NCR_KEY_TYPE_INV