Re: [Kmymoney-devel] Review Request 109803: Add CSV export capability.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109803/ --- (Updated May 5, 2013, 5:28 p.m.) Status -- This change has been marke

Re: [Kmymoney-devel] Review Request 109803: Add CSV export capability.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109803/#review32047 --- Ship it! Ship It! - Thomas Baumgart On April 24, 2013, 6:16

Re: [Kmymoney-devel] Review Request 109803: Add CSV export capability.

> On April 24, 2013, 10 p.m., Thomas Baumgart wrote: > > kmymoney/plugins/csvexport/csvwriter.cpp, line 101 > > > > > > why not using "\n\n" instead? Your way needs one more byte of mem plus > > cpu time during e

Re: [Kmymoney-devel] Review Request 109803: Add CSV export capability.

> On April 24, 2013, 8 p.m., Thomas Baumgart wrote: > > kmymoney/plugins/csvexport/csvexporterplugin.h, line 45 > > > > > > Public member vars > > Allan Anderson wrote: > Not sure how to go about this as it is

Re: [Kmymoney-devel] Review Request 109803: Add CSV export capability.

> On April 24, 2013, 10 p.m., Thomas Baumgart wrote: > > kmymoney/plugins/csvexport/csvexporterplugin.h, line 45 > > > > > > Public member vars > > Allan Anderson wrote: > Not sure how to go about this as it i

Re: [Kmymoney-devel] Review Request 109803: Add CSV export capability.

On Thu, 25 Apr 2013 19:40:50 - Marko Käning wrote: > > > > On April 24, 2013, 8 p.m., Thomas Baumgart wrote: > > > kmymoney/plugins/csvexport/csvwriter.cpp, line 190 > > > > > > > > > Here's another way to d

Re: [Kmymoney-devel] Review Request 109803: Add CSV export capability.

> On April 24, 2013, 8 p.m., Thomas Baumgart wrote: > > kmymoney/plugins/csvexport/csvwriter.cpp, line 190 > > > > > > Here's another way to do this: > > > > str += QString("\"%1\",").arg(payee.name());

Re: [Kmymoney-devel] Review Request 109803: Add CSV export capability.

> On April 24, 2013, 8 p.m., Thomas Baumgart wrote: > > kmymoney/plugins/csvexport/csvexportdlg.h, line 68 > > > > > > You should not make member vars public. Simply move those two > > declarations to the bottom w

Re: [Kmymoney-devel] Review Request 109803: Add CSV export capability.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109803/#review31509 --- Unless you want the member vars public you should really make t

Re: [Kmymoney-devel] Review Request 109803: Add CSV export capability.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109803/ --- (Updated April 24, 2013, 4:16 p.m.) Review request for KMymoney. Changes

Re: [Kmymoney-devel] Review Request 109803: Add CSV export capability.

> On April 21, 2013, 1:39 p.m., Thomas Baumgart wrote: > > kmymoney/plugins/csvexport/csvexportdlg.h, line 55 > > > > > > Using the xxxDecl classes is somewhat old fashioned. No need for that > > in this case. You

Re: [Kmymoney-devel] Review Request 109803: Add CSV export capability.

> On April 21, 2013, 3:39 p.m., Thomas Baumgart wrote: > > kmymoney/plugins/csvexport/csvwriter.cpp, line 218 > > > > > > Such constructs are the reason for so many performance problems (though > > not here I ass

Re: [Kmymoney-devel] Review Request 109803: Add CSV export capability.

> On April 21, 2013, 1:39 p.m., Thomas Baumgart wrote: > > I just did a more formal review and noticed a few things that might receive > > some improvements. Sorry for being late with the review. Appreciate you finding the time, thanks. A couple of responses now, then I'll go through the rest

Re: [Kmymoney-devel] Review Request 109803: Add CSV export capability.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109803/#review31365 --- I just did a more formal review and noticed a few things that m

Re: [Kmymoney-devel] Review Request 109803: Add CSV export capability.

> On April 19, 2013, 11:54 a.m., Cristian Oneț wrote: > > csvexportdlgdecl.ui is not in the patch. Please provide the full patch > > against git master not only of your latest commit: > > $git format-patch origin/master > > Allan Anderson wrote: > It definitely shows as being in the first p

Re: [Kmymoney-devel] Review Request 109803: Add CSV export capability.

> On April 19, 2013, 11:54 a.m., Cristian Oneț wrote: > > csvexportdlgdecl.ui is not in the patch. Please provide the full patch > > against git master not only of your latest commit: > > $git format-patch origin/master > > Allan Anderson wrote: > It definitely shows as being in the first p

Re: [Kmymoney-devel] Review Request 109803: Add CSV export capability.

> On April 19, 2013, 11:54 a.m., Cristian Oneț wrote: > > csvexportdlgdecl.ui is not in the patch. Please provide the full patch > > against git master not only of your latest commit: > > $git format-patch origin/master > > Allan Anderson wrote: > It definitely shows as being in the first p

Re: [Kmymoney-devel] Review Request 109803: Add CSV export capability.

> On April 19, 2013, 11:54 a.m., Cristian Oneț wrote: > > csvexportdlgdecl.ui is not in the patch. Please provide the full patch > > against git master not only of your latest commit: > > $git format-patch origin/master > > Allan Anderson wrote: > It definitely shows as being in the first p

Re: [Kmymoney-devel] Review Request 109803: Add CSV export capability.

> On April 19, 2013, 11:54 a.m., Cristian Oneț wrote: > > csvexportdlgdecl.ui is not in the patch. Please provide the full patch > > against git master not only of your latest commit: > > $git format-patch origin/master > > Allan Anderson wrote: > It definitely shows as being in the first p

Re: [Kmymoney-devel] Review Request 109803: Add CSV export capability.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109803/ --- (Updated April 19, 2013, 5:52 p.m.) Review request for KMymoney. Changes

Re: [Kmymoney-devel] Review Request 109803: Add CSV export capability.

> On April 19, 2013, 11:54 a.m., Cristian Oneț wrote: > > csvexportdlgdecl.ui is not in the patch. Please provide the full patch > > against git master not only of your latest commit: > > $git format-patch origin/master > > Allan Anderson wrote: > It definitely shows as being in the first p

Re: [Kmymoney-devel] Review Request 109803: Add CSV export capability.

> On April 19, 2013, 11:54 a.m., Cristian Oneț wrote: > > csvexportdlgdecl.ui is not in the patch. Please provide the full patch > > against git master not only of your latest commit: > > $git format-patch origin/master > > Allan Anderson wrote: > It definitely shows as being in the first p

Re: [Kmymoney-devel] Review Request 109803: Add CSV export capability.

> On April 19, 2013, 11:54 a.m., Cristian Oneț wrote: > > csvexportdlgdecl.ui is not in the patch. Please provide the full patch > > against git master not only of your latest commit: > > $git format-patch origin/master > > Allan Anderson wrote: > It definitely shows as being in the first p

Re: [Kmymoney-devel] Review Request 109803: Add CSV export capability.

> On April 19, 2013, 11:54 a.m., Cristian Oneț wrote: > > csvexportdlgdecl.ui is not in the patch. Please provide the full patch > > against git master not only of your latest commit: > > $git format-patch origin/master > > Allan Anderson wrote: > It definitely shows as being in the first p

Re: [Kmymoney-devel] Review Request 109803: Add CSV export capability.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109803/#review31282 --- csvexportdlgdecl.ui is not in the patch. Please provide the ful

Re: [Kmymoney-devel] Review Request 109803: Add CSV export capability.

> On April 19, 2013, 7:25 a.m., Cristian Oneț wrote: > > > > Allan Anderson wrote: > If you're happy with below, I'll ship later. > > Cristian Oneț wrote: > Please update the patch in this review before shipping it. Will now update the patch. > On April 19, 2013, 7:25 a.m., Cristian

Re: [Kmymoney-devel] Review Request 109803: Add CSV export capability.

> On April 19, 2013, 7:25 a.m., Cristian Oneț wrote: > > > > Allan Anderson wrote: > If you're happy with below, I'll ship later. Please update the patch in this review before shipping it. - Cristian --- This is an automatically ge

Re: [Kmymoney-devel] Review Request 109803: Add CSV export capability.

> On April 19, 2013, 7:25 a.m., Cristian Oneț wrote: > > kmymoney/plugins/csvexport/kmm_csvexport.desktop, line 56 > > > > > > Please remove the translations (all [lang] entries) since they will be > > handled by

Re: [Kmymoney-devel] Review Request 109803: Add CSV export capability.

> On April 19, 2013, 7:25 a.m., Cristian Oneț wrote: > > If you're happy with below, I'll ship later. > On April 19, 2013, 7:25 a.m., Cristian Oneț wrote: > > kmymoney/plugins/csvexport/csvexporterrc, line 4 > > > >

Re: [Kmymoney-devel] Review Request 109803: Add CSV export capability.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109803/#review31271 --- kmymoney/plugins/csvexport/csvexporterrc

Re: [Kmymoney-devel] Review Request 109803: Add CSV export capability.

> On April 19, 2013, 6:48 a.m., Marko Käning wrote: > > Hi Alan, > > > > I have build, installed and run KMM4 with your patch on Mac OS X Snow > > Leopard. > > > > I was able to successfully export CSV for a few accounts in a breeze > > (account and category contents). > > > > Looks like thi

Re: [Kmymoney-devel] Review Request 109803: Add CSV export capability.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109803/#review31269 --- Ship it! Hi Alan, I have build, installed and run KMM4 with y

[Kmymoney-devel] Review Request 109803: Add CSV export capability.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109803/ --- Review request for KMymoney. Description --- Add CSV export capabilit